Checkstyle Results
The following document contains the results of Checkstyle. 
Files
Rules
| Rules | Violations | Severity |
|---|---|---|
JavadocPackage
| 0 |  Error |
| NewlineAtEndOfFile | 0 | Error |
| Translation | 0 | Error |
| FileLength | 0 | Error |
FileTabCharacter
| 0 | Error |
RegexpSingleline
| 0 | Error |
| JavadocMethod | 409 | Error |
| JavadocType | 0 | Error |
| JavadocVariable | 0 | Error |
| JavadocStyle | 2110 | Error |
| ConstantName | 0 | Error |
| LocalFinalVariableName | 0 | Error |
| LocalVariableName | 0 | Error |
| MemberName | 0 | Error |
| MethodName | 0 | Error |
| PackageName | 0 | Error |
| ParameterName | 0 | Error |
| StaticVariableName | 39 | Error |
| TypeName | 0 | Error |
| AvoidStarImport | 0 | Error |
| IllegalImport | 0 | Error |
| RedundantImport | 0 | Error |
| UnusedImports | 0 | Error |
| LineLength | 15 | Error |
| MethodLength | 2 | Error |
| ParameterNumber | 0 | Error |
| EmptyForIteratorPad | 0 | Error |
| MethodParamPad | 1 | Error |
| NoWhitespaceAfter | 2 | Error |
| NoWhitespaceBefore | 0 | Error |
| OperatorWrap | 1304 | Error |
| ParenPad | 0 | Error |
| TypecastParenPad | 0 | Error |
| WhitespaceAfter | 2 | Error |
| WhitespaceAround | 0 | Error |
| ModifierOrder | 0 | Error |
| RedundantModifier | 0 | Error |
| AvoidNestedBlocks | 0 | Error |
| EmptyBlock | 0 | Error |
| LeftCurly | 0 | Error |
| NeedBraces | 0 | Error |
| RightCurly | 0 | Error |
| AvoidInlineConditionals | 44 | Error |
| DoubleCheckedLocking | 0 | Error |
| EmptyStatement | 0 | Error |
| EqualsHashCode | 0 | Error |
| HiddenField | 399 | Error |
| IllegalInstantiation | 0 | Error |
| InnerAssignment | 0 | Error |
| MagicNumber | 279 | Error |
| MissingSwitchDefault | 0 | Error |
| RedundantThrows | 8 | Error |
| SimplifyBooleanExpression | 0 | Error |
| SimplifyBooleanReturn | 0 | Error |
| DesignForExtension | 1770 | Error |
| FinalClass | 37 | Error |
| HideUtilityClassConstructor | 0 | Error |
| InterfaceIsType | 2 | Error |
| VisibilityModifier | 62 | Error |
| ArrayTypeStyle | 0 | Error |
| FinalParameters | 2529 | Error |
| TodoComment | 8 | Error |
| UpperEll | 0 | Error |
Details
com/yammer/metrics/core/NoOpCounter.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 21 |
| Class NoOpCounter should be declared as final. | 24 |
| First sentence should end with a period. | 25 |
| First sentence should end with a period. | 28 |
| Parameter n should be final. | 35 |
| Parameter n should be final. | 41 |
| Parameter processor should be final. | 50 |
| Parameter name should be final. | 50 |
| Parameter context should be final. | 51 |
com/yammer/metrics/core/NoOpExecutorService.java
| Violation | Message | Line |
|---|---|---|
| Method 'schedule' is not designed for extension - needs to be abstract, final or empty. | 36 |
| Parameter runnable should be final. | 37 |
| Parameter l should be final. | 37 |
| Parameter timeUnit should be final. | 38 |
| Method 'schedule' is not designed for extension - needs to be abstract, final or empty. | 42 |
| Parameter vCallable should be final. | 43 |
| Parameter l should be final. | 43 |
| Parameter timeUnit should be final. | 44 |
| Method 'scheduleAtFixedRate' is not designed for extension - needs to be abstract, final or empty. | 48 |
| Parameter runnable should be final. | 50 |
| Parameter l should be final. | 50 |
| Parameter l1 should be final. | 50 |
| Parameter timeUnit should be final. | 50 |
| Method 'scheduleWithFixedDelay' is not designed for extension - needs to be abstract, final or empty. | 55 |
| Parameter runnable should be final. | 57 |
| Parameter l should be final. | 57 |
| Parameter l1 should be final. | 57 |
| Parameter timeUnit should be final. | 57 |
| Method 'shutdownNow' is not designed for extension - needs to be abstract, final or empty. | 66 |
| Method 'isShutdown' is not designed for extension - needs to be abstract, final or empty. | 71 |
| Method 'isTerminated' is not designed for extension - needs to be abstract, final or empty. | 76 |
| Method 'awaitTermination' is not designed for extension - needs to be abstract, final or empty. | 81 |
| Parameter l should be final. | 82 |
| Parameter timeUnit should be final. | 82 |
| Method 'submit' is not designed for extension - needs to be abstract, final or empty. | 87 |
| Parameter tCallable should be final. | 88 |
| Method 'submit' is not designed for extension - needs to be abstract, final or empty. | 92 |
| Parameter runnable should be final. | 93 |
| Parameter t should be final. | 93 |
| Method 'submit' is not designed for extension - needs to be abstract, final or empty. | 97 |
| Parameter runnable should be final. | 98 |
| Method 'invokeAll' is not designed for extension - needs to be abstract, final or empty. | 102 |
| Parameter callables should be final. | 104 |
| Method 'invokeAll' is not designed for extension - needs to be abstract, final or empty. | 109 |
| Parameter callables should be final. | 111 |
| Parameter l should be final. | 111 |
| Parameter timeUnit should be final. | 111 |
| Method 'invokeAny' is not designed for extension - needs to be abstract, final or empty. | 116 |
| Parameter callables should be final. | 117 |
| Method 'invokeAny' is not designed for extension - needs to be abstract, final or empty. | 122 |
| Parameter callables should be final. | 123 |
| Parameter l should be final. | 123 |
| Parameter timeUnit should be final. | 124 |
| Parameter runnable should be final. | 130 |
com/yammer/metrics/core/NoOpGuage.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 26 |
| First sentence should end with a period. | 29 |
| Method 'value' is not designed for extension - needs to be abstract, final or empty. | 32 |
com/yammer/metrics/core/NoOpHistogram.java
| Violation | Message | Line |
|---|---|---|
| Class NoOpHistogram should be declared as final. | 26 |
| First sentence should end with a period. | 27 |
| First sentence should end with a period. | 30 |
| Parameter value should be final. | 37 |
| Parameter value should be final. | 40 |
| Parameter processor should be final. | 64 |
| Parameter name should be final. | 64 |
| Parameter context should be final. | 65 |
com/yammer/metrics/core/NoOpMeter.java
| Violation | Message | Line |
|---|---|---|
| Class NoOpMeter should be declared as final. | 26 |
| First sentence should end with a period. | 27 |
| First sentence should end with a period. | 30 |
| Parameter n should be final. | 43 |
| Parameter processor should be final. | 64 |
| Parameter name should be final. | 64 |
| Parameter context should be final. | 65 |
com/yammer/metrics/core/NoOpTimer.java
| Violation | Message | Line |
|---|---|---|
| Class NoOpTimer should be declared as final. | 29 |
| First sentence should end with a period. | 30 |
| First sentence should end with a period. | 33 |
| Parameter duration should be final. | 42 |
| Parameter unit should be final. | 42 |
| Parameter event should be final. | 45 |
| Parameter processor should be final. | 87 |
| Parameter name should be final. | 87 |
| Parameter context should be final. | 88 |
org/apache/giraph/GiraphRunner.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 48 |
| First sentence should end with a period. | 50 |
| Method 'getConf' is not designed for extension - needs to be abstract, final or empty. | 53 |
| Method 'setConf' is not designed for extension - needs to be abstract, final or empty. | 58 |
| Parameter conf should be final. | 59 |
| 'conf' hides a field. | 59 |
| Method 'run' is not designed for extension - needs to be abstract, final or empty. | 63 |
| Parameter args should be final. | 69 |
| Avoid inline conditionals. | 94 |
| Expected @throws tag for 'Exception'. | 104 |
| Parameter args should be final. | 123 |
org/apache/giraph/aggregators/Aggregator.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 63 |
org/apache/giraph/aggregators/AggregatorWrapper.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 31 |
| First sentence should end with a period. | 33 |
| First sentence should end with a period. | 35 |
| First sentence should end with a period. | 37 |
| Parameter aggregatorClass should be final. | 47 |
| Parameter persistent should be final. | 48 |
| 'persistent' hides a field. | 48 |
| Expected @throws tag for 'IllegalAccessException'. | 48 |
| Expected @throws tag for 'InstantiationException'. | 49 |
| First sentence should end with a period. | 56 |
| Method 'getPreviousAggregatedValue' is not designed for extension - needs to be abstract, final or empty. | 61 |
| First sentence should end with a period. | 65 |
| Method 'setPreviousAggregatedValue' is not designed for extension - needs to be abstract, final or empty. | 70 |
| Parameter value should be final. | 70 |
| First sentence should end with a period. | 74 |
| Method 'isPersistent' is not designed for extension - needs to be abstract, final or empty. | 79 |
| First sentence should end with a period. | 83 |
| Method 'isChanged' is not designed for extension - needs to be abstract, final or empty. | 88 |
| First sentence should end with a period. | 92 |
| Method 'aggregateCurrent' is not designed for extension - needs to be abstract, final or empty. | 97 |
| Parameter value should be final. | 97 |
| First sentence should end with a period. | 102 |
| Method 'getCurrentAggregatedValue' is not designed for extension - needs to be abstract, final or empty. | 107 |
| First sentence should end with a period. | 111 |
| Method 'setCurrentAggregatedValue' is not designed for extension - needs to be abstract, final or empty. | 116 |
| Parameter value should be final. | 116 |
| First sentence should end with a period. | 121 |
| Method 'resetCurrentAggregator' is not designed for extension - needs to be abstract, final or empty. | 124 |
| First sentence should end with a period. | 129 |
| Method 'createInitialValue' is not designed for extension - needs to be abstract, final or empty. | 134 |
| First sentence should end with a period. | 138 |
| Method 'getAggregatorClass' is not designed for extension - needs to be abstract, final or empty. | 143 |
org/apache/giraph/aggregators/AggregatorWriter.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 36 |
| Expected @throws tag for 'IOException'. | 50 |
| Expected @throws tag for 'IOException'. | 63 |
| Expected @throws tag for 'IOException'. | 73 |
org/apache/giraph/aggregators/BasicAggregator.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 32 |
| Method 'getAggregatedValue' is not designed for extension - needs to be abstract, final or empty. | 43 |
| Method 'setAggregatedValue' is not designed for extension - needs to be abstract, final or empty. | 48 |
| Parameter value should be final. | 49 |
| 'value' hides a field. | 49 |
| Method 'reset' is not designed for extension - needs to be abstract, final or empty. | 53 |
org/apache/giraph/aggregators/BooleanAndAggregator.java
| Violation | Message | Line |
|---|---|---|
| Method 'aggregate' is not designed for extension - needs to be abstract, final or empty. | 28 |
| Parameter value should be final. | 29 |
| Method 'createInitialValue' is not designed for extension - needs to be abstract, final or empty. | 33 |
org/apache/giraph/aggregators/BooleanOrAggregator.java
| Violation | Message | Line |
|---|---|---|
| Method 'aggregate' is not designed for extension - needs to be abstract, final or empty. | 28 |
| Parameter value should be final. | 29 |
| Method 'createInitialValue' is not designed for extension - needs to be abstract, final or empty. | 33 |
org/apache/giraph/aggregators/BooleanOverwriteAggregator.java
| Violation | Message | Line |
|---|---|---|
| Method 'aggregate' is not designed for extension - needs to be abstract, final or empty. | 32 |
| Parameter value should be final. | 33 |
| Method 'createInitialValue' is not designed for extension - needs to be abstract, final or empty. | 37 |
org/apache/giraph/aggregators/DoubleMaxAggregator.java
| Violation | Message | Line |
|---|---|---|
| Method 'aggregate' is not designed for extension - needs to be abstract, final or empty. | 27 |
| Parameter value should be final. | 28 |
| Method 'createInitialValue' is not designed for extension - needs to be abstract, final or empty. | 33 |
org/apache/giraph/aggregators/DoubleMinAggregator.java
| Violation | Message | Line |
|---|---|---|
| Method 'aggregate' is not designed for extension - needs to be abstract, final or empty. | 27 |
| Parameter value should be final. | 28 |
| Method 'createInitialValue' is not designed for extension - needs to be abstract, final or empty. | 33 |
org/apache/giraph/aggregators/DoubleOverwriteAggregator.java
| Violation | Message | Line |
|---|---|---|
| Method 'aggregate' is not designed for extension - needs to be abstract, final or empty. | 31 |
| Parameter value should be final. | 32 |
| Method 'createInitialValue' is not designed for extension - needs to be abstract, final or empty. | 36 |
org/apache/giraph/aggregators/DoubleProductAggregator.java
| Violation | Message | Line |
|---|---|---|
| Method 'aggregate' is not designed for extension - needs to be abstract, final or empty. | 27 |
| Parameter value should be final. | 28 |
| Method 'createInitialValue' is not designed for extension - needs to be abstract, final or empty. | 32 |
org/apache/giraph/aggregators/DoubleSumAggregator.java
| Violation | Message | Line |
|---|---|---|
| Method 'aggregate' is not designed for extension - needs to be abstract, final or empty. | 25 |
| Parameter value should be final. | 26 |
| Method 'createInitialValue' is not designed for extension - needs to be abstract, final or empty. | 30 |
org/apache/giraph/aggregators/FloatMaxAggregator.java
| Violation | Message | Line |
|---|---|---|
| Method 'aggregate' is not designed for extension - needs to be abstract, final or empty. | 27 |
| Parameter value should be final. | 28 |
| Method 'createInitialValue' is not designed for extension - needs to be abstract, final or empty. | 33 |
org/apache/giraph/aggregators/FloatMinAggregator.java
| Violation | Message | Line |
|---|---|---|
| Method 'aggregate' is not designed for extension - needs to be abstract, final or empty. | 27 |
| Parameter value should be final. | 28 |
| Method 'createInitialValue' is not designed for extension - needs to be abstract, final or empty. | 33 |
org/apache/giraph/aggregators/FloatOverwriteAggregator.java
| Violation | Message | Line |
|---|---|---|
| Method 'aggregate' is not designed for extension - needs to be abstract, final or empty. | 30 |
| Parameter value should be final. | 31 |
| Method 'createInitialValue' is not designed for extension - needs to be abstract, final or empty. | 35 |
org/apache/giraph/aggregators/FloatProductAggregator.java
| Violation | Message | Line |
|---|---|---|
| Method 'aggregate' is not designed for extension - needs to be abstract, final or empty. | 27 |
| Parameter value should be final. | 28 |
| Method 'createInitialValue' is not designed for extension - needs to be abstract, final or empty. | 32 |
org/apache/giraph/aggregators/FloatSumAggregator.java
| Violation | Message | Line |
|---|---|---|
| Method 'aggregate' is not designed for extension - needs to be abstract, final or empty. | 27 |
| Parameter value should be final. | 28 |
| Method 'createInitialValue' is not designed for extension - needs to be abstract, final or empty. | 32 |
org/apache/giraph/aggregators/IntMaxAggregator.java
| Violation | Message | Line |
|---|---|---|
| Method 'aggregate' is not designed for extension - needs to be abstract, final or empty. | 27 |
| Parameter value should be final. | 28 |
| Method 'createInitialValue' is not designed for extension - needs to be abstract, final or empty. | 33 |
org/apache/giraph/aggregators/IntMinAggregator.java
| Violation | Message | Line |
|---|---|---|
| Method 'aggregate' is not designed for extension - needs to be abstract, final or empty. | 27 |
| Parameter value should be final. | 28 |
| Method 'createInitialValue' is not designed for extension - needs to be abstract, final or empty. | 33 |
org/apache/giraph/aggregators/IntOverwriteAggregator.java
| Violation | Message | Line |
|---|---|---|
| Method 'aggregate' is not designed for extension - needs to be abstract, final or empty. | 30 |
| Parameter value should be final. | 31 |
| Method 'createInitialValue' is not designed for extension - needs to be abstract, final or empty. | 35 |
org/apache/giraph/aggregators/IntProductAggregator.java
| Violation | Message | Line |
|---|---|---|
| Method 'aggregate' is not designed for extension - needs to be abstract, final or empty. | 27 |
| Parameter value should be final. | 28 |
| Method 'createInitialValue' is not designed for extension - needs to be abstract, final or empty. | 32 |
org/apache/giraph/aggregators/IntSumAggregator.java
| Violation | Message | Line |
|---|---|---|
| Method 'aggregate' is not designed for extension - needs to be abstract, final or empty. | 27 |
| Parameter value should be final. | 28 |
| Method 'createInitialValue' is not designed for extension - needs to be abstract, final or empty. | 32 |
org/apache/giraph/aggregators/LongMaxAggregator.java
| Violation | Message | Line |
|---|---|---|
| Method 'aggregate' is not designed for extension - needs to be abstract, final or empty. | 27 |
| Parameter value should be final. | 28 |
| Method 'createInitialValue' is not designed for extension - needs to be abstract, final or empty. | 33 |
org/apache/giraph/aggregators/LongMinAggregator.java
| Violation | Message | Line |
|---|---|---|
| Method 'aggregate' is not designed for extension - needs to be abstract, final or empty. | 27 |
| Parameter value should be final. | 28 |
| Method 'createInitialValue' is not designed for extension - needs to be abstract, final or empty. | 33 |
org/apache/giraph/aggregators/LongOverwriteAggregator.java
| Violation | Message | Line |
|---|---|---|
| Method 'aggregate' is not designed for extension - needs to be abstract, final or empty. | 30 |
| Parameter value should be final. | 31 |
| Method 'createInitialValue' is not designed for extension - needs to be abstract, final or empty. | 35 |
org/apache/giraph/aggregators/LongProductAggregator.java
| Violation | Message | Line |
|---|---|---|
| Method 'aggregate' is not designed for extension - needs to be abstract, final or empty. | 27 |
| Parameter value should be final. | 28 |
| Method 'createInitialValue' is not designed for extension - needs to be abstract, final or empty. | 32 |
org/apache/giraph/aggregators/LongSumAggregator.java
| Violation | Message | Line |
|---|---|---|
| Method 'aggregate' is not designed for extension - needs to be abstract, final or empty. | 27 |
| Parameter value should be final. | 28 |
| Method 'createInitialValue' is not designed for extension - needs to be abstract, final or empty. | 32 |
org/apache/giraph/aggregators/TextAggregatorWriter.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 39 |
| First sentence should end with a period. | 42 |
| First sentence should end with a period. | 44 |
| First sentence should end with a period. | 46 |
| First sentence should end with a period. | 55 |
| First sentence should end with a period. | 57 |
| Variable 'output' must be private and have accessor methods. | 58 |
| First sentence should end with a period. | 59 |
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 62 |
| Parameter context should be final. | 64 |
| Parameter attempt should be final. | 64 |
| '+' should be on a new line. | 71 |
| Method 'writeAggregator' is not designed for extension - needs to be abstract, final or empty. | 78 |
| Parameter aggregatorMap should be final. | 80 |
| Parameter superstep should be final. | 81 |
| Method 'aggregatorToString' is not designed for extension - needs to be abstract, final or empty. | 101 |
| Parameter aggregatorName should be final. | 101 |
| Parameter value should be final. | 102 |
| Parameter superstep should be final. | 103 |
| Parameter superstep should be final. | 115 |
| '||' should be on a new line. | 116 |
| Method 'close' is not designed for extension - needs to be abstract, final or empty. | 120 |
org/apache/giraph/aggregators/TextAppendAggregator.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 23 |
| Method 'aggregate' is not designed for extension - needs to be abstract, final or empty. | 27 |
| Parameter value should be final. | 28 |
| Method 'createInitialValue' is not designed for extension - needs to be abstract, final or empty. | 33 |
org/apache/giraph/benchmark/AggregatorsBenchmark.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 45 |
| First sentence should end with a period. | 48 |
| First sentence should end with a period. | 53 |
| Method 'compute' is not designed for extension - needs to be abstract, final or empty. | 59 |
| Parameter vertex should be final. | 61 |
| Parameter messages should be final. | 62 |
| First sentence should end with a period. | 83 |
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 88 |
| Method 'compute' is not designed for extension - needs to be abstract, final or empty. | 99 |
| First sentence should end with a period. | 117 |
| Method 'preSuperstep' is not designed for extension - needs to be abstract, final or empty. | 122 |
| Method 'postSuperstep' is not designed for extension - needs to be abstract, final or empty. | 128 |
| First sentence should end with a period. | 134 |
| Parameter valueToAdd should be final. | 157 |
| First sentence should end with a period. | 165 |
| Parameter conf should be final. | 171 |
| First sentence should end with a period. | 175 |
| Parameter conf should be final. | 182 |
| Parameter superstep should be final. | 183 |
| Avoid inline conditionals. | 184 |
| '3' is a magic number. | 184 |
| First sentence should end with a period. | 187 |
| Parameter expected should be final. | 193 |
| Parameter actual should be final. | 193 |
| '+' should be on a new line. | 195 |
| Method 'getBenchmarkOptions' is not designed for extension - needs to be abstract, final or empty. | 200 |
| Method 'prepareConfiguration' is not designed for extension - needs to be abstract, final or empty. | 205 |
| Parameter conf should be final. | 206 |
| Parameter cmd should be final. | 207 |
org/apache/giraph/benchmark/BenchmarkOption.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 25 |
| First sentence should end with a period. | 29 |
| First sentence should end with a period. | 32 |
| First sentence should end with a period. | 35 |
| First sentence should end with a period. | 39 |
| First sentence should end with a period. | 44 |
| First sentence should end with a period. | 48 |
| First sentence should end with a period. | 53 |
| First sentence should end with a period. | 59 |
| First sentence should end with a period. | 61 |
| First sentence should end with a period. | 63 |
| First sentence should end with a period. | 65 |
| First sentence should end with a period. | 67 |
| First sentence should end with a period. | 73 |
| Parameter shortOption should be final. | 81 |
| 'shortOption' hides a field. | 81 |
| Parameter longOption should be final. | 81 |
| 'longOption' hides a field. | 81 |
| Parameter hasArgument should be final. | 82 |
| 'hasArgument' hides a field. | 82 |
| Parameter description should be final. | 82 |
| 'description' hides a field. | 82 |
| First sentence should end with a period. | 86 |
| Parameter shortOption should be final. | 95 |
| 'shortOption' hides a field. | 95 |
| Parameter longOption should be final. | 95 |
| 'longOption' hides a field. | 95 |
| Parameter hasArgument should be final. | 96 |
| 'hasArgument' hides a field. | 96 |
| Parameter description should be final. | 96 |
| 'description' hides a field. | 96 |
| Parameter missingMessage should be final. | 96 |
| 'missingMessage' hides a field. | 96 |
| First sentence should end with a period. | 104 |
| Method 'isRequired' is not designed for extension - needs to be abstract, final or empty. | 109 |
| First sentence should end with a period. | 113 |
| Method 'addToOptions' is not designed for extension - needs to be abstract, final or empty. | 118 |
| Parameter options should be final. | 118 |
| Method 'checkOption' is not designed for extension - needs to be abstract, final or empty. | 131 |
| Parameter cmd should be final. | 131 |
| Parameter log should be final. | 131 |
| First sentence should end with a period. | 142 |
| Method 'optionTurnedOn' is not designed for extension - needs to be abstract, final or empty. | 148 |
| Parameter cmd should be final. | 148 |
| First sentence should end with a period. | 152 |
| Method 'getOptionValue' is not designed for extension - needs to be abstract, final or empty. | 159 |
| Parameter cmd should be final. | 159 |
| First sentence should end with a period. | 163 |
| Method 'getOptionIntValue' is not designed for extension - needs to be abstract, final or empty. | 169 |
| Parameter cmd should be final. | 169 |
| First sentence should end with a period. | 173 |
| Method 'getOptionIntValue' is not designed for extension - needs to be abstract, final or empty. | 182 |
| Parameter cmd should be final. | 182 |
| Parameter defaultValue should be final. | 182 |
| Avoid inline conditionals. | 183 |
| First sentence should end with a period. | 186 |
| Method 'getOptionLongValue' is not designed for extension - needs to be abstract, final or empty. | 192 |
| Parameter cmd should be final. | 192 |
| First sentence should end with a period. | 196 |
| Method 'getOptionFloatValue' is not designed for extension - needs to be abstract, final or empty. | 202 |
| Parameter cmd should be final. | 202 |
| First sentence should end with a period. | 206 |
| Method 'getOptionFloatValue' is not designed for extension - needs to be abstract, final or empty. | 215 |
| Parameter cmd should be final. | 215 |
| Parameter defaultValue should be final. | 215 |
| Avoid inline conditionals. | 216 |
org/apache/giraph/benchmark/GiraphBenchmark.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 38 |
| First sentence should end with a period. | 40 |
| Method 'setConf' is not designed for extension - needs to be abstract, final or empty. | 43 |
| Parameter conf should be final. | 44 |
| 'conf' hides a field. | 44 |
| Method 'getConf' is not designed for extension - needs to be abstract, final or empty. | 48 |
| Method 'run' is not designed for extension - needs to be abstract, final or empty. | 53 |
| Parameter args should be final. | 54 |
| '100.0f' is a magic number. | 83 |
| 'conf' hides a field. | 115 |
org/apache/giraph/benchmark/PageRankBenchmark.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 33 |
| Method 'getBenchmarkOptions' is not designed for extension - needs to be abstract, final or empty. | 37 |
| Method 'prepareConfiguration' is not designed for extension - needs to be abstract, final or empty. | 44 |
| Parameter conf should be final. | 45 |
| Parameter cmd should be final. | 46 |
org/apache/giraph/benchmark/PageRankComputation.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 35 |
| Method 'compute' is not designed for extension - needs to be abstract, final or empty. | 39 |
| Parameter vertex should be final. | 41 |
| Parameter messages should be final. | 42 |
| '0.15f' is a magic number. | 48 |
| '0.85f' is a magic number. | 48 |
org/apache/giraph/benchmark/RandomMessageBenchmark.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 47 |
| First sentence should end with a period. | 50 |
| First sentence should end with a period. | 53 |
| First sentence should end with a period. | 55 |
| First sentence should end with a period. | 58 |
| First sentence should end with a period. | 60 |
| First sentence should end with a period. | 63 |
| First sentence should end with a period. | 65 |
| First sentence should end with a period. | 68 |
| First sentence should end with a period. | 70 |
| First sentence should end with a period. | 73 |
| First sentence should end with a period. | 75 |
| First sentence should end with a period. | 78 |
| First sentence should end with a period. | 82 |
| First sentence should end with a period. | 86 |
| First sentence should end with a period. | 90 |
| First sentence should end with a period. | 99 |
| First sentence should end with a period. | 102 |
| First sentence should end with a period. | 104 |
| First sentence should end with a period. | 106 |
| First sentence should end with a period. | 108 |
| First sentence should end with a period. | 110 |
| First sentence should end with a period. | 112 |
| First sentence should end with a period. | 114 |
| First sentence should end with a period. | 116 |
| Method 'preApplication' is not designed for extension - needs to be abstract, final or empty. | 119 |
| Method 'preSuperstep' is not designed for extension - needs to be abstract, final or empty. | 134 |
| '1000d' is a magic number. | 155 |
| '1024d' is a magic number. | 155 |
| '1024d' is a magic number. | 155 |
| '*' should be on a new line. | 156 |
| '1000d' is a magic number. | 157 |
| '1024d' is a magic number. | 157 |
| '1024d' is a magic number. | 157 |
| '1000d' is a magic number. | 159 |
| '1000d' is a magic number. | 161 |
| '+' should be on a new line. | 171 |
| '+' should be on a new line. | 173 |
| '+' should be on a new line. | 175 |
| '+' should be on a new line. | 177 |
| '+' should be on a new line. | 179 |
| '+' should be on a new line. | 181 |
| '+' should be on a new line. | 183 |
| '+' should be on a new line. | 185 |
| Method 'postSuperstep' is not designed for extension - needs to be abstract, final or empty. | 193 |
| Method 'getMessageBytes' is not designed for extension - needs to be abstract, final or empty. | 209 |
| Method 'getNumMessagePerEdge' is not designed for extension - needs to be abstract, final or empty. | 218 |
| Method 'getNumSupersteps' is not designed for extension - needs to be abstract, final or empty. | 227 |
| Method 'randomizeMessageBytes' is not designed for extension - needs to be abstract, final or empty. | 234 |
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 245 |
| First sentence should end with a period. | 259 |
| Method 'compute' is not designed for extension - needs to be abstract, final or empty. | 264 |
| Parameter vertex should be final. | 266 |
| Parameter messages should be final. | 267 |
| '*' should be on a new line. | 274 |
| Method 'getBenchmarkOptions' is not designed for extension - needs to be abstract, final or empty. | 286 |
| Method 'prepareConfiguration' is not designed for extension - needs to be abstract, final or empty. | 293 |
| Parameter conf should be final. | 294 |
| Parameter cmd should be final. | 295 |
| Parameter args should be final. | 322 |
org/apache/giraph/benchmark/ShortestPathsBenchmark.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 40 |
| First sentence should end with a period. | 44 |
| First sentence should end with a period. | 48 |
| Method 'getBenchmarkOptions' is not designed for extension - needs to be abstract, final or empty. | 52 |
| Method 'prepareConfiguration' is not designed for extension - needs to be abstract, final or empty. | 58 |
| Parameter conf should be final. | 59 |
| Parameter cmd should be final. | 60 |
org/apache/giraph/benchmark/ShortestPathsComputation.java
| Violation | Message | Line |
|---|---|---|
| Parameter vertex should be final. | 47 |
| '==' should be on a new line. | 48 |
| Method 'compute' is not designed for extension - needs to be abstract, final or empty. | 52 |
| Parameter vertex should be final. | 54 |
| Parameter messages should be final. | 55 |
| Avoid inline conditionals. | 60 |
org/apache/giraph/benchmark/WeightedPageRankBenchmark.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 40 |
| First sentence should end with a period. | 44 |
| First sentence should end with a period. | 48 |
| '+' should be on a new line. | 51 |
| '+' should be on a new line. | 52 |
| '+' should be on a new line. | 53 |
| '+' should be on a new line. | 54 |
| First sentence should end with a period. | 56 |
| First sentence should end with a period. | 60 |
| '+' should be on a new line. | 63 |
| First sentence should end with a period. | 65 |
| First sentence should end with a period. | 69 |
| Method 'getBenchmarkOptions' is not designed for extension - needs to be abstract, final or empty. | 74 |
| Method 'prepareConfiguration' is not designed for extension - needs to be abstract, final or empty. | 89 |
| Parameter configuration should be final. | 89 |
| Parameter cmd should be final. | 90 |
| '3' is a magic number. | 104 |
| '4' is a magic number. | 107 |
| '+' should be on a new line. | 111 |
| '+' should be on a new line. | 116 |
| '+' should be on a new line. | 141 |
org/apache/giraph/benchmark/WeightedPageRankComputation.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 35 |
| Method 'compute' is not designed for extension - needs to be abstract, final or empty. | 39 |
| Parameter vertex should be final. | 41 |
| Parameter messages should be final. | 42 |
| ':' should be on a new line. | 49 |
| '0.15f' is a magic number. | 59 |
| '0.85f' is a magic number. | 59 |
org/apache/giraph/benchmark/package-info.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 18 |
org/apache/giraph/bsp/ApplicationState.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 21 |
| First sentence should end with a period. | 25 |
| First sentence should end with a period. | 27 |
| First sentence should end with a period. | 29 |
| First sentence should end with a period. | 31 |
org/apache/giraph/bsp/BspInputFormat.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 42 |
| First sentence should end with a period. | 45 |
| Parameter conf should be final. | 51 |
| '+' should be on a new line. | 62 |
| '+' should be on a new line. | 63 |
| '+' should be on a new line. | 64 |
| Method 'getSplits' is not designed for extension - needs to be abstract, final or empty. | 70 |
| Parameter context should be final. | 71 |
| Method 'createRecordReader' is not designed for extension - needs to be abstract, final or empty. | 86 |
| Parameter split should be final. | 88 |
| Parameter context should be final. | 88 |
org/apache/giraph/bsp/BspInputSplit.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 35 |
| First sentence should end with a period. | 37 |
| Parameter splitIndex should be final. | 51 |
| 'splitIndex' hides a field. | 51 |
| Parameter numSplits should be final. | 51 |
| 'numSplits' hides a field. | 51 |
| Method 'getLength' is not designed for extension - needs to be abstract, final or empty. | 56 |
| Method 'getLocations' is not designed for extension - needs to be abstract, final or empty. | 61 |
| Method 'readFields' is not designed for extension - needs to be abstract, final or empty. | 66 |
| Parameter in should be final. | 67 |
| Method 'write' is not designed for extension - needs to be abstract, final or empty. | 72 |
| Parameter out should be final. | 73 |
| Method 'getSplitIndex' is not designed for extension - needs to be abstract, final or empty. | 83 |
| Method 'getNumSplits' is not designed for extension - needs to be abstract, final or empty. | 92 |
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 96 |
| '+' should be on a new line. | 98 |
org/apache/giraph/bsp/BspOutputFormat.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 37 |
| Name 'LOG' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 38 |
| Method 'checkOutputSpecs' is not designed for extension - needs to be abstract, final or empty. | 40 |
| Parameter context should be final. | 41 |
| '+' should be on a new line. | 46 |
| Method 'getOutputCommitter' is not designed for extension - needs to be abstract, final or empty. | 53 |
| Parameter context should be final. | 54 |
| '+' should be on a new line. | 59 |
| Method 'getRecordWriter' is not designed for extension - needs to be abstract, final or empty. | 66 |
| Parameter context should be final. | 67 |
org/apache/giraph/bsp/BspRecordReader.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 32 |
| First sentence should end with a period. | 34 |
| Avoid inline conditionals. | 47 |
| Parameter inputSplit should be final. | 61 |
| Parameter context should be final. | 61 |
org/apache/giraph/bsp/BspRecordWriter.java
| Violation | Message | Line |
|---|---|---|
| Parameter context should be final. | 35 |
| Method 'write' is not designed for extension - needs to be abstract, final or empty. | 40 |
| Parameter key should be final. | 41 |
| Parameter value should be final. | 41 |
| '+' should be on a new line. | 43 |
| '+' should be on a new line. | 44 |
org/apache/giraph/bsp/BspService.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 68 |
| First sentence should end with a period. | 70 |
| First sentence should end with a period. | 72 |
| First sentence should end with a period. | 74 |
| First sentence should end with a period. | 76 |
| First sentence should end with a period. | 78 |
| First sentence should end with a period. | 80 |
| First sentence should end with a period. | 83 |
| First sentence should end with a period. | 86 |
| First sentence should end with a period. | 89 |
| First sentence should end with a period. | 95 |
| First sentence should end with a period. | 97 |
| First sentence should end with a period. | 100 |
| First sentence should end with a period. | 103 |
| First sentence should end with a period. | 106 |
| First sentence should end with a period. | 112 |
| First sentence should end with a period. | 115 |
| First sentence should end with a period. | 117 |
| First sentence should end with a period. | 119 |
| First sentence should end with a period. | 126 |
| First sentence should end with a period. | 129 |
| First sentence should end with a period. | 131 |
| First sentence should end with a period. | 134 |
| First sentence should end with a period. | 137 |
| First sentence should end with a period. | 139 |
| First sentence should end with a period. | 141 |
| First sentence should end with a period. | 144 |
| First sentence should end with a period. | 146 |
| First sentence should end with a period. | 149 |
| First sentence should end with a period. | 151 |
| First sentence should end with a period. | 154 |
| First sentence should end with a period. | 157 |
| First sentence should end with a period. | 159 |
| First sentence should end with a period. | 161 |
| First sentence should end with a period. | 168 |
| First sentence should end with a period. | 178 |
| First sentence should end with a period. | 180 |
| Variable 'basePath' must be private and have accessor methods. | 181 |
| First sentence should end with a period. | 182 |
| Variable 'masterJobStatePath' must be private and have accessor methods. | 183 |
| Variable 'vertexInputSplitsPaths' must be private and have accessor methods. | 185 |
| Variable 'edgeInputSplitsPaths' must be private and have accessor methods. | 187 |
| Variable 'vertexInputSplitsEvents' must be private and have accessor methods. | 189 |
| Variable 'edgeInputSplitsEvents' must be private and have accessor methods. | 191 |
| First sentence should end with a period. | 192 |
| Variable 'applicationAttemptsPath' must be private and have accessor methods. | 193 |
| First sentence should end with a period. | 194 |
| Variable 'cleanedUpPath' must be private and have accessor methods. | 195 |
| First sentence should end with a period. | 196 |
| Variable 'checkpointBasePath' must be private and have accessor methods. | 197 |
| First sentence should end with a period. | 198 |
| Variable 'masterElectionPath' must be private and have accessor methods. | 199 |
| First sentence should end with a period. | 200 |
| First sentence should end with a period. | 204 |
| First sentence should end with a period. | 208 |
| First sentence should end with a period. | 210 |
| First sentence should end with a period. | 212 |
| First sentence should end with a period. | 214 |
| First sentence should end with a period. | 216 |
| First sentence should end with a period. | 219 |
| First sentence should end with a period. | 221 |
| First sentence should end with a period. | 223 |
| First sentence should end with a period. | 225 |
| First sentence should end with a period. | 227 |
| First sentence should end with a period. | 229 |
| First sentence should end with a period. | 231 |
| First sentence should end with a period. | 233 |
| First sentence should end with a period. | 235 |
| First sentence should end with a period. | 237 |
| First sentence should end with a period. | 239 |
| First sentence should end with a period. | 241 |
| First sentence should end with a period. | 243 |
| Parameter serverPortList should be final. | 254 |
| Parameter sessionMsecTimeout should be final. | 255 |
| Parameter context should be final. | 256 |
| 'context' hides a field. | 256 |
| Parameter graphTaskManager should be final. | 257 |
| 'graphTaskManager' hides a field. | 257 |
| '&&' should be on a new line. | 288 |
| '+' should be on a new line. | 291 |
| '+' should be on a new line. | 319 |
| First sentence should end with a period. | 337 |
| Parameter path should be final. | 343 |
| '+' should be on a new line. | 347 |
| '+' should be on a new line. | 351 |
| '+' should be on a new line. | 355 |
| '+' should be on a new line. | 359 |
| First sentence should end with a period. | 365 |
| Parameter path should be final. | 371 |
| '+' should be on a new line. | 375 |
| First sentence should end with a period. | 382 |
| Parameter attempt should be final. | 389 |
| Method 'getEdgeInputSplitsEvents' is not designed for extension - needs to be abstract, final or empty. | 398 |
| Method 'getVertexInputSplitsEvents' is not designed for extension - needs to be abstract, final or empty. | 407 |
| First sentence should end with a period. | 411 |
| Parameter attempt should be final. | 419 |
| Parameter superstep should be final. | 420 |
| '+' should be on a new line. | 421 |
| First sentence should end with a period. | 425 |
| Parameter attempt should be final. | 433 |
| Parameter superstep should be final. | 434 |
| '+' should be on a new line. | 435 |
| First sentence should end with a period. | 439 |
| Parameter attempt should be final. | 447 |
| Parameter superstep should be final. | 448 |
| '+' should be on a new line. | 449 |
| First sentence should end with a period. | 453 |
| Parameter attempt should be final. | 461 |
| Parameter superstep should be final. | 461 |
| '+' should be on a new line. | 462 |
| First sentence should end with a period. | 466 |
| Parameter attempt should be final. | 473 |
| Parameter superstep should be final. | 474 |
| '+' should be on a new line. | 475 |
| First sentence should end with a period. | 479 |
| Parameter attempt should be final. | 486 |
| Parameter superstep should be final. | 487 |
| '+' should be on a new line. | 488 |
| Parameter attempt should be final. | 501 |
| Parameter superstep should be final. | 502 |
| Parameter workerInfo should be final. | 503 |
| '+' should be on a new line. | 504 |
| First sentence should end with a period. | 508 |
| Parameter attempt should be final. | 515 |
| Parameter superstep should be final. | 515 |
| '+' should be on a new line. | 516 |
| First sentence should end with a period. | 520 |
| Parameter superstep should be final. | 527 |
| First sentence should end with a period. | 531 |
| Parameter finalizedPath should be final. | 537 |
| '+' should be on a new line. | 540 |
| First sentence should end with a period. | 562 |
| Parameter superstep should be final. | 567 |
| Parameter superstep should be final. | 583 |
| First sentence should end with a period. | 597 |
| Missing a Javadoc comment. | 606 |
| Missing a Javadoc comment. | 611 |
| Missing a Javadoc comment. | 615 |
| Missing a Javadoc comment. | 619 |
| Missing a Javadoc comment. | 623 |
| Missing a Javadoc comment. | 627 |
| Missing a Javadoc comment. | 631 |
| Missing a Javadoc comment. | 635 |
| Missing a Javadoc comment. | 640 |
| Missing a Javadoc comment. | 644 |
| Missing a Javadoc comment. | 649 |
| Missing a Javadoc comment. | 653 |
| '+' should be on a new line. | 673 |
| '+' should be on a new line. | 676 |
| '+' should be on a new line. | 679 |
| '+' should be on a new line. | 694 |
| '+' should be on a new line. | 697 |
| '+' should be on a new line. | 700 |
| First sentence should end with a period. | 711 |
| '+' should be on a new line. | 736 |
| '+' should be on a new line. | 739 |
| '+' should be on a new line. | 742 |
| '+' should be on a new line. | 756 |
| '+' should be on a new line. | 759 |
| '+' should be on a new line. | 786 |
| '+' should be on a new line. | 824 |
| Parameter superstep should be final. | 836 |
| First sentence should end with a period. | 840 |
| Parameter applicationAttempt should be final. | 846 |
| '+' should be on a new line. | 857 |
| '+' should be on a new line. | 861 |
| '+' should be on a new line. | 865 |
| Method 'registerBspEvent' is not designed for extension - needs to be abstract, final or empty. | 877 |
| Parameter event should be final. | 877 |
| First sentence should end with a period. | 881 |
| Method 'getGraphPartitionerFactory' is not designed for extension - needs to be abstract, final or empty. | 886 |
| Method 'processEvent' is not designed for extension - needs to be abstract, final or empty. | 897 |
| Parameter event should be final. | 897 |
| Method length is 187 lines (max allowed is 150). | 901 |
| Parameter event should be final. | 902 |
| '+' should be on a new line. | 906 |
| '+' should be on a new line. | 907 |
| '+' should be on a new line. | 917 |
| '||' should be on a new line. | 936 |
| '&&' should be on a new line. | 937 |
| '+' should be on a new line. | 940 |
| '&&' should be on a new line. | 946 |
| '+' should be on a new line. | 949 |
| '&&' should be on a new line. | 954 |
| '+' should be on a new line. | 957 |
| '&&' should be on a new line. | 962 |
| '+' should be on a new line. | 965 |
| '&&' should be on a new line. | 970 |
| '+' should be on a new line. | 973 |
| '&&' should be on a new line. | 978 |
| '+' should be on a new line. | 981 |
| '&&' should be on a new line. | 987 |
| '+' should be on a new line. | 990 |
| '&&' should be on a new line. | 996 |
| '+' should be on a new line. | 999 |
| '&&' should be on a new line. | 1004 |
| '+' should be on a new line. | 1007 |
| '&&' should be on a new line. | 1012 |
| '+' should be on a new line. | 1015 |
| '&&' should be on a new line. | 1020 |
| '+' should be on a new line. | 1023 |
| '&&' should be on a new line. | 1028 |
| '+' should be on a new line. | 1031 |
| '&&' should be on a new line. | 1037 |
| '+' should be on a new line. | 1040 |
| '&&' should be on a new line. | 1045 |
| '+' should be on a new line. | 1048 |
| '&&' should be on a new line. | 1053 |
| '&&' should be on a new line. | 1060 |
| '&&' should be on a new line. | 1067 |
| '&&' should be on a new line. | 1074 |
| '+' should be on a new line. | 1084 |
| '+' should be on a new line. | 1085 |
org/apache/giraph/bsp/CentralizedService.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 46 |
| First sentence should end with a period. | 62 |
org/apache/giraph/bsp/CentralizedServiceMaster.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 41 |
| First sentence should end with a period. | 52 |
| First sentence should end with a period. | 79 |
| Expected @throws tag for 'KeeperException'. | 87 |
| Expected @throws tag for 'InterruptedException'. | 87 |
| First sentence should end with a period. | 97 |
| Expected @throws tag for 'IOException'. | 103 |
| First sentence should end with a period. | 118 |
| First sentence should end with a period. | 143 |
| Expected @throws tag for 'IOException'. | 150 |
| Expected @throws tag for 'InterruptedException'. | 150 |
org/apache/giraph/bsp/CentralizedServiceWorker.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 54 |
| First sentence should end with a period. | 61 |
| Expected @throws tag for 'IOException'. | 105 |
| Expected @throws tag for 'IOException'. | 116 |
| First sentence should end with a period. | 179 |
| First sentence should end with a period. | 199 |
| First sentence should end with a period. | 206 |
| First sentence should end with a period. | 213 |
| First sentence should end with a period. | 220 |
| First sentence should end with a period. | 227 |
| Expected @throws tag for 'IOException'. | 235 |
| Expected @throws tag for 'InterruptedException'. | 235 |
org/apache/giraph/bsp/ImmutableOutputCommitter.java
| Violation | Message | Line |
|---|---|---|
| Parameter context should be final. | 34 |
| Parameter context should be final. | 38 |
| Parameter context should be final. | 42 |
| Parameter context should be final. | 48 |
| Parameter context should be final. | 52 |
| Parameter jobContext should be final. | 61 |
org/apache/giraph/bsp/SuperstepState.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 21 |
| First sentence should end with a period. | 25 |
| First sentence should end with a period. | 27 |
| First sentence should end with a period. | 29 |
| First sentence should end with a period. | 31 |
org/apache/giraph/combiner/DoubleSumCombiner.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 24 |
| Method 'combine' is not designed for extension - needs to be abstract, final or empty. | 29 |
| Parameter vertexIndex should be final. | 30 |
| Parameter originalMessage should be final. | 30 |
| Parameter messageToCombine should be final. | 31 |
| Method 'createInitialMessage' is not designed for extension - needs to be abstract, final or empty. | 35 |
org/apache/giraph/combiner/FloatSumCombiner.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 24 |
| Method 'combine' is not designed for extension - needs to be abstract, final or empty. | 29 |
| Parameter vertexIndex should be final. | 30 |
| Parameter originalMessage should be final. | 30 |
| Parameter messageToCombine should be final. | 31 |
| Method 'createInitialMessage' is not designed for extension - needs to be abstract, final or empty. | 35 |
org/apache/giraph/combiner/MinimumDoubleCombiner.java
| Violation | Message | Line |
|---|---|---|
| Method 'combine' is not designed for extension - needs to be abstract, final or empty. | 29 |
| Parameter vertexIndex should be final. | 30 |
| Parameter originalMessage should be final. | 30 |
| Parameter messageToCombine should be final. | 31 |
| Method 'createInitialMessage' is not designed for extension - needs to be abstract, final or empty. | 37 |
org/apache/giraph/combiner/MinimumIntCombiner.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 23 |
| Method 'combine' is not designed for extension - needs to be abstract, final or empty. | 28 |
| Parameter vertexIndex should be final. | 29 |
| Parameter originalMessage should be final. | 29 |
| Parameter messageToCombine should be final. | 30 |
| Method 'createInitialMessage' is not designed for extension - needs to be abstract, final or empty. | 36 |
org/apache/giraph/combiner/SimpleSumCombiner.java
| Violation | Message | Line |
|---|---|---|
| Method 'combine' is not designed for extension - needs to be abstract, final or empty. | 30 |
| Parameter vertexIndex should be final. | 31 |
| Parameter originalMessage should be final. | 31 |
| Parameter messageToCombine should be final. | 32 |
| Method 'createInitialMessage' is not designed for extension - needs to be abstract, final or empty. | 36 |
org/apache/giraph/comm/MasterClient.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 26 |
| First sentence should end with a period. | 35 |
| Expected @throws tag for 'IOException'. | 45 |
| Expected @throws tag for 'IOException'. | 50 |
org/apache/giraph/comm/MasterServer.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 23 |
| First sentence should end with a period. | 27 |
org/apache/giraph/comm/SendCache.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 45 |
| First sentence should end with a period. | 47 |
| First sentence should end with a period. | 49 |
| First sentence should end with a period. | 51 |
| First sentence should end with a period. | 54 |
| Parameter conf should be final. | 66 |
| 'conf' hides a field. | 66 |
| Parameter serviceWorker should be final. | 67 |
| Parameter maxRequestSize should be final. | 68 |
| Parameter additionalRequestSize should be final. | 69 |
| Method 'addData' is not designed for extension - needs to be abstract, final or empty. | 117 |
| Parameter workerInfo should be final. | 117 |
| Parameter partitionId should be final. | 118 |
| Parameter destVertexId should be final. | 118 |
| Parameter data should be final. | 118 |
| Method 'removeWorkerData' is not designed for extension - needs to be abstract, final or empty. | 146 |
| Parameter workerInfo should be final. | 147 |
| Method 'removeAllData' is not designed for extension - needs to be abstract, final or empty. | 166 |
| Method 'getConf' is not designed for extension - needs to be abstract, final or empty. | 180 |
| Missing a Javadoc comment. | 180 |
org/apache/giraph/comm/SendEdgeCache.java
| Violation | Message | Line |
|---|---|---|
| Line is longer than 80 characters. | 30 |
| First sentence should end with a period. | 42 |
| Parameter conf should be final. | 48 |
| Parameter serviceWorker should be final. | 49 |
| Method 'createByteArrayVertexIdData' is not designed for extension - needs to be abstract, final or empty. | 54 |
| Method 'addEdge' is not designed for extension - needs to be abstract, final or empty. | 68 |
| Parameter workerInfo should be final. | 68 |
| Parameter partitionId should be final. | 69 |
| Parameter destVertexId should be final. | 69 |
| Parameter edge should be final. | 69 |
| Method 'removeWorkerEdges' is not designed for extension - needs to be abstract, final or empty. | 81 |
| Parameter workerInfo should be final. | 82 |
| Method 'removeAllEdges' is not designed for extension - needs to be abstract, final or empty. | 91 |
org/apache/giraph/comm/SendMessageCache.java
| Violation | Message | Line |
|---|---|---|
| Line is longer than 80 characters. | 29 |
| First sentence should end with a period. | 41 |
| Parameter conf should be final. | 47 |
| Parameter serviceWorker should be final. | 48 |
| Method 'createByteArrayVertexIdData' is not designed for extension - needs to be abstract, final or empty. | 53 |
| Method 'addMessage' is not designed for extension - needs to be abstract, final or empty. | 68 |
| Parameter workerInfo should be final. | 68 |
| Parameter partitionId should be final. | 69 |
| Parameter destVertexId should be final. | 69 |
| Parameter message should be final. | 69 |
| Method 'removeWorkerMessages' is not designed for extension - needs to be abstract, final or empty. | 81 |
| Parameter workerInfo should be final. | 82 |
| Method 'removeAllMessages' is not designed for extension - needs to be abstract, final or empty. | 91 |
org/apache/giraph/comm/SendMutationsCache.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 40 |
| First sentence should end with a period. | 43 |
| Parameter partitionId should be final. | 56 |
| Parameter destVertexId should be final. | 56 |
| Parameter partitionId should be final. | 77 |
| Method 'addEdgeMutation' is not designed for extension - needs to be abstract, final or empty. | 96 |
| Parameter partitionId should be final. | 97 |
| Parameter destVertexId should be final. | 97 |
| Parameter edge should be final. | 97 |
| Method 'removeEdgeMutation' is not designed for extension - needs to be abstract, final or empty. | 117 |
| Parameter partitionId should be final. | 118 |
| Parameter vertexIndex should be final. | 118 |
| Parameter destinationVertexIndex should be final. | 118 |
| Method 'addVertexMutation' is not designed for extension - needs to be abstract, final or empty. | 137 |
| Parameter partitionId should be final. | 138 |
| Parameter vertex should be final. | 138 |
| Method 'removeVertexMutation' is not designed for extension - needs to be abstract, final or empty. | 157 |
| Parameter partitionId should be final. | 158 |
| Parameter destVertexId should be final. | 158 |
| Method 'removePartitionMutations' is not designed for extension - needs to be abstract, final or empty. | 176 |
| Parameter partitionId should be final. | 177 |
| Method 'removeAllPartitionMutations' is not designed for extension - needs to be abstract, final or empty. | 189 |
org/apache/giraph/comm/SendPartitionCache.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 42 |
| First sentence should end with a period. | 45 |
| First sentence should end with a period. | 48 |
| First sentence should end with a period. | 50 |
| First sentence should end with a period. | 52 |
| Parameter context should be final. | 67 |
| 'context' hides a field. | 67 |
| Parameter configuration should be final. | 68 |
| 'configuration' hides a field. | 68 |
| '+' should be on a new line. | 74 |
| '+' should be on a new line. | 76 |
| First sentence should end with a period. | 81 |
| Method 'addVertex' is not designed for extension - needs to be abstract, final or empty. | 88 |
| Parameter partitionOwner should be final. | 88 |
| Parameter vertex should be final. | 89 |
| '+' should be on a new line. | 103 |
| First sentence should end with a period. | 115 |
| Method 'getOwnerPartitionMap' is not designed for extension - needs to be abstract, final or empty. | 120 |
| Method 'clear' is not designed for extension - needs to be abstract, final or empty. | 127 |
org/apache/giraph/comm/ServerData.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 40 |
| First sentence should end with a period. | 50 |
| First sentence should end with a period. | 56 |
| First sentence should end with a period. | 60 |
| First sentence should end with a period. | 66 |
| First sentence should end with a period. | 78 |
| First sentence should end with a period. | 82 |
| Parameter service should be final. | 96 |
| Parameter conf should be final. | 97 |
| 'conf' hides a field. | 97 |
| Parameter messageStoreFactory should be final. | 98 |
| 'messageStoreFactory' hides a field. | 99 |
| Parameter context should be final. | 100 |
| Method 'getEdgeStore' is not designed for extension - needs to be abstract, final or empty. | 119 |
| Missing a Javadoc comment. | 119 |
| Method 'getPartitionStore' is not designed for extension - needs to be abstract, final or empty. | 128 |
| First sentence should end with a period. | 132 |
| Method 'getIncomingMessageStore' is not designed for extension - needs to be abstract, final or empty. | 139 |
| First sentence should end with a period. | 144 |
| Method 'getCurrentMessageStore' is not designed for extension - needs to be abstract, final or empty. | 151 |
| First sentence should end with a period. | 156 |
| Method 'prepareSuperstep' is not designed for extension - needs to be abstract, final or empty. | 157 |
| First sentence should end with a period. | 171 |
| Method 'getVertexMutations' is not designed for extension - needs to be abstract, final or empty. | 176 |
| First sentence should end with a period. | 181 |
| Method 'getOwnerAggregatorData' is not designed for extension - needs to be abstract, final or empty. | 186 |
| First sentence should end with a period. | 190 |
| Method 'getAllAggregatorData' is not designed for extension - needs to be abstract, final or empty. | 195 |
org/apache/giraph/comm/WorkerClient.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 70 |
| Expected @throws tag for 'IOException'. | 88 |
| Expected @throws tag for 'IOException'. | 97 |
org/apache/giraph/comm/WorkerClientRequestProcessor.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 30 |
| First sentence should end with a period. | 48 |
| First sentence should end with a period. | 66 |
| Expected @throws tag for 'IOException'. | 73 |
| Expected @throws tag for 'IOException'. | 86 |
| Expected @throws tag for 'IOException'. | 97 |
| First sentence should end with a period. | 99 |
| Expected @throws tag for 'IOException'. | 105 |
| First sentence should end with a period. | 107 |
| Expected @throws tag for 'IOException'. | 113 |
| Expected @throws tag for 'IOException'. | 121 |
org/apache/giraph/comm/WorkerServer.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 38 |
| First sentence should end with a period. | 50 |
org/apache/giraph/comm/aggregators/AggregatedValueOutputStream.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 25 |
| First sentence should end with a period. | 30 |
| Method 'addAggregator' is not designed for extension - needs to be abstract, final or empty. | 38 |
| Parameter aggregatorName should be final. | 38 |
| Parameter aggregatedValue should be final. | 39 |
| Expected @throws tag for 'IOException'. | 39 |
org/apache/giraph/comm/aggregators/AggregatorOutputStream.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 26 |
| First sentence should end with a period. | 31 |
| Method 'addAggregator' is not designed for extension - needs to be abstract, final or empty. | 40 |
| Parameter aggregatorName should be final. | 40 |
| Parameter aggregatorClass should be final. | 41 |
| Parameter aggregatedValue should be final. | 42 |
| Expected @throws tag for 'IOException'. | 42 |
org/apache/giraph/comm/aggregators/AggregatorUtils.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 29 |
| Class AggregatorUtils should be declared as final. | 32 |
| First sentence should end with a period. | 33 |
| First sentence should end with a period. | 39 |
| First sentence should end with a period. | 42 |
| First sentence should end with a period. | 54 |
| First sentence should end with a period. | 57 |
| Parameter aggregatorClassName should be final. | 66 |
| '+' should be on a new line. | 71 |
| Parameter aggregatorClass should be final. | 86 |
| Parameter conf should be final. | 87 |
| First sentence should end with a period. | 91 |
| Parameter aggregatorName should be final. | 98 |
| Parameter workers should be final. | 99 |
| Parameter conf should be final. | 111 |
| Parameter aggregatorName should be final. | 128 |
| Parameter hasRegisteredAggregators should be final. | 128 |
| Parameter conf should be final. | 129 |
| '+' should be on a new line. | 130 |
| '+' should be on a new line. | 133 |
| '+' should be on a new line. | 134 |
| '+' should be on a new line. | 135 |
| '+' should be on a new line. | 136 |
org/apache/giraph/comm/aggregators/AllAggregatorServerData.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 49 |
| First sentence should end with a period. | 52 |
| First sentence should end with a period. | 59 |
| First sentence should end with a period. | 62 |
| First sentence should end with a period. | 85 |
| First sentence should end with a period. | 87 |
| First sentence should end with a period. | 90 |
| Parameter progressable should be final. | 96 |
| 'progressable' hides a field. | 96 |
| Parameter conf should be final. | 97 |
| 'conf' hides a field. | 97 |
| Method 'registerAggregatorClass' is not designed for extension - needs to be abstract, final or empty. | 110 |
| Parameter name should be final. | 110 |
| Parameter aggregatorClass should be final. | 111 |
| Method 'setAggregatorValue' is not designed for extension - needs to be abstract, final or empty. | 127 |
| Parameter name should be final. | 127 |
| Parameter value should be final. | 127 |
| Method 'createAggregatorInitialValue' is not designed for extension - needs to be abstract, final or empty. | 141 |
| Parameter name should be final. | 141 |
| Method 'receivedRequestFromMaster' is not designed for extension - needs to be abstract, final or empty. | 155 |
| Parameter aggregatorData should be final. | 155 |
| Method 'receivedRequestCountFromMaster' is not designed for extension - needs to be abstract, final or empty. | 167 |
| Parameter requestCount should be final. | 167 |
| Parameter taskId should be final. | 167 |
| Method 'receivedRequestFromWorker' is not designed for extension - needs to be abstract, final or empty. | 175 |
| Method 'receivedRequestCountFromWorker' is not designed for extension - needs to be abstract, final or empty. | 186 |
| Parameter requestCount should be final. | 186 |
| Parameter taskId should be final. | 186 |
| Method 'getDataFromMasterWhenReady' is not designed for extension - needs to be abstract, final or empty. | 197 |
| Parameter masterInfo should be final. | 197 |
| '+' should be on a new line. | 201 |
| Method 'fillNextSuperstepMapsWhenReady' is not designed for extension - needs to be abstract, final or empty. | 218 |
| Parameter workerIds should be final. | 219 |
| Parameter previousAggregatedValuesMap should be final. | 220 |
| Parameter currentAggregatorMap should be final. | 221 |
| ':' should be on a new line. | 228 |
| First sentence should end with a period. | 241 |
| Method 'reset' is not designed for extension - needs to be abstract, final or empty. | 244 |
org/apache/giraph/comm/aggregators/CountingCache.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 25 |
| First sentence should end with a period. | 30 |
| Method 'incrementCounter' is not designed for extension - needs to be abstract, final or empty. | 39 |
| Parameter taskId should be final. | 39 |
| Avoid inline conditionals. | 42 |
| First sentence should end with a period. | 45 |
| Method 'getCount' is not designed for extension - needs to be abstract, final or empty. | 51 |
| Parameter taskId should be final. | 51 |
| First sentence should end with a period. | 60 |
| Method 'reset' is not designed for extension - needs to be abstract, final or empty. | 63 |
org/apache/giraph/comm/aggregators/CountingOutputStream.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 25 |
| First sentence should end with a period. | 30 |
| Variable 'dataOutput' must be private and have accessor methods. | 31 |
| First sentence should end with a period. | 32 |
| First sentence should end with a period. | 35 |
| First sentence should end with a period. | 43 |
| Method 'incrementCounter' is not designed for extension - needs to be abstract, final or empty. | 46 |
| First sentence should end with a period. | 50 |
| Method 'getSize' is not designed for extension - needs to be abstract, final or empty. | 55 |
| Method 'flush' is not designed for extension - needs to be abstract, final or empty. | 64 |
| First sentence should end with a period. | 72 |
org/apache/giraph/comm/aggregators/OwnerAggregatorServerData.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 61 |
| First sentence should end with a period. | 64 |
| First sentence should end with a period. | 74 |
| First sentence should end with a period. | 76 |
| First sentence should end with a period. | 79 |
| Parameter progressable should be final. | 85 |
| 'progressable' hides a field. | 85 |
| Parameter conf should be final. | 86 |
| 'conf' hides a field. | 86 |
| Method 'registerAggregator' is not designed for extension - needs to be abstract, final or empty. | 98 |
| Parameter name should be final. | 98 |
| Parameter aggregatorClass should be final. | 99 |
| Method 'aggregate' is not designed for extension - needs to be abstract, final or empty. | 116 |
| Parameter name should be final. | 116 |
| Parameter value should be final. | 116 |
| Method 'createAggregatorInitialValue' is not designed for extension - needs to be abstract, final or empty. | 133 |
| Parameter name should be final. | 133 |
| Method 'receivedRequestFromWorker' is not designed for extension - needs to be abstract, final or empty. | 144 |
| Method 'receivedRequestCountFromWorker' is not designed for extension - needs to be abstract, final or empty. | 155 |
| Parameter requestCount should be final. | 155 |
| Parameter taskId should be final. | 155 |
| Method 'getMyAggregatorValuesWhenReady' is not designed for extension - needs to be abstract, final or empty. | 167 |
| Parameter workerIds should be final. | 168 |
| Parameter aggregator should be final. | 178 |
| First sentence should end with a period. | 186 |
| Method 'reset' is not designed for extension - needs to be abstract, final or empty. | 189 |
org/apache/giraph/comm/aggregators/SendAggregatedValueCache.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 34 |
| First sentence should end with a period. | 38 |
| Method 'addAggregator' is not designed for extension - needs to be abstract, final or empty. | 47 |
| Parameter taskId should be final. | 47 |
| Parameter aggregatorName should be final. | 47 |
| Parameter aggregatedValue should be final. | 48 |
| Expected @throws tag for 'IOException'. | 48 |
| First sentence should end with a period. | 57 |
| Method 'removeAggregators' is not designed for extension - needs to be abstract, final or empty. | 63 |
| Parameter taskId should be final. | 63 |
| '4' is a magic number. | 67 |
| Method 'addCountAggregator' is not designed for extension - needs to be abstract, final or empty. | 81 |
| Parameter taskId should be final. | 81 |
| Expected @throws tag for 'IOException'. | 81 |
org/apache/giraph/comm/aggregators/SendAggregatorCache.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 35 |
| First sentence should end with a period. | 39 |
| Method 'addAggregator' is not designed for extension - needs to be abstract, final or empty. | 49 |
| Parameter taskId should be final. | 49 |
| Parameter aggregatorName should be final. | 49 |
| Parameter aggregatorClass should be final. | 50 |
| Parameter aggregatedValue should be final. | 51 |
| Expected @throws tag for 'IOException'. | 51 |
| First sentence should end with a period. | 61 |
| Method 'removeAggregators' is not designed for extension - needs to be abstract, final or empty. | 67 |
| Parameter taskId should be final. | 67 |
| '4' is a magic number. | 71 |
| Method 'addCountAggregator' is not designed for extension - needs to be abstract, final or empty. | 85 |
| Parameter taskId should be final. | 85 |
| Expected @throws tag for 'IOException'. | 85 |
org/apache/giraph/comm/aggregators/WorkerAggregatorRequestProcessor.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 25 |
| First sentence should end with a period. | 29 |
| Expected @throws tag for 'IOException'. | 39 |
| Expected @throws tag for 'IOException'. | 46 |
| Expected @throws tag for 'IOException'. | 55 |
| First sentence should end with a period. | 57 |
| Expected @throws tag for 'IOException'. | 63 |
org/apache/giraph/comm/messages/BasicMessageStore.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 25 |
| First sentence should end with a period. | 33 |
| Expected @throws tag for 'IOException'. | 40 |
| Expected @throws tag for 'IOException'. | 51 |
| Expected @throws tag for 'IOException'. | 59 |
| Expected @throws tag for 'IOException'. | 66 |
org/apache/giraph/comm/messages/ByteArrayMessagesPerVertexStore.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 48 |
| Parameter messageClass should be final. | 56 |
| Parameter service should be final. | 57 |
| Parameter config should be final. | 58 |
| Parameter partitionMap should be final. | 72 |
| Parameter iterator should be final. | 73 |
| Method 'addPartitionMessages' is not designed for extension - needs to be abstract, final or empty. | 90 |
| Parameter partitionId should be final. | 92 |
| Parameter messages should be final. | 93 |
| First sentence should end with a period. | 131 |
| Class MessagesIterable should be declared as final. | 134 |
| First sentence should end with a period. | 135 |
| Parameter buf should be final. | 142 |
| Parameter off should be final. | 142 |
| Parameter length should be final. | 142 |
| Method 'getMessagesAsIterable' is not designed for extension - needs to be abstract, final or empty. | 152 |
| Parameter extendedDataOutput should be final. | 154 |
| First sentence should end with a period. | 160 |
| First sentence should end with a period. | 165 |
| Parameter configuration should be final. | 174 |
| Parameter buf should be final. | 175 |
| Parameter off should be final. | 175 |
| Parameter length should be final. | 175 |
| Method 'getNumberOfMessagesIn' is not designed for extension - needs to be abstract, final or empty. | 185 |
| Parameter partitionMap should be final. | 187 |
| Method 'writeMessages' is not designed for extension - needs to be abstract, final or empty. | 198 |
| Parameter extendedDataOutput should be final. | 199 |
| Parameter out should be final. | 200 |
| Method 'readFieldsForMessages' is not designed for extension - needs to be abstract, final or empty. | 206 |
| Parameter in should be final. | 207 |
| First sentence should end with a period. | 217 |
| Parameter service should be final. | 228 |
| Parameter config should be final. | 229 |
| Method 'addMessages' is not designed for extension - needs to be abstract, final or empty. | 233 |
| Parameter messageStore should be final. | 234 |
| ':' should be on a new line. | 241 |
| '+' should be on a new line. | 264 |
| First sentence should end with a period. | 269 |
| First sentence should end with a period. | 277 |
| First sentence should end with a period. | 279 |
| Parameter service should be final. | 286 |
| 'service' hides a field. | 286 |
| Parameter config should be final. | 287 |
| 'config' hides a field. | 287 |
| Parameter messageClass should be final. | 293 |
org/apache/giraph/comm/messages/DiskBackedMessageStore.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 52 |
| First sentence should end with a period. | 54 |
| First sentence should end with a period. | 60 |
| First sentence should end with a period. | 62 |
| First sentence should end with a period. | 64 |
| First sentence should end with a period. | 66 |
| First sentence should end with a period. | 68 |
| First sentence should end with a period. | 71 |
| Parameter messageClass should be final. | 82 |
| 'messageClass' hides a field. | 82 |
| Parameter config should be final. | 83 |
| 'config' hides a field. | 83 |
| Parameter fileStoreFactory should be final. | 84 |
| 'fileStoreFactory' hides a field. | 84 |
| First sentence should end with a period. | 95 |
| Method 'addVertexMessages' is not designed for extension - needs to be abstract, final or empty. | 105 |
| Parameter vertexId should be final. | 105 |
| Parameter messages should be final. | 106 |
| Expected @throws tag for 'IOException'. | 106 |
| Method 'addMessages' is not designed for extension - needs to be abstract, final or empty. | 136 |
| Parameter messageStore should be final. | 137 |
| First sentence should end with a period. | 145 |
| First sentence should end with a period. | 149 |
| Parameter buf should be final. | 157 |
| Parameter off should be final. | 157 |
| Parameter length should be final. | 157 |
| Method 'getVertexMessages' is not designed for extension - needs to be abstract, final or empty. | 167 |
| Parameter vertexId should be final. | 168 |
| Method 'getNumberOfMessages' is not designed for extension - needs to be abstract, final or empty. | 183 |
| Method 'hasMessagesForVertex' is not designed for extension - needs to be abstract, final or empty. | 188 |
| Parameter vertexId should be final. | 189 |
| Method 'getDestinationVertices' is not designed for extension - needs to be abstract, final or empty. | 193 |
| Method 'clearVertexMessages' is not designed for extension - needs to be abstract, final or empty. | 198 |
| Parameter vertexId should be final. | 199 |
| Method 'clearAll' is not designed for extension - needs to be abstract, final or empty. | 203 |
| First sentence should end with a period. | 213 |
| Class TemporaryMessageStore should be declared as final. | 216 |
| First sentence should end with a period. | 217 |
| Parameter temporaryMessages should be final. | 230 |
| 'temporaryMessages' hides a field. | 231 |
| Parameter vertexId should be final. | 241 |
| Parameter messageStore should be final. | 251 |
| Parameter vertexId should be final. | 257 |
| Parameter vertexId should be final. | 267 |
| Parameter dataOutput should be final. | 277 |
| Parameter dataInput should be final. | 282 |
| Method 'flush' is not designed for extension - needs to be abstract, final or empty. | 287 |
| Method 'write' is not designed for extension - needs to be abstract, final or empty. | 307 |
| Parameter out should be final. | 308 |
| Method 'readFields' is not designed for extension - needs to be abstract, final or empty. | 333 |
| Parameter in should be final. | 334 |
| First sentence should end with a period. | 369 |
| Parameter config should be final. | 381 |
| Parameter fileStoreFactory should be final. | 382 |
| First sentence should end with a period. | 386 |
| First sentence should end with a period. | 395 |
| First sentence should end with a period. | 397 |
| Parameter config should be final. | 406 |
| 'config' hides a field. | 406 |
| Parameter fileStoreFactory should be final. | 407 |
| 'fileStoreFactory' hides a field. | 407 |
| Parameter messageClass should be final. | 413 |
org/apache/giraph/comm/messages/DiskBackedMessageStoreByPartition.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 50 |
| First sentence should end with a period. | 52 |
| First sentence should end with a period. | 54 |
| First sentence should end with a period. | 56 |
| First sentence should end with a period. | 59 |
| Parameter messageClass should be final. | 70 |
| 'messageClass' hides a field. | 70 |
| Parameter service should be final. | 71 |
| 'service' hides a field. | 71 |
| Parameter maxNumberOfMessagesInMemory should be final. | 72 |
| 'maxNumberOfMessagesInMemory' hides a field. | 72 |
| Parameter fileStoreFactory should be final. | 73 |
| 'fileStoreFactory' hides a field. | 74 |
| Method 'addPartitionMessages' is not designed for extension - needs to be abstract, final or empty. | 82 |
| Parameter partitionId should be final. | 84 |
| Parameter messages should be final. | 85 |
| '+' should be on a new line. | 106 |
| Method 'addMessages' is not designed for extension - needs to be abstract, final or empty. | 112 |
| Parameter messageStore should be final. | 113 |
| '+' should be on a new line. | 124 |
| Method 'getVertexMessages' is not designed for extension - needs to be abstract, final or empty. | 131 |
| Parameter vertexId should be final. | 132 |
| Method 'getNumberOfMessages' is not designed for extension - needs to be abstract, final or empty. | 140 |
| ':' should be on a new line. | 143 |
| Method 'hasMessagesForVertex' is not designed for extension - needs to be abstract, final or empty. | 150 |
| Parameter vertexId should be final. | 151 |
| Method 'getDestinationVertices' is not designed for extension - needs to be abstract, final or empty. | 155 |
| ':' should be on a new line. | 158 |
| Method 'getPartitionDestinationVertices' is not designed for extension - needs to be abstract, final or empty. | 165 |
| Parameter partitionId should be final. | 166 |
| Method 'clearVertexMessages' is not designed for extension - needs to be abstract, final or empty. | 176 |
| Parameter vertexId should be final. | 177 |
| Method 'clearPartition' is not designed for extension - needs to be abstract, final or empty. | 183 |
| Parameter partitionId should be final. | 184 |
| Method 'clearAll' is not designed for extension - needs to be abstract, final or empty. | 192 |
| ':' should be on a new line. | 194 |
| First sentence should end with a period. | 201 |
| Expected @throws tag for 'IOException'. | 206 |
| First sentence should end with a period. | 212 |
| ':' should be on a new line. | 219 |
| First sentence should end with a period. | 226 |
| Expected @throws tag for 'IOException'. | 231 |
| ':' should be on a new line. | 234 |
| First sentence should end with a period. | 247 |
| Parameter vertexId should be final. | 254 |
| Parameter partitionId should be final. | 268 |
| Avoid inline conditionals. | 277 |
| Method 'writePartition' is not designed for extension - needs to be abstract, final or empty. | 280 |
| Parameter out should be final. | 281 |
| Parameter partitionId should be final. | 282 |
| Method 'write' is not designed for extension - needs to be abstract, final or empty. | 291 |
| Parameter out should be final. | 292 |
| ':' should be on a new line. | 294 |
| Method 'readFieldsForPartition' is not designed for extension - needs to be abstract, final or empty. | 301 |
| Parameter in should be final. | 302 |
| Parameter partitionId should be final. | 303 |
| Method 'readFields' is not designed for extension - needs to be abstract, final or empty. | 312 |
| Parameter in should be final. | 313 |
| First sentence should end with a period. | 325 |
| Parameter service should be final. | 341 |
| Parameter maxMessagesInMemory should be final. | 342 |
| Parameter fileStoreFactory should be final. | 343 |
| First sentence should end with a period. | 349 |
| First sentence should end with a period. | 360 |
| First sentence should end with a period. | 362 |
| First sentence should end with a period. | 364 |
| Parameter service should be final. | 374 |
| 'service' hides a field. | 374 |
| Parameter maxMessagesInMemory should be final. | 375 |
| 'maxMessagesInMemory' hides a field. | 375 |
| Parameter fileStoreFactory should be final. | 376 |
| 'fileStoreFactory' hides a field. | 377 |
| Parameter messageClass should be final. | 384 |
org/apache/giraph/comm/messages/FlushableMessageStore.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 26 |
| Expected @throws tag for 'IOException'. | 39 |
org/apache/giraph/comm/messages/InMemoryMessageStoreFactory.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 39 |
| First sentence should end with a period. | 43 |
| First sentence should end with a period. | 45 |
| Parameter service should be final. | 52 |
| 'service' hides a field. | 52 |
| Parameter conf should be final. | 53 |
| 'conf' hides a field. | 53 |
| Method 'newStore' is not designed for extension - needs to be abstract, final or empty. | 58 |
| Parameter messageClass should be final. | 59 |
| '+' should be on a new line. | 62 |
| '+' should be on a new line. | 69 |
org/apache/giraph/comm/messages/MessageStore.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 24 |
| First sentence should end with a period. | 32 |
| First sentence should end with a period. | 39 |
| First sentence should end with a period. | 47 |
org/apache/giraph/comm/messages/MessageStoreByPartition.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 28 |
| First sentence should end with a period. | 36 |
| Expected @throws tag for 'IOException'. | 45 |
| First sentence should end with a period. | 47 |
| Expected @throws tag for 'IOException'. | 61 |
| Expected @throws tag for 'IOException'. | 70 |
| First sentence should end with a period. | 72 |
| Expected @throws tag for 'IOException'. | 81 |
org/apache/giraph/comm/messages/MessageStoreFactory.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 24 |
org/apache/giraph/comm/messages/OneMessagePerVertexStore.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 45 |
| Parameter messageClass should be final. | 55 |
| Parameter service should be final. | 56 |
| Parameter combiner should be final. | 57 |
| 'combiner' hides a field. | 57 |
| Parameter config should be final. | 58 |
| First sentence should end with a period. | 63 |
| Parameter vertexId should be final. | 72 |
| Parameter partitionMap should be final. | 73 |
| First sentence should end with a period. | 85 |
| Parameter vertexId should be final. | 93 |
| Parameter message should be final. | 93 |
| Parameter partitionMap should be final. | 94 |
| Expected @throws tag for 'IOException'. | 94 |
| Method 'addPartitionMessages' is not designed for extension - needs to be abstract, final or empty. | 101 |
| Parameter partitionId should be final. | 103 |
| Parameter messages should be final. | 104 |
| Method 'getMessagesAsIterable' is not designed for extension - needs to be abstract, final or empty. | 130 |
| Parameter message should be final. | 131 |
| Method 'getNumberOfMessagesIn' is not designed for extension - needs to be abstract, final or empty. | 135 |
| Parameter partitionMap should be final. | 136 |
| Method 'writeMessages' is not designed for extension - needs to be abstract, final or empty. | 140 |
| Parameter messages should be final. | 141 |
| Parameter out should be final. | 141 |
| Method 'readFieldsForMessages' is not designed for extension - needs to be abstract, final or empty. | 145 |
| Parameter in should be final. | 146 |
| Method 'addMessages' is not designed for extension - needs to be abstract, final or empty. | 152 |
| Parameter messageStore should be final. | 153 |
| ':' should be on a new line. | 161 |
| '+' should be on a new line. | 168 |
| First sentence should end with a period. | 173 |
| Parameter service should be final. | 184 |
| Parameter config should be final. | 185 |
| First sentence should end with a period. | 189 |
| First sentence should end with a period. | 198 |
| First sentence should end with a period. | 200 |
| Parameter service should be final. | 207 |
| 'service' hides a field. | 207 |
| Parameter config should be final. | 208 |
| 'config' hides a field. | 208 |
| Parameter messageClass should be final. | 214 |
org/apache/giraph/comm/messages/SequentialFileMessageStore.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 64 |
| First sentence should end with a period. | 67 |
| First sentence should end with a period. | 69 |
| First sentence should end with a period. | 71 |
| First sentence should end with a period. | 73 |
| First sentence should end with a period. | 75 |
| First sentence should end with a period. | 77 |
| First sentence should end with a period. | 79 |
| Parameter messageClass should be final. | 92 |
| 'messageClass' hides a field. | 92 |
| Parameter config should be final. | 93 |
| 'config' hides a field. | 93 |
| Parameter bufferSize should be final. | 94 |
| 'bufferSize' hides a field. | 94 |
| Parameter fileName should be final. | 95 |
| Method 'addMessages' is not designed for extension - needs to be abstract, final or empty. | 102 |
| Parameter messageStore should be final. | 103 |
| '+' should be on a new line. | 146 |
| Method 'getVertexMessages' is not designed for extension - needs to be abstract, final or empty. | 173 |
| Parameter vertexId should be final. | 174 |
| Expected @throws tag for 'IOException'. | 175 |
| '+' should be on a new line. | 177 |
| Parameter vertexId should be final. | 197 |
| Method 'clearAll' is not designed for extension - needs to be abstract, final or empty. | 199 |
| Method 'write' is not designed for extension - needs to be abstract, final or empty. | 205 |
| Parameter out should be final. | 206 |
| Method 'readFields' is not designed for extension - needs to be abstract, final or empty. | 223 |
| Parameter in should be final. | 224 |
| 'in' hides a field. | 224 |
| First sentence should end with a period. | 239 |
| Expected @throws tag for 'IOException'. | 244 |
| '+' should be on a new line. | 250 |
| Expected @throws tag for 'IOException'. | 265 |
| Expected @throws tag for 'IOException'. | 282 |
| Expected @throws tag for 'IOException'. | 300 |
| '+' should be on a new line. | 308 |
| '+' should be on a new line. | 309 |
| '+' should be on a new line. | 310 |
| Expected @throws tag for 'IOException'. | 324 |
| Expected @throws tag for 'IOException'. | 337 |
| First sentence should end with a period. | 347 |
| Parameter config should be final. | 357 |
| First sentence should end with a period. | 361 |
| First sentence should end with a period. | 370 |
| First sentence should end with a period. | 372 |
| First sentence should end with a period. | 374 |
| First sentence should end with a period. | 376 |
| Parameter config should be final. | 384 |
| 'config' hides a field. | 384 |
| '+' should be on a new line. | 393 |
| Parameter messageClass should be final. | 403 |
org/apache/giraph/comm/messages/SimpleMessageStore.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 48 |
| Variable 'messageClass' must be private and have accessor methods. | 49 |
| First sentence should end with a period. | 50 |
| Variable 'service' must be private and have accessor methods. | 51 |
| First sentence should end with a period. | 52 |
| Variable 'map' must be private and have accessor methods. | 53 |
| First sentence should end with a period. | 54 |
| Variable 'config' must be private and have accessor methods. | 55 |
| First sentence should end with a period. | 57 |
| Parameter messageClass should be final. | 65 |
| 'messageClass' hides a field. | 65 |
| Parameter service should be final. | 66 |
| 'service' hides a field. | 66 |
| Parameter config should be final. | 67 |
| 'config' hides a field. | 67 |
| First sentence should end with a period. | 75 |
| First sentence should end with a period. | 83 |
| First sentence should end with a period. | 92 |
| Expected @throws tag for 'IOException'. | 100 |
| First sentence should end with a period. | 102 |
| Expected @throws tag for 'IOException'. | 109 |
| First sentence should end with a period. | 111 |
| Method 'getPartitionId' is not designed for extension - needs to be abstract, final or empty. | 117 |
| Parameter vertexId should be final. | 117 |
| Method 'getOrCreatePartitionMap' is not designed for extension - needs to be abstract, final or empty. | 129 |
| Parameter partitionId should be final. | 129 |
| Method 'getPartitionDestinationVertices' is not designed for extension - needs to be abstract, final or empty. | 142 |
| Parameter partitionId should be final. | 143 |
| Avoid inline conditionals. | 145 |
| ':' should be on a new line. | 145 |
| Method 'hasMessagesForVertex' is not designed for extension - needs to be abstract, final or empty. | 149 |
| Parameter vertexId should be final. | 150 |
| Avoid inline conditionals. | 153 |
| Method 'getDestinationVertices' is not designed for extension - needs to be abstract, final or empty. | 156 |
| Method 'getVertexMessages' is not designed for extension - needs to be abstract, final or empty. | 165 |
| Parameter vertexId should be final. | 166 |
| Avoid inline conditionals. | 172 |
| ':' should be on a new line. | 172 |
| Method 'getNumberOfMessages' is not designed for extension - needs to be abstract, final or empty. | 176 |
| Method 'writePartition' is not designed for extension - needs to be abstract, final or empty. | 185 |
| Parameter out should be final. | 186 |
| Parameter partitionId should be final. | 187 |
| Method 'write' is not designed for extension - needs to be abstract, final or empty. | 199 |
| Parameter out should be final. | 200 |
| Method 'readFieldsForPartition' is not designed for extension - needs to be abstract, final or empty. | 208 |
| Parameter in should be final. | 209 |
| Parameter partitionId should be final. | 210 |
| Method 'readFields' is not designed for extension - needs to be abstract, final or empty. | 223 |
| Parameter in should be final. | 224 |
| Method 'clearVertexMessages' is not designed for extension - needs to be abstract, final or empty. | 232 |
| Parameter vertexId should be final. | 233 |
| Method 'clearPartition' is not designed for extension - needs to be abstract, final or empty. | 241 |
| Parameter partitionId should be final. | 242 |
| Method 'clearAll' is not designed for extension - needs to be abstract, final or empty. | 246 |
org/apache/giraph/comm/netty/ByteCounter.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 49 |
| First sentence should end with a period. | 51 |
| First sentence should end with a period. | 54 |
| First sentence should end with a period. | 57 |
| First sentence should end with a period. | 59 |
| First sentence should end with a period. | 61 |
| First sentence should end with a period. | 63 |
| First sentence should end with a period. | 65 |
| First sentence should end with a period. | 67 |
| First sentence should end with a period. | 69 |
| First sentence should end with a period. | 73 |
| First sentence should end with a period. | 75 |
| First sentence should end with a period. | 77 |
| First sentence should end with a period. | 79 |
| First sentence should end with a period. | 82 |
| Method 'newSuperstep' is not designed for extension - needs to be abstract, final or empty. | 88 |
| Parameter superstepMetrics should be final. | 89 |
| Method 'handleUpstream' is not designed for extension - needs to be abstract, final or empty. | 99 |
| Parameter ctx should be final. | 100 |
| Parameter e should be final. | 100 |
| '&&' should be on a new line. | 102 |
| '+' should be on a new line. | 111 |
| Method 'handleDownstream' is not designed for extension - needs to be abstract, final or empty. | 119 |
| Parameter ctx should be final. | 120 |
| Parameter e should be final. | 120 |
| '&&' should be on a new line. | 122 |
| '+' should be on a new line. | 131 |
| First sentence should end with a period. | 156 |
| Method 'resetAll' is not designed for extension - needs to be abstract, final or empty. | 159 |
| Method 'getBytesSent' is not designed for extension - needs to be abstract, final or empty. | 164 |
| Missing a Javadoc comment. | 164 |
| Method 'getBytesReceived' is not designed for extension - needs to be abstract, final or empty. | 168 |
| Missing a Javadoc comment. | 168 |
| Method 'getMbytesPerSecSent' is not designed for extension - needs to be abstract, final or empty. | 175 |
| '1000f' is a magic number. | 176 |
| '/' should be on a new line. | 176 |
| Method 'getMbytesPerSecReceived' is not designed for extension - needs to be abstract, final or empty. | 183 |
| '1000f' is a magic number. | 184 |
| '/' should be on a new line. | 184 |
| Method 'getMetrics' is not designed for extension - needs to be abstract, final or empty. | 191 |
| Avoid inline conditionals. | 197 |
| Avoid inline conditionals. | 199 |
| '+' should be on a new line. | 200 |
| '+' should be on a new line. | 201 |
| '+' should be on a new line. | 202 |
| '+' should be on a new line. | 203 |
| '+' should be on a new line. | 204 |
| '+' should be on a new line. | 205 |
| '+' should be on a new line. | 206 |
| '+' should be on a new line. | 207 |
| '+' should be on a new line. | 208 |
| '+' should be on a new line. | 209 |
| '+' should be on a new line. | 210 |
| '1000f' is a magic number. | 211 |
| Method 'getMetricsWindow' is not designed for extension - needs to be abstract, final or empty. | 221 |
| Parameter minMsecsWindow should be final. | 221 |
org/apache/giraph/comm/netty/ChannelRotater.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 31 |
| First sentence should end with a period. | 33 |
| First sentence should end with a period. | 35 |
| First sentence should end with a period. | 38 |
| Parameter taskId should be final. | 43 |
| 'taskId' hides a field. | 43 |
| Method 'getTaskId' is not designed for extension - needs to be abstract, final or empty. | 47 |
| Missing a Javadoc comment. | 47 |
| First sentence should end with a period. | 51 |
| Method 'addChannel' is not designed for extension - needs to be abstract, final or empty. | 56 |
| Parameter channel should be final. | 56 |
| First sentence should end with a period. | 62 |
| Method 'nextChannel' is not designed for extension - needs to be abstract, final or empty. | 67 |
| First sentence should end with a period. | 79 |
| Method 'removeChannel' is not designed for extension - needs to be abstract, final or empty. | 85 |
| Parameter channel should be final. | 85 |
| First sentence should end with a period. | 93 |
| Method 'size' is not designed for extension - needs to be abstract, final or empty. | 98 |
| First sentence should end with a period. | 102 |
| Method 'closeChannels' is not designed for extension - needs to be abstract, final or empty. | 107 |
| Parameter channelFutureListener should be final. | 108 |
| First sentence should end with a period. | 117 |
| Method 'getChannels' is not designed for extension - needs to be abstract, final or empty. | 122 |
org/apache/giraph/comm/netty/NettyClient.java
| Violation | Message | Line |
|---|---|---|
| Line is longer than 80 characters. | 76 |
| Line is longer than 80 characters. | 77 |
| Line is longer than 80 characters. | 78 |
| Line is longer than 80 characters. | 79 |
| Line is longer than 80 characters. | 80 |
| First sentence should end with a period. | 88 |
| First sentence should end with a period. | 91 |
| First sentence should end with a period. | 93 |
| First sentence should end with a period. | 96 |
| First sentence should end with a period. | 98 |
| First sentence should end with a period. | 100 |
| First sentence should end with a period. | 105 |
| First sentence should end with a period. | 108 |
| First sentence should end with a period. | 112 |
| First sentence should end with a period. | 114 |
| First sentence should end with a period. | 116 |
| First sentence should end with a period. | 118 |
| First sentence should end with a period. | 124 |
| First sentence should end with a period. | 134 |
| First sentence should end with a period. | 136 |
| First sentence should end with a period. | 138 |
| First sentence should end with a period. | 140 |
| First sentence should end with a period. | 142 |
| First sentence should end with a period. | 144 |
| First sentence should end with a period. | 146 |
| First sentence should end with a period. | 148 |
| First sentence should end with a period. | 150 |
| First sentence should end with a period. | 152 |
| First sentence should end with a period. | 154 |
| First sentence should end with a period. | 156 |
| First sentence should end with a period. | 158 |
| First sentence should end with a period. | 161 |
| First sentence should end with a period. | 163 |
| First sentence should end with a period. | 165 |
| First sentence should end with a period. | 169 |
| First sentence should end with a period. | 171 |
| First sentence should end with a period. | 173 |
| First sentence should end with a period. | 177 |
| Parameter context should be final. | 184 |
| 'context' hides a field. | 184 |
| Parameter myTaskInfo should be final. | 186 |
| 'myTaskInfo' hides a field. | 186 |
| '+' should be on a new line. | 201 |
| '1048576' is a magic number. | 228 |
| '1048576' is a magic number. | 228 |
| '+' should be on a new line. | 232 |
| '+' should be on a new line. | 233 |
| '1024' is a magic number. | 282 |
| '4' is a magic number. | 282 |
| '4' is a magic number. | 282 |
| First sentence should end with a period. | 320 |
| First sentence should end with a period. | 322 |
| First sentence should end with a period. | 324 |
| Parameter future should be final. | 335 |
| 'future' hides a field. | 335 |
| Parameter address should be final. | 335 |
| 'address' hides a field. | 335 |
| Parameter taskId should be final. | 335 |
| 'taskId' hides a field. | 335 |
| '+' should be on a new line. | 343 |
| First sentence should end with a period. | 348 |
| Method 'connectAllAddresses' is not designed for extension - needs to be abstract, final or empty. | 353 |
| Parameter tasks should be final. | 353 |
| '||' should be on a new line. | 359 |
| '||' should be on a new line. | 360 |
| '||' should be on a new line. | 366 |
| '+' should be on a new line. | 368 |
| '+' should be on a new line. | 372 |
| '+' should be on a new line. | 400 |
| '+' should be on a new line. | 401 |
| '+' should be on a new line. | 412 |
| '+' should be on a new line. | 436 |
| '+' should be on a new line. | 437 |
| '+' should be on a new line. | 438 |
| '+' should be on a new line. | 439 |
| Method 'authenticate' is not designed for extension - needs to be abstract, final or empty. | 456 |
| '+' should be on a new line. | 457 |
| '+' should be on a new line. | 466 |
| '+' should be on a new line. | 473 |
| '+' should be on a new line. | 474 |
| Avoid inline conditionals. | 475 |
| '+' should be on a new line. | 475 |
| Parameter taskId should be final. | 486 |
| Parameter channel should be final. | 486 |
| '+' should be on a new line. | 491 |
| '+' should be on a new line. | 499 |
| '+' should be on a new line. | 513 |
| '+' should be on a new line. | 518 |
| '+' should be on a new line. | 522 |
| Method 'stop' is not designed for extension - needs to be abstract, final or empty. | 532 |
| Parameter cf should be final. | 545 |
| '+' should be on a new line. | 549 |
| '+' should be on a new line. | 550 |
| First sentence should end with a period. | 565 |
| Parameter remoteServer should be final. | 571 |
| '+' should be on a new line. | 585 |
| '+' should be on a new line. | 589 |
| '+' should be on a new line. | 590 |
| '+' should be on a new line. | 606 |
| '+' should be on a new line. | 607 |
| '5000' is a magic number. | 611 |
| '+' should be on a new line. | 616 |
| '+' should be on a new line. | 617 |
| First sentence should end with a period. | 621 |
| Method 'sendWritableRequest' is not designed for extension - needs to be abstract, final or empty. | 627 |
| Parameter destTaskId should be final. | 627 |
| Parameter request should be final. | 628 |
| '+' should be on a new line. | 651 |
| '+' should be on a new line. | 652 |
| '&&' should be on a new line. | 659 |
| Method 'waitAllRequests' is not designed for extension - needs to be abstract, final or empty. | 670 |
| '+' should be on a new line. | 673 |
| Parameter maxOpenRequests should be final. | 686 |
| Parameter maxOpenRequests should be final. | 712 |
| '+' should be on a new line. | 714 |
| '+' should be on a new line. | 715 |
| '+' should be on a new line. | 716 |
| '+' should be on a new line. | 717 |
| ':' should be on a new line. | 721 |
| '+' should be on a new line. | 723 |
| ':' should be on a new line. | 730 |
| Avoid inline conditionals. | 735 |
| Parameter entry1 should be final. | 742 |
| Parameter entry2 should be final. | 743 |
| Avoid inline conditionals. | 746 |
| Avoid inline conditionals. | 746 |
| ':' should be on a new line. | 782 |
| '||' should be on a new line. | 792 |
| '||' should be on a new line. | 793 |
| '+' should be on a new line. | 795 |
| '+' should be on a new line. | 796 |
| '+' should be on a new line. | 797 |
| '+' should be on a new line. | 798 |
| '+' should be on a new line. | 799 |
| '+' should be on a new line. | 800 |
| '+' should be on a new line. | 801 |
| '+' should be on a new line. | 802 |
| '==' should be on a new line. | 815 |
| '+' should be on a new line. | 817 |
| First sentence should end with a period. | 833 |
| Unused @throws tag for 'IllegalStateException'. | 840 |
| Parameter maxResolveAddressAttempts should be final. | 844 |
| Parameter address should be final. | 844 |
| '&&' should be on a new line. | 846 |
| '+' should be on a new line. | 849 |
| '+' should be on a new line. | 850 |
| '5000' is a magic number. | 853 |
| '+' should be on a new line. | 861 |
org/apache/giraph/comm/netty/NettyMasterClient.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 35 |
| First sentence should end with a period. | 39 |
| First sentence should end with a period. | 41 |
| First sentence should end with a period. | 43 |
| First sentence should end with a period. | 46 |
| First sentence should end with a period. | 48 |
| First sentence should end with a period. | 51 |
| Parameter context should be final. | 58 |
| Parameter configuration should be final. | 59 |
| Parameter service should be final. | 60 |
| 'service' hides a field. | 60 |
| Method 'openConnections' is not designed for extension - needs to be abstract, final or empty. | 70 |
| Method 'sendAggregator' is not designed for extension - needs to be abstract, final or empty. | 75 |
| Parameter aggregatorName should be final. | 76 |
| Parameter aggregatorClass should be final. | 77 |
| Parameter aggregatedValue should be final. | 78 |
| Method 'finishSendingAggregatedValues' is not designed for extension - needs to be abstract, final or empty. | 88 |
| Parameter worker should be final. | 103 |
| Method 'flush' is not designed for extension - needs to be abstract, final or empty. | 111 |
| Method 'closeConnections' is not designed for extension - needs to be abstract, final or empty. | 116 |
org/apache/giraph/comm/netty/NettyMasterServer.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 29 |
| First sentence should end with a period. | 33 |
| First sentence should end with a period. | 36 |
| Parameter conf should be final. | 43 |
| Parameter service should be final. | 44 |
| Parameter progressable should be final. | 45 |
| Method 'getMyAddress' is not designed for extension - needs to be abstract, final or empty. | 52 |
| Method 'close' is not designed for extension - needs to be abstract, final or empty. | 57 |
org/apache/giraph/comm/netty/NettyServer.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 66 |
| First sentence should end with a period. | 70 |
| First sentence should end with a period. | 75 |
| First sentence should end with a period. | 81 |
| First sentence should end with a period. | 83 |
| First sentence should end with a period. | 85 |
| First sentence should end with a period. | 87 |
| First sentence should end with a period. | 89 |
| First sentence should end with a period. | 91 |
| First sentence should end with a period. | 93 |
| First sentence should end with a period. | 95 |
| First sentence should end with a period. | 97 |
| First sentence should end with a period. | 99 |
| First sentence should end with a period. | 101 |
| First sentence should end with a period. | 104 |
| First sentence should end with a period. | 107 |
| First sentence should end with a period. | 109 |
| First sentence should end with a period. | 111 |
| First sentence should end with a period. | 113 |
| First sentence should end with a period. | 115 |
| First sentence should end with a period. | 117 |
| First sentence should end with a period. | 119 |
| First sentence should end with a period. | 123 |
| First sentence should end with a period. | 125 |
| First sentence should end with a period. | 128 |
| Parameter conf should be final. | 136 |
| 'conf' hides a field. | 136 |
| Parameter requestServerHandlerFactory should be final. | 137 |
| 'requestServerHandlerFactory' hides a field. | 137 |
| Parameter myTaskInfo should be final. | 138 |
| 'myTaskInfo' hides a field. | 138 |
| Parameter progressable should be final. | 138 |
| 'progressable' hides a field. | 138 |
| '1048576' is a magic number. | 183 |
| '1048576' is a magic number. | 183 |
| '+' should be on a new line. | 187 |
| '+' should be on a new line. | 188 |
| First sentence should end with a period. | 197 |
| Parameter conf should be final. | 206 |
| 'conf' hides a field. | 206 |
| Parameter requestServerHandlerFactory should be final. | 207 |
| 'requestServerHandlerFactory' hides a field. | 207 |
| Parameter myTaskInfo should be final. | 208 |
| 'myTaskInfo' hides a field. | 208 |
| Parameter progressable should be final. | 209 |
| 'progressable' hides a field. | 209 |
| Parameter saslServerHandlerFactory should be final. | 210 |
| 'saslServerHandlerFactory' hides a field. | 210 |
| First sentence should end with a period. | 216 |
| Method 'start' is not designed for extension - needs to be abstract, final or empty. | 219 |
| '4' is a magic number. | 229 |
| '+' should be on a new line. | 242 |
| '1024' is a magic number. | 250 |
| '1024' is a magic number. | 250 |
| '1024' is a magic number. | 250 |
| '4' is a magic number. | 250 |
| '4' is a magic number. | 250 |
| Parameter ctx should be final. | 270 |
| Parameter e should be final. | 271 |
| '1024' is a magic number. | 279 |
| '1024' is a magic number. | 279 |
| '1024' is a magic number. | 279 |
| '4' is a magic number. | 279 |
| '4' is a magic number. | 279 |
| '10' is a magic number. | 301 |
| '+' should be on a new line. | 316 |
| '+' should be on a new line. | 317 |
| '+' should be on a new line. | 331 |
| '+' should be on a new line. | 339 |
| '+' should be on a new line. | 344 |
| '+' should be on a new line. | 345 |
| '+' should be on a new line. | 346 |
| '+' should be on a new line. | 347 |
| '+' should be on a new line. | 348 |
| Method 'stop' is not designed for extension - needs to be abstract, final or empty. | 356 |
| Method 'getMyAddress' is not designed for extension - needs to be abstract, final or empty. | 380 |
| Missing a Javadoc comment. | 380 |
org/apache/giraph/comm/netty/NettyWorkerAggregatorRequestProcessor.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 36 |
| First sentence should end with a period. | 41 |
| First sentence should end with a period. | 43 |
| First sentence should end with a period. | 45 |
| First sentence should end with a period. | 47 |
| First sentence should end with a period. | 50 |
| Parameter progressable should be final. | 61 |
| 'progressable' hides a field. | 61 |
| Parameter configuration should be final. | 62 |
| Parameter serviceWorker should be final. | 63 |
| 'serviceWorker' hides a field. | 63 |
| Method 'sendAggregatedValue' is not designed for extension - needs to be abstract, final or empty. | 73 |
| Parameter aggregatorName should be final. | 74 |
| Parameter aggregatedValue should be final. | 75 |
| Method 'flush' is not designed for extension - needs to be abstract, final or empty. | 91 |
| Parameter worker should be final. | 108 |
| Method 'sendAggregatedValuesToMaster' is not designed for extension - needs to be abstract, final or empty. | 116 |
| Parameter aggregatorData should be final. | 118 |
| Method 'distributeAggregators' is not designed for extension - needs to be abstract, final or empty. | 123 |
| Parameter aggregatorDataList should be final. | 125 |
| Parameter workerInfo should be final. | 145 |
org/apache/giraph/comm/netty/NettyWorkerClient.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 58 |
| First sentence should end with a period. | 60 |
| First sentence should end with a period. | 62 |
| First sentence should end with a period. | 64 |
| First sentence should end with a period. | 68 |
| Parameter context should be final. | 79 |
| Parameter configuration should be final. | 80 |
| Parameter service should be final. | 81 |
| 'service' hides a field. | 81 |
| Method 'newSuperstep' is not designed for extension - needs to be abstract, final or empty. | 90 |
| Parameter metrics should be final. | 91 |
| Method 'getService' is not designed for extension - needs to be abstract, final or empty. | 113 |
| Missing a Javadoc comment. | 113 |
| Method 'openConnections' is not designed for extension - needs to be abstract, final or empty. | 117 |
| Method 'getVertexPartitionOwner' is not designed for extension - needs to be abstract, final or empty. | 131 |
| Parameter vertexId should be final. | 132 |
| Method 'sendWritableRequest' is not designed for extension - needs to be abstract, final or empty. | 136 |
| Parameter destTaskId should be final. | 137 |
| Parameter request should be final. | 138 |
| Method 'waitAllRequests' is not designed for extension - needs to be abstract, final or empty. | 146 |
| Method 'closeConnections' is not designed for extension - needs to be abstract, final or empty. | 151 |
| Method 'setup' is not designed for extension - needs to be abstract, final or empty. | 162 |
| Parameter authenticate should be final. | 163 |
| Method 'authenticate' is not designed for extension - needs to be abstract, final or empty. | 173 |
org/apache/giraph/comm/netty/NettyWorkerClientRequestProcessor.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 79 |
| First sentence should end with a period. | 82 |
| First sentence should end with a period. | 84 |
| First sentence should end with a period. | 88 |
| First sentence should end with a period. | 91 |
| First sentence should end with a period. | 93 |
| First sentence should end with a period. | 95 |
| First sentence should end with a period. | 99 |
| First sentence should end with a period. | 101 |
| First sentence should end with a period. | 103 |
| First sentence should end with a period. | 105 |
| First sentence should end with a period. | 109 |
| First sentence should end with a period. | 111 |
| Parameter context should be final. | 122 |
| Parameter conf should be final. | 123 |
| Parameter serviceWorker should be final. | 124 |
| 'serviceWorker' hides a field. | 124 |
| Method 'sendMessageRequest' is not designed for extension - needs to be abstract, final or empty. | 161 |
| Parameter destVertexId should be final. | 162 |
| Parameter message should be final. | 162 |
| '+' should be on a new line. | 168 |
| Method 'sendPartitionRequest' is not designed for extension - needs to be abstract, final or empty. | 192 |
| Parameter workerInfo should be final. | 193 |
| Parameter partition should be final. | 194 |
| '+' should be on a new line. | 196 |
| Parameter workerInfo should be final. | 215 |
| Parameter partition should be final. | 216 |
| ':' should be on a new line. | 225 |
| Method 'sendVertexRequest' is not designed for extension - needs to be abstract, final or empty. | 258 |
| Parameter partitionOwner should be final. | 259 |
| Parameter vertex should be final. | 260 |
| Method 'addEdgeRequest' is not designed for extension - needs to be abstract, final or empty. | 270 |
| Parameter vertexIndex should be final. | 271 |
| Parameter edge should be final. | 271 |
| '+' should be on a new line. | 277 |
| Method 'sendEdgeRequest' is not designed for extension - needs to be abstract, final or empty. | 289 |
| Parameter sourceVertexId should be final. | 290 |
| Parameter edge should be final. | 290 |
| '+' should be on a new line. | 297 |
| Parameter partitionId should be final. | 328 |
| Parameter partitionOwner should be final. | 328 |
| Parameter partitionMutationCount should be final. | 329 |
| Method 'removeEdgesRequest' is not designed for extension - needs to be abstract, final or empty. | 341 |
| Parameter vertexIndex should be final. | 342 |
| Parameter destinationVertexIndex should be final. | 343 |
| '+' should be on a new line. | 348 |
| '+' should be on a new line. | 349 |
| Method 'addVertexRequest' is not designed for extension - needs to be abstract, final or empty. | 362 |
| Parameter vertex should be final. | 363 |
| '+' should be on a new line. | 368 |
| Method 'removeVertexRequest' is not designed for extension - needs to be abstract, final or empty. | 380 |
| Parameter vertexIndex should be final. | 381 |
| '+' should be on a new line. | 386 |
| Method 'flush' is not designed for extension - needs to be abstract, final or empty. | 398 |
| ':' should be on a new line. | 401 |
| ':' should be on a new line. | 440 |
| Method 'resetMessageCount' is not designed for extension - needs to be abstract, final or empty. | 452 |
| First sentence should end with a period. | 459 |
| Parameter workerInfo should be final. | 465 |
| Parameter writableRequest should be final. | 466 |
| '==' should be on a new line. | 468 |
org/apache/giraph/comm/netty/NettyWorkerServer.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 66 |
| First sentence should end with a period. | 69 |
| First sentence should end with a period. | 71 |
| First sentence should end with a period. | 73 |
| First sentence should end with a period. | 75 |
| First sentence should end with a period. | 77 |
| Parameter conf should be final. | 87 |
| 'conf' hides a field. | 87 |
| Parameter service should be final. | 88 |
| 'service' hides a field. | 88 |
| Parameter context should be final. | 89 |
| 'context' hides a field. | 89 |
| First sentence should end with a period. | 104 |
| '+' should be on a new line. | 118 |
| Method 'getMyAddress' is not designed for extension - needs to be abstract, final or empty. | 131 |
| Method 'prepareSuperstep' is not designed for extension - needs to be abstract, final or empty. | 136 |
| '100' is a magic number. | 147 |
| ':' should be on a new line. | 149 |
| '+' should be on a new line. | 155 |
| '+' should be on a new line. | 170 |
| ':' should be on a new line. | 180 |
| '+' should be on a new line. | 204 |
| '+' should be on a new line. | 205 |
| '+' should be on a new line. | 206 |
| '+' should be on a new line. | 207 |
| '+' should be on a new line. | 208 |
| '+' should be on a new line. | 220 |
| '+' should be on a new line. | 221 |
| Method 'getServerData' is not designed for extension - needs to be abstract, final or empty. | 226 |
| Method 'close' is not designed for extension - needs to be abstract, final or empty. | 231 |
org/apache/giraph/comm/netty/SaslNettyClient.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 50 |
| '+' should be on a new line. | 73 |
| '+' should be on a new line. | 74 |
| '{' is followed by whitespace. | 77 |
| '+' should be on a new line. | 81 |
| Method 'getAuthenticated' is not designed for extension - needs to be abstract, final or empty. | 87 |
| Missing a Javadoc comment. | 87 |
| Parameter conf should be final. | 99 |
| Expected @throws tag for 'IOException'. | 100 |
| '+' should be on a new line. | 109 |
| '+' should be on a new line. | 110 |
| Method 'firstToken' is not designed for extension - needs to be abstract, final or empty. | 120 |
| Expected @throws tag for 'IOException'. | 121 |
| Method 'isComplete' is not designed for extension - needs to be abstract, final or empty. | 132 |
| Missing a Javadoc comment. | 132 |
| Method 'saslResponse' is not designed for extension - needs to be abstract, final or empty. | 141 |
| Parameter saslTokenMessage should be final. | 141 |
| First sentence should end with a period. | 157 |
| First sentence should end with a period. | 159 |
| Parameter token should be final. | 166 |
| Parameter callbacks should be final. | 178 |
| Expected @throws tag for 'UnsupportedCallbackException'. | 179 |
| '+' should be on a new line. | 199 |
| '+' should be on a new line. | 212 |
org/apache/giraph/comm/netty/SaslNettyServer.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 47 |
| First sentence should end with a period. | 56 |
| Parameter secretManager should be final. | 61 |
| Method 'isComplete' is not designed for extension - needs to be abstract, final or empty. | 84 |
| Missing a Javadoc comment. | 84 |
| Method 'getUserName' is not designed for extension - needs to be abstract, final or empty. | 88 |
| Missing a Javadoc comment. | 88 |
| Method 'response' is not designed for extension - needs to be abstract, final or empty. | 98 |
| Parameter token should be final. | 98 |
| '+' should be on a new line. | 101 |
| '+' should be on a new line. | 110 |
| Parameter identifier should be final. | 122 |
| Parameter password should be final. | 131 |
| First sentence should end with a period. | 135 |
| First sentence should end with a period. | 138 |
| First sentence should end with a period. | 141 |
| Parameter secretManager should be final. | 147 |
| 'secretManager' hides a field. | 147 |
| '+' should be on a new line. | 149 |
| Method 'handle' is not designed for extension - needs to be abstract, final or empty. | 156 |
| Parameter callbacks should be final. | 157 |
| '+' should be on a new line. | 183 |
| '+' should be on a new line. | 201 |
org/apache/giraph/comm/netty/WrappedAdaptiveReceiveBufferSizePredictorFactory.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 33 |
| Parameter minimum should be final. | 51 |
| Parameter initial should be final. | 52 |
| Parameter maximum should be final. | 53 |
| Method 'getPredictor' is not designed for extension - needs to be abstract, final or empty. | 58 |
| First sentence should end with a period. | 69 |
| First sentence should end with a period. | 72 |
| First sentence should end with a period. | 75 |
| First sentence should end with a period. | 77 |
| Parameter minimum should be final. | 97 |
| Parameter initial should be final. | 98 |
| Parameter maximum should be final. | 99 |
| '1000' is a magic number. | 109 |
| '+' should be on a new line. | 110 |
| '+' should be on a new line. | 111 |
| Parameter previousReceiveBufferSize should be final. | 120 |
| '1000' is a magic number. | 122 |
| '+' should be on a new line. | 123 |
| '+' should be on a new line. | 124 |
org/apache/giraph/comm/netty/handler/AddressRequestIdGenerator.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 31 |
| Method 'getNextRequestId' is not designed for extension - needs to be abstract, final or empty. | 41 |
| Parameter address should be final. | 41 |
org/apache/giraph/comm/netty/handler/AuthorizeServerHandler.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 34 |
| Method 'messageReceived' is not designed for extension - needs to be abstract, final or empty. | 44 |
| Parameter ctx should be final. | 46 |
| Parameter e should be final. | 46 |
| '+' should be on a new line. | 55 |
| '+' should be on a new line. | 56 |
| '+' should be on a new line. | 57 |
| '+' should be on a new line. | 63 |
| '+' should be on a new line. | 64 |
| '+' should be on a new line. | 71 |
| '+' should be on a new line. | 72 |
org/apache/giraph/comm/netty/handler/ClientRequestId.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 27 |
| First sentence should end with a period. | 29 |
| Parameter destinationTaskId should be final. | 38 |
| 'destinationTaskId' hides a field. | 38 |
| Parameter requestId should be final. | 38 |
| 'requestId' hides a field. | 38 |
| Method 'getDestinationTaskId' is not designed for extension - needs to be abstract, final or empty. | 43 |
| Missing a Javadoc comment. | 43 |
| Method 'getRequestId' is not designed for extension - needs to be abstract, final or empty. | 47 |
| Missing a Javadoc comment. | 47 |
| Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. | 51 |
| '29' is a magic number. | 53 |
| '57' is a magic number. | 53 |
| Method 'equals' is not designed for extension - needs to be abstract, final or empty. | 56 |
| Parameter other should be final. | 57 |
| '&&' should be on a new line. | 60 |
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 69 |
org/apache/giraph/comm/netty/handler/MasterRequestServerHandler.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 26 |
| First sentence should end with a period. | 29 |
| First sentence should end with a period. | 32 |
| Parameter workerRequestReservedMap should be final. | 41 |
| Parameter conf should be final. | 42 |
| Parameter myTaskInfo should be final. | 43 |
| Parameter aggregatorHandler should be final. | 44 |
| 'aggregatorHandler' hides a field. | 44 |
| Method 'processRequest' is not designed for extension - needs to be abstract, final or empty. | 49 |
| Parameter request should be final. | 50 |
| First sentence should end with a period. | 54 |
| First sentence should end with a period. | 58 |
| First sentence should end with a period. | 61 |
| Parameter aggregatorHandler should be final. | 66 |
| 'aggregatorHandler' hides a field. | 66 |
| Method 'newHandler' is not designed for extension - needs to be abstract, final or empty. | 70 |
| Parameter workerRequestReservedMap should be final. | 72 |
| Parameter conf should be final. | 73 |
| Parameter myTaskInfo should be final. | 74 |
org/apache/giraph/comm/netty/handler/RequestDecoder.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 40 |
| First sentence should end with a period. | 43 |
| First sentence should end with a period. | 45 |
| First sentence should end with a period. | 47 |
| First sentence should end with a period. | 49 |
| Parameter conf should be final. | 57 |
| 'conf' hides a field. | 57 |
| Parameter byteCounter should be final. | 58 |
| 'byteCounter' hides a field. | 58 |
| Method 'decode' is not designed for extension - needs to be abstract, final or empty. | 63 |
| Parameter ctx should be final. | 64 |
| Parameter channel should be final. | 65 |
| Parameter msg should be final. | 65 |
| '30000' is a magic number. | 71 |
| '+' should be on a new line. | 94 |
| '+' should be on a new line. | 95 |
| '+' should be on a new line. | 96 |
| '+' should be on a new line. | 97 |
org/apache/giraph/comm/netty/handler/RequestEncoder.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 39 |
| First sentence should end with a period. | 41 |
| First sentence should end with a period. | 43 |
| '4' is a magic number. | 44 |
| First sentence should end with a period. | 45 |
| First sentence should end with a period. | 47 |
| First sentence should end with a period. | 49 |
| Parameter conf should be final. | 57 |
| Method 'encode' is not designed for extension - needs to be abstract, final or empty. | 64 |
| Parameter ctx should be final. | 65 |
| Parameter channel should be final. | 66 |
| Parameter msg should be final. | 66 |
| '?' should be on a new line. | 85 |
| Avoid inline conditionals. | 85 |
| ':' should be on a new line. | 86 |
| '+' should be on a new line. | 96 |
| '+' should be on a new line. | 97 |
| '4' is a magic number. | 106 |
| '+' should be on a new line. | 108 |
| '+' should be on a new line. | 109 |
| '+' should be on a new line. | 110 |
| '+' should be on a new line. | 111 |
org/apache/giraph/comm/netty/handler/RequestInfo.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 29 |
| First sentence should end with a period. | 33 |
| First sentence should end with a period. | 35 |
| First sentence should end with a period. | 37 |
| First sentence should end with a period. | 39 |
| First sentence should end with a period. | 41 |
| Parameter destinationAddress should be final. | 50 |
| 'destinationAddress' hides a field. | 50 |
| Parameter request should be final. | 51 |
| 'request' hides a field. | 51 |
| Method 'getDestinationAddress' is not designed for extension - needs to be abstract, final or empty. | 57 |
| Missing a Javadoc comment. | 57 |
| Method 'getStartedMsecs' is not designed for extension - needs to be abstract, final or empty. | 66 |
| Method 'getElapsedNanos' is not designed for extension - needs to be abstract, final or empty. | 75 |
| Method 'getElapsedMsecs' is not designed for extension - needs to be abstract, final or empty. | 84 |
| Method 'getRequest' is not designed for extension - needs to be abstract, final or empty. | 89 |
| Missing a Javadoc comment. | 89 |
| Method 'setWriteFuture' is not designed for extension - needs to be abstract, final or empty. | 93 |
| Missing a Javadoc comment. | 93 |
| Parameter writeFuture should be final. | 93 |
| 'writeFuture' hides a field. | 93 |
| Method 'getWriteFuture' is not designed for extension - needs to be abstract, final or empty. | 97 |
| Missing a Javadoc comment. | 97 |
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 101 |
| '+' should be on a new line. | 103 |
| '+' should be on a new line. | 104 |
| '+' should be on a new line. | 105 |
| '+' should be on a new line. | 106 |
| '+' should be on a new line. | 107 |
| '+' should be on a new line. | 108 |
| Avoid inline conditionals. | 109 |
| ':' should be on a new line. | 109 |
| '+' should be on a new line. | 110 |
org/apache/giraph/comm/netty/handler/RequestServerHandler.java
| Violation | Message | Line |
|---|---|---|
| Line is longer than 80 characters. | 36 |
| First sentence should end with a period. | 45 |
| First sentence should end with a period. | 47 |
| Name 'TIME' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 48 |
| First sentence should end with a period. | 49 |
| Name 'ALREADY_CLOSED_FIRST_REQUEST' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 53 |
| First sentence should end with a period. | 54 |
| First sentence should end with a period. | 56 |
| First sentence should end with a period. | 58 |
| First sentence should end with a period. | 60 |
| First sentence should end with a period. | 63 |
| Parameter workerRequestReservedMap should be final. | 71 |
| 'workerRequestReservedMap' hides a field. | 71 |
| Parameter conf should be final. | 72 |
| Parameter myTaskInfo should be final. | 73 |
| 'myTaskInfo' hides a field. | 73 |
| Method 'messageReceived' is not designed for extension - needs to be abstract, final or empty. | 79 |
| Parameter ctx should be final. | 81 |
| Parameter e should be final. | 81 |
| '+' should be on a new line. | 90 |
| '+' should be on a new line. | 91 |
| '+' should be on a new line. | 108 |
| '+' should be on a new line. | 109 |
| '+' should be on a new line. | 110 |
| '+' should be on a new line. | 111 |
| '+' should be on a new line. | 116 |
| '+' should be on a new line. | 117 |
| '+' should be on a new line. | 118 |
| '+' should be on a new line. | 119 |
| First sentence should end with a period. | 131 |
| Method 'channelConnected' is not designed for extension - needs to be abstract, final or empty. | 138 |
| Parameter ctx should be final. | 139 |
| Parameter e should be final. | 140 |
| '+' should be on a new line. | 142 |
| Method 'channelClosed' is not designed for extension - needs to be abstract, final or empty. | 147 |
| Parameter ctx should be final. | 148 |
| Parameter e should be final. | 149 |
| '+' should be on a new line. | 151 |
| '+' should be on a new line. | 152 |
| Method 'exceptionCaught' is not designed for extension - needs to be abstract, final or empty. | 157 |
| Parameter ctx should be final. | 158 |
| Parameter e should be final. | 158 |
| '+' should be on a new line. | 159 |
| First sentence should end with a period. | 163 |
| First sentence should end with a period. | 167 |
org/apache/giraph/comm/netty/handler/ResponseClientHandler.java
| Violation | Message | Line |
|---|---|---|
| Line is longer than 80 characters. | 34 |
| First sentence should end with a period. | 40 |
| Name 'ALREADY_DROPPED_FIRST_RESPONSE' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 44 |
| First sentence should end with a period. | 45 |
| First sentence should end with a period. | 47 |
| Parameter workerIdOutstandingRequestMap should be final. | 59 |
| 'workerIdOutstandingRequestMap' hides a field. | 60 |
| Parameter conf should be final. | 61 |
| Method 'messageReceived' is not designed for extension - needs to be abstract, final or empty. | 66 |
| Parameter ctx should be final. | 68 |
| Parameter event should be final. | 68 |
| '+' should be on a new line. | 70 |
| '+' should be on a new line. | 91 |
| '+' should be on a new line. | 110 |
| '+' should be on a new line. | 114 |
| '+' should be on a new line. | 115 |
| Method 'channelClosed' is not designed for extension - needs to be abstract, final or empty. | 126 |
| Parameter ctx should be final. | 127 |
| Parameter e should be final. | 128 |
| '+' should be on a new line. | 130 |
| Method 'exceptionCaught' is not designed for extension - needs to be abstract, final or empty. | 135 |
| Parameter ctx should be final. | 136 |
| Parameter e should be final. | 136 |
| '+' should be on a new line. | 137 |
org/apache/giraph/comm/netty/handler/ResponseEncoder.java
| Violation | Message | Line |
|---|---|---|
| '4' is a magic number. | 40 |
| Method 'encode' is not designed for extension - needs to be abstract, final or empty. | 42 |
| Parameter ctx should be final. | 43 |
| Parameter channel should be final. | 44 |
| Parameter msg should be final. | 44 |
| '+' should be on a new line. | 51 |
| '+' should be on a new line. | 52 |
| '10' is a magic number. | 60 |
| '4' is a magic number. | 77 |
| '+' should be on a new line. | 90 |
| '+' should be on a new line. | 91 |
org/apache/giraph/comm/netty/handler/SaslClientHandler.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 46 |
| First sentence should end with a period. | 48 |
| Parameter conf should be final. | 56 |
| 'conf' hides a field. | 56 |
| Method 'handleUpstream' is not designed for extension - needs to be abstract, final or empty. | 60 |
| Parameter ctx should be final. | 62 |
| Parameter evt should be final. | 62 |
| '+' should be on a new line. | 74 |
| '+' should be on a new line. | 79 |
| '+' should be on a new line. | 86 |
| '+' should be on a new line. | 88 |
| '+' should be on a new line. | 89 |
| '+' should be on a new line. | 103 |
| '+' should be on a new line. | 113 |
| '+' should be on a new line. | 117 |
| '+' should be on a new line. | 123 |
| Method 'decode' is not designed for extension - needs to be abstract, final or empty. | 134 |
| Parameter ctx should be final. | 135 |
| Parameter channel should be final. | 136 |
| Parameter msg should be final. | 136 |
| '+' should be on a new line. | 150 |
org/apache/giraph/comm/netty/handler/SaslServerHandler.java
| Violation | Message | Line |
|---|---|---|
| Line is longer than 80 characters. | 47 |
| First sentence should end with a period. | 55 |
| Comment matches to-do format 'TODO:'. | 59 |
| Name 'ALREADY_CLOSED_FIRST_REQUEST' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 62 |
| First sentence should end with a period. | 64 |
| First sentence should end with a period. | 69 |
| Parameter conf should be final. | 75 |
| Expected @throws tag for 'IOException'. | 75 |
| Method 'messageReceived' is not designed for extension - needs to be abstract, final or empty. | 81 |
| Parameter ctx should be final. | 83 |
| Parameter e should be final. | 83 |
| Comment matches to-do format 'TODO:'. | 90 |
| '+' should be on a new line. | 92 |
| '+' should be on a new line. | 93 |
| '+' should be on a new line. | 108 |
| '+' should be on a new line. | 116 |
| '+' should be on a new line. | 117 |
| '+' should be on a new line. | 129 |
| '+' should be on a new line. | 135 |
| '+' should be on a new line. | 149 |
| Parameter conf should be final. | 161 |
| Expected @throws tag for 'IOException'. | 161 |
| '+' should be on a new line. | 166 |
| '+' should be on a new line. | 167 |
| '+' should be on a new line. | 191 |
| Parameter token should be final. | 210 |
| Parameter cls should be final. | 211 |
| Expected @throws tag for 'IOException'. | 211 |
| First sentence should end with a period. | 220 |
| First sentence should end with a period. | 222 |
| First sentence should end with a period. | 227 |
| Method 'newHandler' is not designed for extension - needs to be abstract, final or empty. | 233 |
| Parameter conf should be final. | 234 |
| Expected @throws tag for 'IOException'. | 234 |
org/apache/giraph/comm/netty/handler/WorkerRequestReservedMap.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 30 |
| First sentence should end with a period. | 34 |
| First sentence should end with a period. | 38 |
| Parameter conf should be final. | 43 |
| Method 'reserveRequest' is not designed for extension - needs to be abstract, final or empty. | 57 |
| Parameter workerId should be final. | 57 |
| Parameter requestId should be final. | 57 |
| Parameter workerId should be final. | 68 |
org/apache/giraph/comm/netty/handler/WorkerRequestServerHandler.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 28 |
| First sentence should end with a period. | 39 |
| First sentence should end with a period. | 42 |
| Parameter serverData should be final. | 50 |
| 'serverData' hides a field. | 50 |
| Parameter workerRequestReservedMap should be final. | 51 |
| Parameter conf should be final. | 52 |
| Parameter myTaskInfo should be final. | 53 |
| Method 'processRequest' is not designed for extension - needs to be abstract, final or empty. | 58 |
| Parameter request should be final. | 59 |
| First sentence should end with a period. | 63 |
| First sentence should end with a period. | 67 |
| First sentence should end with a period. | 70 |
| Parameter serverData should be final. | 75 |
| 'serverData' hides a field. | 75 |
| Method 'newHandler' is not designed for extension - needs to be abstract, final or empty. | 79 |
| Parameter workerRequestReservedMap should be final. | 81 |
| Parameter conf should be final. | 82 |
| Parameter myTaskInfo should be final. | 83 |
org/apache/giraph/comm/requests/ByteArrayRequest.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 27 |
| First sentence should end with a period. | 31 |
| First sentence should end with a period. | 34 |
| Parameter data should be final. | 39 |
| 'data' hides a field. | 39 |
| First sentence should end with a period. | 43 |
| First sentence should end with a period. | 49 |
| Method 'getData' is not designed for extension - needs to be abstract, final or empty. | 54 |
| First sentence should end with a period. | 58 |
| Method 'getDataInput' is not designed for extension - needs to be abstract, final or empty. | 63 |
| Method 'readFieldsRequest' is not designed for extension - needs to be abstract, final or empty. | 67 |
| Parameter input should be final. | 68 |
| Method 'writeRequest' is not designed for extension - needs to be abstract, final or empty. | 74 |
| Parameter output should be final. | 75 |
| Method 'getSerializedSize' is not designed for extension - needs to be abstract, final or empty. | 80 |
| '4' is a magic number. | 83 |
org/apache/giraph/comm/requests/ByteArrayWithSenderTaskIdRequest.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 25 |
| First sentence should end with a period. | 31 |
| First sentence should end with a period. | 34 |
| Parameter data should be final. | 40 |
| Parameter senderTaskId should be final. | 40 |
| 'senderTaskId' hides a field. | 40 |
| First sentence should end with a period. | 45 |
| Method 'getSenderTaskId' is not designed for extension - needs to be abstract, final or empty. | 51 |
| Missing a Javadoc comment. | 51 |
| Method 'writeRequest' is not designed for extension - needs to be abstract, final or empty. | 55 |
| Parameter output should be final. | 56 |
| Method 'readFieldsRequest' is not designed for extension - needs to be abstract, final or empty. | 61 |
| Parameter input should be final. | 62 |
| Method 'getSerializedSize' is not designed for extension - needs to be abstract, final or empty. | 67 |
| '4' is a magic number. | 69 |
org/apache/giraph/comm/requests/MasterRequest.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 23 |
| First sentence should end with a period. | 27 |
org/apache/giraph/comm/requests/RequestType.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 21 |
| First sentence should end with a period. | 27 |
| First sentence should end with a period. | 35 |
| First sentence should end with a period. | 37 |
| First sentence should end with a period. | 39 |
| First sentence should end with a period. | 45 |
| First sentence should end with a period. | 47 |
| First sentence should end with a period. | 49 |
| First sentence should end with a period. | 51 |
| First sentence should end with a period. | 53 |
| First sentence should end with a period. | 55 |
| First sentence should end with a period. | 58 |
| First sentence should end with a period. | 61 |
| Parameter requestClass should be final. | 66 |
| 'requestClass' hides a field. | 66 |
| First sentence should end with a period. | 70 |
org/apache/giraph/comm/requests/SaslCompleteRequest.java
| Violation | Message | Line |
|---|---|---|
| Method 'getType' is not designed for extension - needs to be abstract, final or empty. | 35 |
| Parameter input should be final. | 41 |
| Parameter output should be final. | 45 |
org/apache/giraph/comm/requests/SaslTokenMessageRequest.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 31 |
| Parameter token should be final. | 48 |
| 'token' hides a field. | 48 |
| First sentence should end with a period. | 52 |
| Method 'getSaslToken' is not designed for extension - needs to be abstract, final or empty. | 57 |
| First sentence should end with a period. | 61 |
| Method 'setSaslToken' is not designed for extension - needs to be abstract, final or empty. | 66 |
| Parameter token should be final. | 66 |
| 'token' hides a field. | 66 |
| Method 'getType' is not designed for extension - needs to be abstract, final or empty. | 70 |
| Method 'readFieldsRequest' is not designed for extension - needs to be abstract, final or empty. | 75 |
| Parameter input should be final. | 76 |
| Method 'processToken' is not designed for extension - needs to be abstract, final or empty. | 90 |
| Parameter saslNettyServer should be final. | 90 |
| '+' should be on a new line. | 92 |
| Method 'writeRequest' is not designed for extension - needs to be abstract, final or empty. | 101 |
| Parameter output should be final. | 102 |
| Method 'getSerializedSize' is not designed for extension - needs to be abstract, final or empty. | 107 |
| '4' is a magic number. | 109 |
org/apache/giraph/comm/requests/SendAggregatorsToMasterRequest.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 25 |
| First sentence should end with a period. | 32 |
| Parameter data should be final. | 37 |
| First sentence should end with a period. | 41 |
| Method 'doRequest' is not designed for extension - needs to be abstract, final or empty. | 47 |
| Parameter aggregatorHandler should be final. | 48 |
| '+' should be on a new line. | 52 |
| Method 'getType' is not designed for extension - needs to be abstract, final or empty. | 57 |
org/apache/giraph/comm/requests/SendAggregatorsToOwnerRequest.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 31 |
| First sentence should end with a period. | 38 |
| Parameter data should be final. | 44 |
| Parameter senderTaskId should be final. | 44 |
| First sentence should end with a period. | 48 |
| Method 'doRequest' is not designed for extension - needs to be abstract, final or empty. | 54 |
| Parameter serverData should be final. | 55 |
| '+' should be on a new line. | 82 |
| Method 'getType' is not designed for extension - needs to be abstract, final or empty. | 88 |
org/apache/giraph/comm/requests/SendAggregatorsToWorkerRequest.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 31 |
| First sentence should end with a period. | 38 |
| Parameter data should be final. | 44 |
| Parameter senderTaskId should be final. | 44 |
| First sentence should end with a period. | 48 |
| Method 'doRequest' is not designed for extension - needs to be abstract, final or empty. | 54 |
| Parameter serverData should be final. | 55 |
| '+' should be on a new line. | 80 |
| Method 'getType' is not designed for extension - needs to be abstract, final or empty. | 86 |
org/apache/giraph/comm/requests/SendPartitionCurrentMessagesRequest.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 41 |
| First sentence should end with a period. | 43 |
| First sentence should end with a period. | 46 |
| Parameter partitionId should be final. | 55 |
| 'partitionId' hides a field. | 55 |
| Parameter vertexIdMessages should be final. | 56 |
| Method 'getType' is not designed for extension - needs to be abstract, final or empty. | 62 |
| Method 'readFieldsRequest' is not designed for extension - needs to be abstract, final or empty. | 67 |
| Parameter input should be final. | 68 |
| Method 'writeRequest' is not designed for extension - needs to be abstract, final or empty. | 79 |
| Parameter output should be final. | 80 |
| Method 'doRequest' is not designed for extension - needs to be abstract, final or empty. | 85 |
| Parameter serverData should be final. | 86 |
| Method 'getSerializedSize' is not designed for extension - needs to be abstract, final or empty. | 95 |
| '4' is a magic number. | 97 |
| '+' should be on a new line. | 97 |
org/apache/giraph/comm/requests/SendPartitionMutationsRequest.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 50 |
| First sentence should end with a period. | 53 |
| First sentence should end with a period. | 55 |
| First sentence should end with a period. | 58 |
| Parameter partitionId should be final. | 70 |
| 'partitionId' hides a field. | 70 |
| Parameter vertexIdMutations should be final. | 71 |
| 'vertexIdMutations' hides a field. | 71 |
| Method 'readFieldsRequest' is not designed for extension - needs to be abstract, final or empty. | 76 |
| Parameter input should be final. | 77 |
| Method 'writeRequest' is not designed for extension - needs to be abstract, final or empty. | 95 |
| Parameter output should be final. | 96 |
| ':' should be on a new line. | 99 |
| Method 'getType' is not designed for extension - needs to be abstract, final or empty. | 106 |
| Method 'doRequest' is not designed for extension - needs to be abstract, final or empty. | 111 |
| Parameter serverData should be final. | 112 |
| ':' should be on a new line. | 118 |
| Method 'getSerializedSize' is not designed for extension - needs to be abstract, final or empty. | 135 |
org/apache/giraph/comm/requests/SendVertexRequest.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 42 |
| First sentence should end with a period. | 45 |
| First sentence should end with a period. | 48 |
| Parameter partition should be final. | 58 |
| 'partition' hides a field. | 58 |
| Method 'readFieldsRequest' is not designed for extension - needs to be abstract, final or empty. | 62 |
| Parameter input should be final. | 63 |
| Method 'writeRequest' is not designed for extension - needs to be abstract, final or empty. | 68 |
| Parameter output should be final. | 69 |
| Method 'getType' is not designed for extension - needs to be abstract, final or empty. | 73 |
| Method 'doRequest' is not designed for extension - needs to be abstract, final or empty. | 78 |
| Parameter serverData should be final. | 79 |
| Method 'getSerializedSize' is not designed for extension - needs to be abstract, final or empty. | 83 |
org/apache/giraph/comm/requests/SendWorkerAggregatorsRequest.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 30 |
| First sentence should end with a period. | 37 |
| Parameter data should be final. | 43 |
| Parameter senderTaskId should be final. | 43 |
| First sentence should end with a period. | 47 |
| Method 'doRequest' is not designed for extension - needs to be abstract, final or empty. | 53 |
| Parameter serverData should be final. | 54 |
| '+' should be on a new line. | 76 |
| Method 'getType' is not designed for extension - needs to be abstract, final or empty. | 82 |
org/apache/giraph/comm/requests/SendWorkerDataRequest.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 41 |
| Variable 'partitionVertexData' must be private and have accessor methods. | 49 |
| First sentence should end with a period. | 51 |
| Parameter partVertData should be final. | 63 |
| Method 'readFieldsRequest' is not designed for extension - needs to be abstract, final or empty. | 74 |
| Parameter input should be final. | 75 |
| Method 'writeRequest' is not designed for extension - needs to be abstract, final or empty. | 88 |
| Parameter output should be final. | 89 |
| Method 'getSerializedSize' is not designed for extension - needs to be abstract, final or empty. | 100 |
| '4' is a magic number. | 102 |
| '4' is a magic number. | 106 |
org/apache/giraph/comm/requests/SendWorkerEdgesRequest.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 39 |
| Parameter partVertEdges should be final. | 51 |
| Method 'createByteArrayVertexIdData' is not designed for extension - needs to be abstract, final or empty. | 55 |
| Method 'getType' is not designed for extension - needs to be abstract, final or empty. | 60 |
| Method 'doRequest' is not designed for extension - needs to be abstract, final or empty. | 65 |
| Parameter serverData should be final. | 66 |
org/apache/giraph/comm/requests/SendWorkerMessagesRequest.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 39 |
| Parameter partVertMsgs should be final. | 51 |
| Method 'createByteArrayVertexIdData' is not designed for extension - needs to be abstract, final or empty. | 55 |
| Method 'getType' is not designed for extension - needs to be abstract, final or empty. | 61 |
| Method 'doRequest' is not designed for extension - needs to be abstract, final or empty. | 66 |
| Parameter serverData should be final. | 67 |
org/apache/giraph/comm/requests/WorkerRequest.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 25 |
| First sentence should end with a period. | 34 |
org/apache/giraph/comm/requests/WritableRequest.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 29 |
| First sentence should end with a period. | 39 |
| First sentence should end with a period. | 45 |
| First sentence should end with a period. | 47 |
| First sentence should end with a period. | 49 |
| Method 'getClientId' is not designed for extension - needs to be abstract, final or empty. | 52 |
| Missing a Javadoc comment. | 52 |
| Method 'setClientId' is not designed for extension - needs to be abstract, final or empty. | 56 |
| Missing a Javadoc comment. | 56 |
| Parameter clientId should be final. | 56 |
| 'clientId' hides a field. | 56 |
| Method 'getRequestId' is not designed for extension - needs to be abstract, final or empty. | 60 |
| Missing a Javadoc comment. | 60 |
| Method 'setRequestId' is not designed for extension - needs to be abstract, final or empty. | 64 |
| Missing a Javadoc comment. | 64 |
| Parameter requestId should be final. | 64 |
| 'requestId' hides a field. | 64 |
| Method 'getSerializedSize' is not designed for extension - needs to be abstract, final or empty. | 77 |
| '4' is a magic number. | 79 |
| '8' is a magic number. | 79 |
| First sentence should end with a period. | 82 |
| First sentence should end with a period. | 89 |
| Expected @throws tag for 'IOException'. | 94 |
| First sentence should end with a period. | 96 |
| Expected @throws tag for 'IOException'. | 101 |
| Parameter conf should be final. | 109 |
| 'conf' hides a field. | 109 |
| Parameter input should be final. | 114 |
| Parameter output should be final. | 121 |
org/apache/giraph/conf/AbstractConfOption.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 25 |
| First sentence should end with a period. | 30 |
| First sentence should end with a period. | 33 |
| First sentence should end with a period. | 36 |
| Parameter key should be final. | 40 |
| 'key' hides a field. | 40 |
| Method 'getKey' is not designed for extension - needs to be abstract, final or empty. | 44 |
| Missing a Javadoc comment. | 44 |
| Method 'compareTo' is not designed for extension - needs to be abstract, final or empty. | 48 |
| Parameter o should be final. | 48 |
| Method 'equals' is not designed for extension - needs to be abstract, final or empty. | 55 |
| Parameter o should be final. | 56 |
| '&&' should be on a new line. | 65 |
| Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. | 69 |
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 74 |
| '30' is a magic number. | 75 |
| First sentence should end with a period. | 81 |
| First sentence should end with a period. | 87 |
org/apache/giraph/conf/AllOptions.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 29 |
| Class AllOptions should be declared as final. | 32 |
| First sentence should end with a period. | 33 |
| First sentence should end with a period. | 36 |
| First sentence should end with a period. | 40 |
| Parameter confOption should be final. | 48 |
| First sentence should end with a period. | 52 |
| '30' is a magic number. | 58 |
| First sentence should end with a period. | 71 |
| Parameter args should be final. | 75 |
org/apache/giraph/conf/BooleanConfOption.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 22 |
| First sentence should end with a period. | 26 |
| First sentence should end with a period. | 29 |
| Parameter key should be final. | 34 |
| Parameter defaultValue should be final. | 34 |
| 'defaultValue' hides a field. | 34 |
| Method 'isDefaultValue' is not designed for extension - needs to be abstract, final or empty. | 40 |
| Missing a Javadoc comment. | 40 |
| Method 'getDefaultValueStr' is not designed for extension - needs to be abstract, final or empty. | 44 |
| Method 'getType' is not designed for extension - needs to be abstract, final or empty. | 48 |
| First sentence should end with a period. | 52 |
| Method 'get' is not designed for extension - needs to be abstract, final or empty. | 57 |
| Parameter conf should be final. | 57 |
| First sentence should end with a period. | 61 |
| Method 'isFalse' is not designed for extension - needs to be abstract, final or empty. | 66 |
| Parameter conf should be final. | 66 |
| First sentence should end with a period. | 70 |
| Method 'isTrue' is not designed for extension - needs to be abstract, final or empty. | 75 |
| Parameter conf should be final. | 75 |
| First sentence should end with a period. | 79 |
| Method 'set' is not designed for extension - needs to be abstract, final or empty. | 84 |
| Parameter conf should be final. | 84 |
| Parameter value should be final. | 84 |
| First sentence should end with a period. | 88 |
| Method 'setIfUnset' is not designed for extension - needs to be abstract, final or empty. | 93 |
| Parameter conf should be final. | 93 |
| Parameter value should be final. | 93 |
org/apache/giraph/conf/ClassConfOption.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 23 |
| Class ClassConfOption should be declared as final. | 27 |
| First sentence should end with a period. | 28 |
| First sentence should end with a period. | 31 |
| First sentence should end with a period. | 33 |
| First sentence should end with a period. | 36 |
| Parameter key should be final. | 42 |
| Parameter defaultClass should be final. | 42 |
| 'defaultClass' hides a field. | 42 |
| Parameter interfaceClass should be final. | 43 |
| 'interfaceClass' hides a field. | 43 |
| First sentence should end with a period. | 50 |
| Parameter key should be final. | 58 |
| Parameter defaultClass should be final. | 59 |
| Parameter interfaceClass should be final. | 59 |
| Missing a Javadoc comment. | 63 |
| Missing a Javadoc comment. | 67 |
| Avoid inline conditionals. | 72 |
| '30' is a magic number. | 80 |
| First sentence should end with a period. | 88 |
| Parameter conf should be final. | 93 |
| First sentence should end with a period. | 97 |
| Parameter conf should be final. | 102 |
| Parameter conf should be final. | 116 |
| Parameter name should be final. | 117 |
| Parameter xface should be final. | 117 |
| Parameter defaultValue should be final. | 117 |
| '+' should be on a new line. | 121 |
| First sentence should end with a period. | 128 |
| Parameter conf should be final. | 134 |
| Parameter defaultValue should be final. | 135 |
| First sentence should end with a period. | 139 |
| Parameter conf should be final. | 144 |
| Parameter klass should be final. | 144 |
| First sentence should end with a period. | 148 |
| Parameter conf should be final. | 153 |
| Parameter klasses should be final. | 153 |
| '+' should be on a new line. | 158 |
| First sentence should end with a period. | 166 |
| Parameter conf should be final. | 171 |
| Parameter klass should be final. | 171 |
| Parameter conf should be final. | 185 |
| Parameter name should be final. | 185 |
| Parameter klass should be final. | 186 |
| Parameter xface should be final. | 186 |
| '+' should be on a new line. | 188 |
org/apache/giraph/conf/ConfOptionType.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 20 |
| First sentence should end with a period. | 24 |
| First sentence should end with a period. | 26 |
| First sentence should end with a period. | 28 |
| First sentence should end with a period. | 30 |
| First sentence should end with a period. | 32 |
| First sentence should end with a period. | 34 |
org/apache/giraph/conf/DefaultImmutableClassesGiraphConfigurable.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 24 |
| First sentence should end with a period. | 35 |
| Method 'setConf' is not designed for extension - needs to be abstract, final or empty. | 38 |
| Parameter conf should be final. | 39 |
| 'conf' hides a field. | 39 |
| Method 'getConf' is not designed for extension - needs to be abstract, final or empty. | 43 |
org/apache/giraph/conf/FloatConfOption.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 22 |
| First sentence should end with a period. | 26 |
| First sentence should end with a period. | 29 |
| Parameter key should be final. | 34 |
| Parameter defaultValue should be final. | 34 |
| 'defaultValue' hides a field. | 34 |
| Method 'getDefaultValue' is not designed for extension - needs to be abstract, final or empty. | 40 |
| Missing a Javadoc comment. | 40 |
| Method 'getDefaultValueStr' is not designed for extension - needs to be abstract, final or empty. | 44 |
| Method 'getType' is not designed for extension - needs to be abstract, final or empty. | 48 |
| First sentence should end with a period. | 52 |
| Method 'get' is not designed for extension - needs to be abstract, final or empty. | 57 |
| Parameter conf should be final. | 57 |
| First sentence should end with a period. | 61 |
| Method 'set' is not designed for extension - needs to be abstract, final or empty. | 66 |
| Parameter conf should be final. | 66 |
| Parameter value should be final. | 66 |
| First sentence should end with a period. | 70 |
| Method 'setIfUnset' is not designed for extension - needs to be abstract, final or empty. | 75 |
| Parameter conf should be final. | 75 |
| Parameter value should be final. | 75 |
org/apache/giraph/conf/GiraphClasses.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 63 |
| Variable 'computationClass' must be private and have accessor methods. | 66 |
| First sentence should end with a period. | 67 |
| Variable 'vertexIdClass' must be private and have accessor methods. | 68 |
| First sentence should end with a period. | 69 |
| Variable 'vertexValueClass' must be private and have accessor methods. | 70 |
| First sentence should end with a period. | 71 |
| Variable 'edgeValueClass' must be private and have accessor methods. | 72 |
| First sentence should end with a period. | 73 |
| Variable 'incomingMessageValueClass' must be private and have accessor methods. | 74 |
| First sentence should end with a period. | 75 |
| Variable 'outgoingMessageValueClass' must be private and have accessor methods. | 76 |
| First sentence should end with a period. | 77 |
| Variable 'outEdgesClass' must be private and have accessor methods. | 78 |
| First sentence should end with a period. | 79 |
| Variable 'inputOutEdgesClass' must be private and have accessor methods. | 80 |
| First sentence should end with a period. | 82 |
| Variable 'vertexValueFactoryClass' must be private and have accessor methods. | 83 |
| First sentence should end with a period. | 85 |
| Variable 'graphPartitionerFactoryClass' must be private and have accessor methods. | 87 |
| First sentence should end with a period. | 89 |
| Variable 'vertexInputFormatClass' must be private and have accessor methods. | 91 |
| First sentence should end with a period. | 92 |
| Variable 'vertexOutputFormatClass' must be private and have accessor methods. | 94 |
| First sentence should end with a period. | 95 |
| Variable 'edgeInputFormatClass' must be private and have accessor methods. | 97 |
| First sentence should end with a period. | 99 |
| Variable 'aggregatorWriterClass' must be private and have accessor methods. | 100 |
| First sentence should end with a period. | 101 |
| Variable 'combinerClass' must be private and have accessor methods. | 102 |
| First sentence should end with a period. | 104 |
| Variable 'vertexResolverClass' must be private and have accessor methods. | 105 |
| First sentence should end with a period. | 106 |
| Variable 'workerContextClass' must be private and have accessor methods. | 107 |
| First sentence should end with a period. | 108 |
| Variable 'masterComputeClass' must be private and have accessor methods. | 109 |
| First sentence should end with a period. | 111 |
| Variable 'partitionClass' must be private and have accessor methods. | 112 |
| First sentence should end with a period. | 114 |
| Variable 'edgeInputFilterClass' must be private and have accessor methods. | 115 |
| First sentence should end with a period. | 116 |
| Variable 'vertexInputFilterClass' must be private and have accessor methods. | 118 |
| Parameter conf should be final. | 153 |
| Parameter conf should be final. | 162 |
| '3' is a magic number. | 173 |
| '4' is a magic number. | 174 |
| First sentence should end with a period. | 210 |
| Method 'getComputationClass' is not designed for extension - needs to be abstract, final or empty. | 215 |
| First sentence should end with a period. | 221 |
| Method 'getVertexIdClass' is not designed for extension - needs to be abstract, final or empty. | 226 |
| First sentence should end with a period. | 230 |
| Method 'getVertexValueClass' is not designed for extension - needs to be abstract, final or empty. | 235 |
| First sentence should end with a period. | 239 |
| Method 'getEdgeValueClass' is not designed for extension - needs to be abstract, final or empty. | 244 |
| First sentence should end with a period. | 248 |
| Method 'getIncomingMessageValueClass' is not designed for extension - needs to be abstract, final or empty. | 254 |
| First sentence should end with a period. | 258 |
| Method 'getOutgoingMessageValueClass' is not designed for extension - needs to be abstract, final or empty. | 264 |
| First sentence should end with a period. | 268 |
| Method 'getOutEdgesClass' is not designed for extension - needs to be abstract, final or empty. | 273 |
| Method 'getInputOutEdgesClass' is not designed for extension - needs to be abstract, final or empty. | 281 |
| Missing a Javadoc comment. | 281 |
| First sentence should end with a period. | 286 |
| Method 'getVertexValueFactoryClass' is not designed for extension - needs to be abstract, final or empty. | 291 |
| First sentence should end with a period. | 295 |
| Method 'getGraphPartitionerFactoryClass' is not designed for extension - needs to be abstract, final or empty. | 300 |
| Method 'getEdgeInputFilterClass' is not designed for extension - needs to be abstract, final or empty. | 305 |
| Missing a Javadoc comment. | 305 |
| Method 'getVertexInputFilterClass' is not designed for extension - needs to be abstract, final or empty. | 310 |
| Missing a Javadoc comment. | 310 |
| First sentence should end with a period. | 315 |
| Method 'hasVertexInputFormat' is not designed for extension - needs to be abstract, final or empty. | 320 |
| First sentence should end with a period. | 324 |
| Method 'getVertexInputFormatClass' is not designed for extension - needs to be abstract, final or empty. | 329 |
| First sentence should end with a period. | 334 |
| Method 'hasVertexOutputFormat' is not designed for extension - needs to be abstract, final or empty. | 339 |
| First sentence should end with a period. | 343 |
| Method 'getVertexOutputFormatClass' is not designed for extension - needs to be abstract, final or empty. | 348 |
| First sentence should end with a period. | 353 |
| Method 'hasEdgeInputFormat' is not designed for extension - needs to be abstract, final or empty. | 358 |
| First sentence should end with a period. | 362 |
| Method 'getEdgeInputFormatClass' is not designed for extension - needs to be abstract, final or empty. | 367 |
| First sentence should end with a period. | 371 |
| Method 'hasAggregatorWriterClass' is not designed for extension - needs to be abstract, final or empty. | 376 |
| First sentence should end with a period. | 380 |
| Method 'getAggregatorWriterClass' is not designed for extension - needs to be abstract, final or empty. | 385 |
| First sentence should end with a period. | 389 |
| Method 'hasCombinerClass' is not designed for extension - needs to be abstract, final or empty. | 394 |
| First sentence should end with a period. | 398 |
| Method 'getCombinerClass' is not designed for extension - needs to be abstract, final or empty. | 403 |
| First sentence should end with a period. | 407 |
| Method 'hasVertexResolverClass' is not designed for extension - needs to be abstract, final or empty. | 412 |
| First sentence should end with a period. | 416 |
| Method 'getVertexResolverClass' is not designed for extension - needs to be abstract, final or empty. | 421 |
| First sentence should end with a period. | 425 |
| Method 'hasWorkerContextClass' is not designed for extension - needs to be abstract, final or empty. | 430 |
| First sentence should end with a period. | 434 |
| Method 'getWorkerContextClass' is not designed for extension - needs to be abstract, final or empty. | 439 |
| First sentence should end with a period. | 443 |
| Method 'hasMasterComputeClass' is not designed for extension - needs to be abstract, final or empty. | 448 |
| First sentence should end with a period. | 452 |
| Method 'getMasterComputeClass' is not designed for extension - needs to be abstract, final or empty. | 457 |
| First sentence should end with a period. | 461 |
| Method 'hasPartitionClass' is not designed for extension - needs to be abstract, final or empty. | 466 |
| First sentence should end with a period. | 470 |
| Method 'getPartitionClass' is not designed for extension - needs to be abstract, final or empty. | 475 |
| First sentence should end with a period. | 479 |
| Method 'setComputationClass' is not designed for extension - needs to be abstract, final or empty. | 485 |
| Parameter computationClass should be final. | 485 |
| 'computationClass' hides a field. | 487 |
| '3' is a magic number. | 491 |
| '4' is a magic number. | 492 |
| First sentence should end with a period. | 496 |
| Method 'setVertexIdClass' is not designed for extension - needs to be abstract, final or empty. | 502 |
| Parameter vertexIdClass should be final. | 502 |
| 'vertexIdClass' hides a field. | 502 |
| First sentence should end with a period. | 507 |
| Method 'setVertexValueClass' is not designed for extension - needs to be abstract, final or empty. | 513 |
| Parameter vertexValueClass should be final. | 513 |
| 'vertexValueClass' hides a field. | 513 |
| First sentence should end with a period. | 518 |
| Method 'setEdgeValueClass' is not designed for extension - needs to be abstract, final or empty. | 524 |
| Parameter edgeValueClass should be final. | 524 |
| 'edgeValueClass' hides a field. | 524 |
| First sentence should end with a period. | 529 |
| Method 'setIncomingMessageValueClass' is not designed for extension - needs to be abstract, final or empty. | 536 |
| Parameter incomingMessageValueClass should be final. | 537 |
| 'incomingMessageValueClass' hides a field. | 537 |
| First sentence should end with a period. | 542 |
| Method 'setOutgoingMessageValueClass' is not designed for extension - needs to be abstract, final or empty. | 549 |
| Parameter outgoingMessageValueClass should be final. | 550 |
| 'outgoingMessageValueClass' hides a field. | 550 |
| First sentence should end with a period. | 555 |
| Method 'setOutEdgesClass' is not designed for extension - needs to be abstract, final or empty. | 561 |
| Parameter outEdgesClass should be final. | 562 |
| 'outEdgesClass' hides a field. | 562 |
| First sentence should end with a period. | 568 |
| Method 'setInputOutEdgesClass' is not designed for extension - needs to be abstract, final or empty. | 575 |
| Parameter inputOutEdgesClass should be final. | 576 |
| 'inputOutEdgesClass' hides a field. | 576 |
| First sentence should end with a period. | 582 |
| Method 'setVertexValueFactoryClass' is not designed for extension - needs to be abstract, final or empty. | 588 |
| Parameter vertexValueFactoryClass should be final. | 589 |
| 'vertexValueFactoryClass' hides a field. | 589 |
| First sentence should end with a period. | 595 |
| Method 'setGraphPartitionerFactoryClass' is not designed for extension - needs to be abstract, final or empty. | 601 |
| Parameter klass should be final. | 602 |
| First sentence should end with a period. | 607 |
| Method 'setVertexInputFormatClass' is not designed for extension - needs to be abstract, final or empty. | 613 |
| Parameter vertexInputFormatClass should be final. | 614 |
| 'vertexInputFormatClass' hides a field. | 614 |
| First sentence should end with a period. | 619 |
| Method 'setVertexOutputFormatClass' is not designed for extension - needs to be abstract, final or empty. | 625 |
| Parameter vertexOutputFormatClass should be final. | 626 |
| 'vertexOutputFormatClass' hides a field. | 626 |
| First sentence should end with a period. | 631 |
| Method 'setEdgeInputFormatClass' is not designed for extension - needs to be abstract, final or empty. | 637 |
| Parameter edgeInputFormatClass should be final. | 638 |
| 'edgeInputFormatClass' hides a field. | 638 |
| First sentence should end with a period. | 643 |
| Method 'setAggregatorWriterClass' is not designed for extension - needs to be abstract, final or empty. | 649 |
| Parameter aggregatorWriterClass should be final. | 650 |
| 'aggregatorWriterClass' hides a field. | 650 |
| First sentence should end with a period. | 655 |
| Method 'setCombinerClass' is not designed for extension - needs to be abstract, final or empty. | 661 |
| Parameter combinerClass should be final. | 662 |
| 'combinerClass' hides a field. | 662 |
| First sentence should end with a period. | 667 |
| Method 'setVertexResolverClass' is not designed for extension - needs to be abstract, final or empty. | 673 |
| Parameter vertexResolverClass should be final. | 674 |
| 'vertexResolverClass' hides a field. | 674 |
| First sentence should end with a period. | 679 |
| Method 'setWorkerContextClass' is not designed for extension - needs to be abstract, final or empty. | 685 |
| Parameter workerContextClass should be final. | 686 |
| 'workerContextClass' hides a field. | 686 |
| First sentence should end with a period. | 691 |
| Method 'setMasterComputeClass' is not designed for extension - needs to be abstract, final or empty. | 697 |
| Parameter masterComputeClass should be final. | 698 |
| 'masterComputeClass' hides a field. | 698 |
| First sentence should end with a period. | 703 |
| Method 'setPartitionClass' is not designed for extension - needs to be abstract, final or empty. | 709 |
| Parameter partitionClass should be final. | 710 |
| 'partitionClass' hides a field. | 710 |
org/apache/giraph/conf/GiraphConfiguration.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 58 |
| First sentence should end with a period. | 61 |
| Parameter conf should be final. | 74 |
| First sentence should end with a period. | 80 |
| Method 'getComputationClass' is not designed for extension - needs to be abstract, final or empty. | 85 |
| First sentence should end with a period. | 89 |
| Method 'setComputationClass' is not designed for extension - needs to be abstract, final or empty. | 94 |
| Parameter computationClass should be final. | 95 |
| First sentence should end with a period. | 99 |
| Parameter vertexValueFactoryClass should be final. | 105 |
| First sentence should end with a period. | 109 |
| Method 'setEdgeInputFilterClass' is not designed for extension - needs to be abstract, final or empty. | 114 |
| Parameter edgeFilterClass should be final. | 115 |
| First sentence should end with a period. | 119 |
| Method 'setVertexInputFilterClass' is not designed for extension - needs to be abstract, final or empty. | 124 |
| Parameter vertexFilterClass should be final. | 125 |
| First sentence should end with a period. | 129 |
| Method 'getOutEdgesClass' is not designed for extension - needs to be abstract, final or empty. | 134 |
| First sentence should end with a period. | 138 |
| Parameter outEdgesClass should be final. | 144 |
| First sentence should end with a period. | 148 |
| Parameter inputOutEdgesClass should be final. | 155 |
| Method 'reuseEdgeObjects' is not designed for extension - needs to be abstract, final or empty. | 170 |
| Method 'reuseVertexObjects' is not designed for extension - needs to be abstract, final or empty. | 184 |
| First sentence should end with a period. | 188 |
| Method 'getPartitionClass' is not designed for extension - needs to be abstract, final or empty. | 192 |
| Method 'hasVertexInputFormat' is not designed for extension - needs to be abstract, final or empty. | 201 |
| First sentence should end with a period. | 205 |
| Method 'setVertexInputFormatClass' is not designed for extension - needs to be abstract, final or empty. | 210 |
| Parameter vertexInputFormatClass should be final. | 211 |
| Method 'hasEdgeInputFormat' is not designed for extension - needs to be abstract, final or empty. | 220 |
| First sentence should end with a period. | 224 |
| Method 'setEdgeInputFormatClass' is not designed for extension - needs to be abstract, final or empty. | 229 |
| Parameter edgeInputFormatClass should be final. | 230 |
| First sentence should end with a period. | 234 |
| Parameter masterComputeClass should be final. | 240 |
| First sentence should end with a period. | 244 |
| Parameter masterObserverClass should be final. | 250 |
| First sentence should end with a period. | 254 |
| Parameter workerObserverClass should be final. | 260 |
| First sentence should end with a period. | 264 |
| Method 'getJobObserverClass' is not designed for extension - needs to be abstract, final or empty. | 269 |
| First sentence should end with a period. | 273 |
| Method 'setJobObserverClass' is not designed for extension - needs to be abstract, final or empty. | 278 |
| Parameter klass should be final. | 278 |
| Method 'isJMapHistogramDumpEnabled' is not designed for extension - needs to be abstract, final or empty. | 287 |
| Parameter name should be final. | 298 |
| Parameter xface should be final. | 298 |
| Parameter klasses should be final. | 299 |
| '+' should be on a new line. | 304 |
| Method 'hasVertexOutputFormat' is not designed for extension - needs to be abstract, final or empty. | 317 |
| First sentence should end with a period. | 321 |
| Parameter vertexOutputFormatClass should be final. | 327 |
| First sentence should end with a period. | 331 |
| First sentence should end with a period. | 340 |
| Parameter doOutputDuringComputation should be final. | 347 |
| First sentence should end with a period. | 351 |
| First sentence should end with a period. | 360 |
| Parameter vertexOutputFormatThreadSafe should be final. | 367 |
| Method 'setNumOutputThreads' is not designed for extension - needs to be abstract, final or empty. | 391 |
| Parameter numOutputThreads should be final. | 391 |
| First sentence should end with a period. | 395 |
| Method 'getCombinerClass' is not designed for extension - needs to be abstract, final or empty. | 400 |
| First sentence should end with a period. | 404 |
| Method 'setCombinerClass' is not designed for extension - needs to be abstract, final or empty. | 409 |
| Parameter vertexCombinerClass should be final. | 410 |
| First sentence should end with a period. | 414 |
| Parameter graphPartitionerFactoryClass should be final. | 420 |
| First sentence should end with a period. | 424 |
| Parameter vertexResolverClass should be final. | 430 |
| Parameter v should be final. | 449 |
| First sentence should end with a period. | 453 |
| Parameter workerContextClass should be final. | 460 |
| First sentence should end with a period. | 464 |
| Parameter aggregatorWriterClass should be final. | 471 |
| First sentence should end with a period. | 475 |
| Parameter partitionClass should be final. | 481 |
| Parameter minWorkers should be final. | 495 |
| Parameter maxWorkers should be final. | 496 |
| Parameter minPercentResponded should be final. | 497 |
| Missing a Javadoc comment. | 503 |
| Missing a Javadoc comment. | 507 |
| Missing a Javadoc comment. | 511 |
| Parameter serverList should be final. | 522 |
| Method 'getMasterObserverClasses' is not designed for extension - needs to be abstract, final or empty. | 539 |
| Method 'getWorkerObserverClasses' is not designed for extension - needs to be abstract, final or empty. | 548 |
| Method 'metricsEnabled' is not designed for extension - needs to be abstract, final or empty. | 557 |
| First sentence should end with a period. | 561 |
| Method 'getTaskPartition' is not designed for extension - needs to be abstract, final or empty. | 566 |
| Method 'isPureYarnJob' is not designed for extension - needs to be abstract, final or empty. | 575 |
| Method 'getYarnLibJars' is not designed for extension - needs to be abstract, final or empty. | 584 |
| Method 'setYarnLibJars' is not designed for extension - needs to be abstract, final or empty. | 592 |
| Parameter jarList should be final. | 592 |
| Method 'getYarnTaskHeapMb' is not designed for extension - needs to be abstract, final or empty. | 601 |
| Method 'setYarnTaskHeapMb' is not designed for extension - needs to be abstract, final or empty. | 610 |
| Parameter heapMb should be final. | 610 |
| Method 'getZookeeperList' is not designed for extension - needs to be abstract, final or empty. | 619 |
| Method 'getLocalLevel' is not designed for extension - needs to be abstract, final or empty. | 623 |
| Missing a Javadoc comment. | 623 |
| Method 'useLogThreadLayout' is not designed for extension - needs to be abstract, final or empty. | 632 |
| Method 'getLocalTestMode' is not designed for extension - needs to be abstract, final or empty. | 640 |
| Method 'setLocalTestMode' is not designed for extension - needs to be abstract, final or empty. | 648 |
| Parameter flag should be final. | 648 |
| Method 'getZooKeeperServerCount' is not designed for extension - needs to be abstract, final or empty. | 657 |
| First sentence should end with a period. | 661 |
| Method 'setZooKeeperJar' is not designed for extension - needs to be abstract, final or empty. | 666 |
| Parameter classPath should be final. | 666 |
| Method 'getZooKeeperSessionTimeout' is not designed for extension - needs to be abstract, final or empty. | 670 |
| Missing a Javadoc comment. | 670 |
| Method 'getZookeeperOpsMaxAttempts' is not designed for extension - needs to be abstract, final or empty. | 674 |
| Missing a Javadoc comment. | 674 |
| Method 'getZookeeperOpsRetryWaitMsecs' is not designed for extension - needs to be abstract, final or empty. | 678 |
| Missing a Javadoc comment. | 678 |
| Method 'getNettyServerUseExecutionHandler' is not designed for extension - needs to be abstract, final or empty. | 682 |
| Missing a Javadoc comment. | 682 |
| Method 'getNettyServerThreads' is not designed for extension - needs to be abstract, final or empty. | 686 |
| Missing a Javadoc comment. | 686 |
| Method 'getNettyServerExecutionThreads' is not designed for extension - needs to be abstract, final or empty. | 690 |
| Missing a Javadoc comment. | 690 |
| Method 'getNettyServerExecutionConcurrency' is not designed for extension - needs to be abstract, final or empty. | 700 |
| Method 'getZookeeperConnectionAttempts' is not designed for extension - needs to be abstract, final or empty. | 708 |
| Missing a Javadoc comment. | 708 |
| Method 'getZooKeeperMinSessionTimeout' is not designed for extension - needs to be abstract, final or empty. | 712 |
| Missing a Javadoc comment. | 712 |
| Method 'getZooKeeperMaxSessionTimeout' is not designed for extension - needs to be abstract, final or empty. | 716 |
| Missing a Javadoc comment. | 716 |
| Method 'getZooKeeperForceSync' is not designed for extension - needs to be abstract, final or empty. | 720 |
| Missing a Javadoc comment. | 720 |
| Method 'getZooKeeperSkipAcl' is not designed for extension - needs to be abstract, final or empty. | 724 |
| Missing a Javadoc comment. | 724 |
| First sentence should end with a period. | 728 |
| Method 'getMapTasks' is not designed for extension - needs to be abstract, final or empty. | 733 |
| '+' should be on a new line. | 736 |
| Method 'authenticate' is not designed for extension - needs to be abstract, final or empty. | 747 |
| First sentence should end with a period. | 751 |
| Method 'setNumComputeThreads' is not designed for extension - needs to be abstract, final or empty. | 756 |
| Parameter numComputeThreads should be final. | 756 |
| Method 'getNumComputeThreads' is not designed for extension - needs to be abstract, final or empty. | 760 |
| Missing a Javadoc comment. | 760 |
| First sentence should end with a period. | 764 |
| Method 'setNumInputSplitsThreads' is not designed for extension - needs to be abstract, final or empty. | 769 |
| Parameter numInputSplitsThreads should be final. | 769 |
| Method 'getNumInputSplitsThreads' is not designed for extension - needs to be abstract, final or empty. | 773 |
| Missing a Javadoc comment. | 773 |
| Method 'getInputSplitMaxVertices' is not designed for extension - needs to be abstract, final or empty. | 777 |
| Missing a Javadoc comment. | 777 |
| Method 'getInputSplitMaxEdges' is not designed for extension - needs to be abstract, final or empty. | 781 |
| Missing a Javadoc comment. | 781 |
| First sentence should end with a period. | 785 |
| Method 'useUnsafeSerialization' is not designed for extension - needs to be abstract, final or empty. | 790 |
| Parameter useUnsafeSerialization should be final. | 790 |
| Method 'useMessageSizeEncoding' is not designed for extension - needs to be abstract, final or empty. | 800 |
| First sentence should end with a period. | 804 |
| Method 'setCheckpointFrequency' is not designed for extension - needs to be abstract, final or empty. | 810 |
| Parameter checkpointFrequency should be final. | 810 |
| First sentence should end with a period. | 814 |
| Method 'getCheckpointFrequency' is not designed for extension - needs to be abstract, final or empty. | 820 |
| First sentence should end with a period. | 824 |
| Method 'useCheckpointing' is not designed for extension - needs to be abstract, final or empty. | 829 |
| First sentence should end with a period. | 833 |
| Method 'setMaxTaskAttempts' is not designed for extension - needs to be abstract, final or empty. | 838 |
| Parameter maxTaskAttempts should be final. | 838 |
| First sentence should end with a period. | 842 |
| Method 'getMaxTaskAttempts' is not designed for extension - needs to be abstract, final or empty. | 847 |
| First sentence should end with a period. | 851 |
| Method 'getEventWaitMsecs' is not designed for extension - needs to be abstract, final or empty. | 856 |
| First sentence should end with a period. | 860 |
| Method 'setEventWaitMsecs' is not designed for extension - needs to be abstract, final or empty. | 866 |
| Parameter eventWaitMsecs should be final. | 866 |
| Method 'getMaxMasterSuperstepWaitMsecs' is not designed for extension - needs to be abstract, final or empty. | 877 |
| Method 'setMaxMasterSuperstepWaitMsecs' is not designed for extension - needs to be abstract, final or empty. | 889 |
| Parameter maxMasterSuperstepWaitMsecs should be final. | 889 |
| Method 'configureHadoopSecurity' is not designed for extension - needs to be abstract, final or empty. | 897 |
| Method 'useInputSplitLocality' is not designed for extension - needs to be abstract, final or empty. | 909 |
| Method 'getLocalHostname' is not designed for extension - needs to be abstract, final or empty. | 919 |
| Expected @throws tag for 'UnknownHostException'. | 919 |
| Method 'setMaxNumberOfSupersteps' is not designed for extension - needs to be abstract, final or empty. | 931 |
| Parameter maxNumberOfSupersteps should be final. | 931 |
| Method 'getMaxNumberOfSupersteps' is not designed for extension - needs to be abstract, final or empty. | 941 |
| Method 'isStaticGraph' is not designed for extension - needs to be abstract, final or empty. | 950 |
| First sentence should end with a period. | 954 |
| Method 'updateConfiguration' is not designed for extension - needs to be abstract, final or empty. | 959 |
| Parameter conf should be final. | 959 |
| Method 'set' is not designed for extension - needs to be abstract, final or empty. | 967 |
| Parameter name should be final. | 968 |
| Parameter value should be final. | 968 |
| Method 'setIfUnset' is not designed for extension - needs to be abstract, final or empty. | 973 |
| Parameter name should be final. | 974 |
| Parameter value should be final. | 974 |
| Method 'setInt' is not designed for extension - needs to be abstract, final or empty. | 979 |
| Parameter name should be final. | 980 |
| Parameter value should be final. | 980 |
| Method 'setLong' is not designed for extension - needs to be abstract, final or empty. | 985 |
| Parameter name should be final. | 986 |
| Parameter value should be final. | 986 |
| Method 'setFloat' is not designed for extension - needs to be abstract, final or empty. | 991 |
| Parameter name should be final. | 992 |
| Parameter value should be final. | 992 |
| Method 'setBoolean' is not designed for extension - needs to be abstract, final or empty. | 997 |
| Parameter name should be final. | 998 |
| Parameter value should be final. | 998 |
| Method 'setBooleanIfUnset' is not designed for extension - needs to be abstract, final or empty. | 1003 |
| Parameter name should be final. | 1004 |
| Parameter value should be final. | 1004 |
| Method 'setClass' is not designed for extension - needs to be abstract, final or empty. | 1009 |
| Parameter name should be final. | 1010 |
| Parameter theClass should be final. | 1010 |
| Parameter xface should be final. | 1010 |
| First sentence should end with a period. | 1015 |
| Method 'getYourKitOutputDir' is not designed for extension - needs to be abstract, final or empty. | 1020 |
| Parameter context should be final. | 1020 |
| Method 'getStringVars' is not designed for extension - needs to be abstract, final or empty. | 1042 |
| Parameter key should be final. | 1042 |
| Parameter context should be final. | 1042 |
| Method 'getStringVars' is not designed for extension - needs to be abstract, final or empty. | 1059 |
| Parameter key should be final. | 1059 |
| Parameter defaultValue should be final. | 1059 |
| Parameter context should be final. | 1060 |
org/apache/giraph/conf/GiraphConstants.java
| Violation | Message | Line |
|---|---|---|
| interfaces should describe a type and hence have methods. | 59 |
| First sentence should end with a period. | 60 |
| First sentence should end with a period. | 63 |
| First sentence should end with a period. | 67 |
| First sentence should end with a period. | 71 |
| First sentence should end with a period. | 75 |
| First sentence should end with a period. | 80 |
| First sentence should end with a period. | 84 |
| First sentence should end with a period. | 88 |
| First sentence should end with a period. | 92 |
| First sentence should end with a period. | 95 |
| First sentence should end with a period. | 100 |
| First sentence should end with a period. | 106 |
| First sentence should end with a period. | 111 |
| First sentence should end with a period. | 117 |
| First sentence should end with a period. | 121 |
| First sentence should end with a period. | 126 |
| First sentence should end with a period. | 131 |
| First sentence should end with a period. | 136 |
| First sentence should end with a period. | 156 |
| First sentence should end with a period. | 160 |
| First sentence should end with a period. | 163 |
| First sentence should end with a period. | 165 |
| First sentence should end with a period. | 167 |
| First sentence should end with a period. | 170 |
| First sentence should end with a period. | 176 |
| First sentence should end with a period. | 180 |
| First sentence should end with a period. | 183 |
| First sentence should end with a period. | 186 |
| First sentence should end with a period. | 190 |
| First sentence should end with a period. | 194 |
| First sentence should end with a period. | 198 |
| First sentence should end with a period. | 203 |
| First sentence should end with a period. | 208 |
| First sentence should end with a period. | 224 |
| First sentence should end with a period. | 235 |
| First sentence should end with a period. | 239 |
| First sentence should end with a period. | 243 |
| First sentence should end with a period. | 254 |
| First sentence should end with a period. | 258 |
| First sentence should end with a period. | 264 |
| First sentence should end with a period. | 268 |
| First sentence should end with a period. | 272 |
| First sentence should end with a period. | 276 |
| First sentence should end with a period. | 280 |
| First sentence should end with a period. | 283 |
| First sentence should end with a period. | 286 |
| First sentence should end with a period. | 296 |
| First sentence should end with a period. | 303 |
| First sentence should end with a period. | 308 |
| First sentence should end with a period. | 312 |
| First sentence should end with a period. | 320 |
| First sentence should end with a period. | 333 |
| First sentence should end with a period. | 342 |
| First sentence should end with a period. | 346 |
| First sentence should end with a period. | 350 |
| First sentence should end with a period. | 354 |
| First sentence should end with a period. | 358 |
| First sentence should end with a period. | 370 |
| First sentence should end with a period. | 374 |
| First sentence should end with a period. | 378 |
| First sentence should end with a period. | 382 |
| First sentence should end with a period. | 385 |
| First sentence should end with a period. | 392 |
| First sentence should end with a period. | 396 |
| First sentence should end with a period. | 400 |
| First sentence should end with a period. | 404 |
| First sentence should end with a period. | 408 |
| First sentence should end with a period. | 422 |
| First sentence should end with a period. | 433 |
| First sentence should end with a period. | 437 |
| First sentence should end with a period. | 444 |
| First sentence should end with a period. | 448 |
| First sentence should end with a period. | 451 |
| First sentence should end with a period. | 455 |
| First sentence should end with a period. | 459 |
| First sentence should end with a period. | 502 |
| First sentence should end with a period. | 506 |
| First sentence should end with a period. | 510 |
| First sentence should end with a period. | 515 |
| '+' should be on a new line. | 518 |
| First sentence should end with a period. | 547 |
| First sentence should end with a period. | 570 |
| First sentence should end with a period. | 594 |
| First sentence should end with a period. | 596 |
| First sentence should end with a period. | 617 |
| First sentence should end with a period. | 620 |
| First sentence should end with a period. | 623 |
| First sentence should end with a period. | 626 |
| First sentence should end with a period. | 649 |
| First sentence should end with a period. | 652 |
org/apache/giraph/conf/ImmutableClassesGiraphConfigurable.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 24 |
org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 78 |
| Parameter conf should be final. | 95 |
| '+' should be on a new line. | 104 |
| '+' should be on a new line. | 108 |
| Method 'configureIfPossible' is not designed for extension - needs to be abstract, final or empty. | 118 |
| Parameter obj should be final. | 118 |
| First sentence should end with a period. | 124 |
| Method 'getEdgeInputFilterClass' is not designed for extension - needs to be abstract, final or empty. | 129 |
| First sentence should end with a period. | 134 |
| Method 'getEdgeInputFilter' is not designed for extension - needs to be abstract, final or empty. | 138 |
| First sentence should end with a period. | 142 |
| Method 'getVertexInputFilterClass' is not designed for extension - needs to be abstract, final or empty. | 147 |
| First sentence should end with a period. | 152 |
| Method 'getVertexInputFilter' is not designed for extension - needs to be abstract, final or empty. | 156 |
| Method 'getGraphPartitionerClass' is not designed for extension - needs to be abstract, final or empty. | 166 |
| First sentence should end with a period. | 171 |
| Method 'createGraphPartitioner' is not designed for extension - needs to be abstract, final or empty. | 176 |
| Method 'hasVertexInputFormat' is not designed for extension - needs to be abstract, final or empty. | 182 |
| Method 'getVertexInputFormatClass' is not designed for extension - needs to be abstract, final or empty. | 193 |
| Method 'createWrappedVertexInputFormat' is not designed for extension - needs to be abstract, final or empty. | 218 |
| Method 'setVertexInputFormatClass' is not designed for extension - needs to be abstract, final or empty. | 225 |
| Parameter vertexInputFormatClass should be final. | 227 |
| Method 'hasVertexOutputFormat' is not designed for extension - needs to be abstract, final or empty. | 232 |
| Method 'getVertexOutputFormatClass' is not designed for extension - needs to be abstract, final or empty. | 243 |
| Method 'createWrappedVertexOutputFormat' is not designed for extension - needs to be abstract, final or empty. | 268 |
| Method 'createSuperstepOutput' is not designed for extension - needs to be abstract, final or empty. | 281 |
| Parameter context should be final. | 282 |
| Method 'hasEdgeInputFormat' is not designed for extension - needs to be abstract, final or empty. | 294 |
| Method 'getEdgeInputFormatClass' is not designed for extension - needs to be abstract, final or empty. | 305 |
| Method 'createWrappedEdgeInputFormat' is not designed for extension - needs to be abstract, final or empty. | 328 |
| Method 'setEdgeInputFormatClass' is not designed for extension - needs to be abstract, final or empty. | 335 |
| Parameter edgeInputFormatClass should be final. | 337 |
| Method 'getAggregatorWriterClass' is not designed for extension - needs to be abstract, final or empty. | 347 |
| First sentence should end with a period. | 351 |
| Method 'createAggregatorWriter' is not designed for extension - needs to be abstract, final or empty. | 356 |
| Method 'getCombinerClass' is not designed for extension - needs to be abstract, final or empty. | 365 |
| First sentence should end with a period. | 369 |
| Method 'createCombiner' is not designed for extension - needs to be abstract, final or empty. | 375 |
| First sentence should end with a period. | 381 |
| Method 'useCombiner' is not designed for extension - needs to be abstract, final or empty. | 386 |
| Method 'getVertexResolverClass' is not designed for extension - needs to be abstract, final or empty. | 395 |
| First sentence should end with a period. | 399 |
| Method 'createVertexResolver' is not designed for extension - needs to be abstract, final or empty. | 404 |
| Method 'getWorkerContextClass' is not designed for extension - needs to be abstract, final or empty. | 413 |
| First sentence should end with a period. | 417 |
| Method 'createWorkerContext' is not designed for extension - needs to be abstract, final or empty. | 422 |
| First sentence should end with a period. | 426 |
| Method 'getMasterComputeClass' is not designed for extension - needs to be abstract, final or empty. | 431 |
| First sentence should end with a period. | 435 |
| Method 'createMasterCompute' is not designed for extension - needs to be abstract, final or empty. | 440 |
| Method 'getComputationClass' is not designed for extension - needs to be abstract, final or empty. | 444 |
| First sentence should end with a period. | 451 |
| Method 'createComputation' is not designed for extension - needs to be abstract, final or empty. | 456 |
| First sentence should end with a period. | 461 |
| Method 'createVertex' is not designed for extension - needs to be abstract, final or empty. | 466 |
| Method 'getVertexIdClass' is not designed for extension - needs to be abstract, final or empty. | 475 |
| First sentence should end with a period. | 479 |
| Method 'createVertexId' is not designed for extension - needs to be abstract, final or empty. | 484 |
| Method 'getVertexValueClass' is not designed for extension - needs to be abstract, final or empty. | 501 |
| First sentence should end with a period. | 505 |
| Method 'createVertexValue' is not designed for extension - needs to be abstract, final or empty. | 510 |
| First sentence should end with a period. | 515 |
| Method 'getVertexValueFactoryClass' is not designed for extension - needs to be abstract, final or empty. | 520 |
| Method 'createMasterObservers' is not designed for extension - needs to be abstract, final or empty. | 529 |
| Method 'createWorkerObservers' is not designed for extension - needs to be abstract, final or empty. | 543 |
| First sentence should end with a period. | 552 |
| Method 'getJobObserver' is not designed for extension - needs to be abstract, final or empty. | 556 |
| Method 'getEdgeValueClass' is not designed for extension - needs to be abstract, final or empty. | 565 |
| Method 'isEdgeValueNullWritable' is not designed for extension - needs to be abstract, final or empty. | 574 |
| First sentence should end with a period. | 578 |
| Method 'createEdgeValue' is not designed for extension - needs to be abstract, final or empty. | 583 |
| Method 'createEdge' is not designed for extension - needs to be abstract, final or empty. | 605 |
| Method 'createReusableEdge' is not designed for extension - needs to be abstract, final or empty. | 618 |
| Method 'getIncomingMessageValueClass' is not designed for extension - needs to be abstract, final or empty. | 632 |
| Method 'getOutgoingMessageValueClass' is not designed for extension - needs to be abstract, final or empty. | 642 |
| First sentence should end with a period. | 646 |
| Method 'createIncomingMessageValue' is not designed for extension - needs to be abstract, final or empty. | 652 |
| First sentence should end with a period. | 656 |
| Method 'createOutgoingMessageValue' is not designed for extension - needs to be abstract, final or empty. | 662 |
| First sentence should end with a period. | 666 |
| Parameter messageClass should be final. | 674 |
| Method 'getOutEdgesClass' is not designed for extension - needs to be abstract, final or empty. | 682 |
| First sentence should end with a period. | 687 |
| Method 'getInputOutEdgesClass' is not designed for extension - needs to be abstract, final or empty. | 693 |
| Method 'useInputOutEdges' is not designed for extension - needs to be abstract, final or empty. | 704 |
| First sentence should end with a period. | 708 |
| Method 'createOutEdges' is not designed for extension - needs to be abstract, final or empty. | 713 |
| Method 'createAndInitializeOutEdges' is not designed for extension - needs to be abstract, final or empty. | 723 |
| Method 'createAndInitializeOutEdges' is not designed for extension - needs to be abstract, final or empty. | 736 |
| Parameter capacity should be final. | 736 |
| Method 'createAndInitializeOutEdges' is not designed for extension - needs to be abstract, final or empty. | 749 |
| Parameter edges should be final. | 750 |
| First sentence should end with a period. | 756 |
| Method 'createInputOutEdges' is not designed for extension - needs to be abstract, final or empty. | 762 |
| Method 'createAndInitializeInputOutEdges' is not designed for extension - needs to be abstract, final or empty. | 772 |
| First sentence should end with a period. | 778 |
| Method 'createPartition' is not designed for extension - needs to be abstract, final or empty. | 785 |
| Parameter id should be final. | 786 |
| Parameter progressable should be final. | 786 |
| Method 'useUnsafeSerialization' is not designed for extension - needs to be abstract, final or empty. | 798 |
| First sentence should end with a period. | 802 |
| Method 'createExtendedDataOutput' is not designed for extension - needs to be abstract, final or empty. | 807 |
| First sentence should end with a period. | 815 |
| Method 'createExtendedDataOutput' is not designed for extension - needs to be abstract, final or empty. | 821 |
| Parameter expectedSize should be final. | 821 |
| First sentence should end with a period. | 829 |
| Method 'createExtendedDataOutput' is not designed for extension - needs to be abstract, final or empty. | 836 |
| Parameter buf should be final. | 836 |
| Parameter pos should be final. | 837 |
| First sentence should end with a period. | 845 |
| Method 'createExtendedDataInput' is not designed for extension - needs to be abstract, final or empty. | 853 |
| Parameter buf should be final. | 854 |
| Parameter off should be final. | 854 |
| Parameter length should be final. | 854 |
| First sentence should end with a period. | 862 |
| Method 'updateSuperstepClasses' is not designed for extension - needs to be abstract, final or empty. | 867 |
| Parameter superstepClasses should be final. | 867 |
org/apache/giraph/conf/IntConfOption.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 22 |
| First sentence should end with a period. | 26 |
| First sentence should end with a period. | 29 |
| Parameter key should be final. | 34 |
| Parameter defaultValue should be final. | 34 |
| 'defaultValue' hides a field. | 34 |
| First sentence should end with a period. | 40 |
| Parameter key should be final. | 45 |
| Parameter defaultValue should be final. | 45 |
| 'defaultValue' hides a field. | 45 |
| Method 'getDefaultValue' is not designed for extension - needs to be abstract, final or empty. | 51 |
| Missing a Javadoc comment. | 51 |
| Method 'getDefaultValueStr' is not designed for extension - needs to be abstract, final or empty. | 55 |
| Method 'getType' is not designed for extension - needs to be abstract, final or empty. | 59 |
| First sentence should end with a period. | 63 |
| Method 'get' is not designed for extension - needs to be abstract, final or empty. | 68 |
| Parameter conf should be final. | 68 |
| First sentence should end with a period. | 72 |
| Method 'set' is not designed for extension - needs to be abstract, final or empty. | 77 |
| Parameter conf should be final. | 77 |
| Parameter value should be final. | 77 |
| First sentence should end with a period. | 81 |
| Method 'setIfUnset' is not designed for extension - needs to be abstract, final or empty. | 86 |
| Parameter conf should be final. | 86 |
| Parameter value should be final. | 86 |
org/apache/giraph/conf/LongConfOption.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 22 |
| First sentence should end with a period. | 26 |
| First sentence should end with a period. | 29 |
| Parameter key should be final. | 34 |
| Parameter defaultValue should be final. | 34 |
| 'defaultValue' hides a field. | 34 |
| Method 'getDefaultValue' is not designed for extension - needs to be abstract, final or empty. | 40 |
| Missing a Javadoc comment. | 40 |
| Method 'getDefaultValueStr' is not designed for extension - needs to be abstract, final or empty. | 44 |
| Method 'getType' is not designed for extension - needs to be abstract, final or empty. | 48 |
| First sentence should end with a period. | 52 |
| Method 'get' is not designed for extension - needs to be abstract, final or empty. | 57 |
| Parameter conf should be final. | 57 |
| First sentence should end with a period. | 61 |
| Method 'set' is not designed for extension - needs to be abstract, final or empty. | 66 |
| Parameter conf should be final. | 66 |
| Parameter value should be final. | 66 |
| First sentence should end with a period. | 70 |
| Method 'setIfUnset' is not designed for extension - needs to be abstract, final or empty. | 75 |
| Parameter conf should be final. | 75 |
| Parameter value should be final. | 75 |
org/apache/giraph/conf/StrConfOption.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 26 |
| First sentence should end with a period. | 30 |
| First sentence should end with a period. | 33 |
| Parameter key should be final. | 38 |
| Parameter defaultValue should be final. | 38 |
| 'defaultValue' hides a field. | 38 |
| Method 'getDefaultValue' is not designed for extension - needs to be abstract, final or empty. | 44 |
| Missing a Javadoc comment. | 44 |
| Method 'getDefaultValueStr' is not designed for extension - needs to be abstract, final or empty. | 48 |
| Method 'getType' is not designed for extension - needs to be abstract, final or empty. | 52 |
| First sentence should end with a period. | 56 |
| Method 'get' is not designed for extension - needs to be abstract, final or empty. | 61 |
| Parameter conf should be final. | 61 |
| First sentence should end with a period. | 65 |
| Method 'getWithDefault' is not designed for extension - needs to be abstract, final or empty. | 71 |
| Parameter conf should be final. | 71 |
| Parameter defaultVal should be final. | 71 |
| First sentence should end with a period. | 75 |
| Method 'getArray' is not designed for extension - needs to be abstract, final or empty. | 80 |
| Parameter conf should be final. | 80 |
| First sentence should end with a period. | 84 |
| Method 'getList' is not designed for extension - needs to be abstract, final or empty. | 89 |
| Parameter conf should be final. | 89 |
| First sentence should end with a period. | 93 |
| Method 'set' is not designed for extension - needs to be abstract, final or empty. | 98 |
| Parameter conf should be final. | 98 |
| Parameter value should be final. | 98 |
| First sentence should end with a period. | 102 |
| Method 'setIfUnset' is not designed for extension - needs to be abstract, final or empty. | 107 |
| Parameter conf should be final. | 107 |
| Parameter value should be final. | 107 |
org/apache/giraph/counters/GiraphHadoopCounter.java
| Violation | Message | Line |
|---|---|---|
| Parameter counter should be final. | 40 |
| 'counter' hides a field. | 40 |
| Method 'getHadoopCounter' is not designed for extension - needs to be abstract, final or empty. | 49 |
| Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. | 53 |
| Method 'equals' is not designed for extension - needs to be abstract, final or empty. | 58 |
| Parameter genericRight should be final. | 59 |
| Method 'setValue' is not designed for extension - needs to be abstract, final or empty. | 75 |
| Parameter value should be final. | 75 |
| Method 'increment' is not designed for extension - needs to be abstract, final or empty. | 82 |
| Method 'increment' is not designed for extension - needs to be abstract, final or empty. | 91 |
| Parameter incr should be final. | 91 |
| First sentence should end with a period. | 95 |
| Method 'getValue' is not designed for extension - needs to be abstract, final or empty. | 100 |
| Method 'getDisplayName' is not designed for extension - needs to be abstract, final or empty. | 109 |
| Method 'getName' is not designed for extension - needs to be abstract, final or empty. | 118 |
| Method 'write' is not designed for extension - needs to be abstract, final or empty. | 128 |
| Parameter out should be final. | 128 |
| Method 'readFields' is not designed for extension - needs to be abstract, final or empty. | 138 |
| Parameter in should be final. | 138 |
org/apache/giraph/counters/GiraphStats.java
| Violation | Message | Line |
|---|---|---|
| Class GiraphStats should be declared as final. | 29 |
| First sentence should end with a period. | 30 |
| First sentence should end with a period. | 32 |
| First sentence should end with a period. | 34 |
| First sentence should end with a period. | 36 |
| First sentence should end with a period. | 39 |
| First sentence should end with a period. | 41 |
| First sentence should end with a period. | 43 |
| First sentence should end with a period. | 45 |
| First sentence should end with a period. | 48 |
| First sentence should end with a period. | 52 |
| Name 'INSTANCE' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 53 |
| First sentence should end with a period. | 55 |
| First sentence should end with a period. | 57 |
| First sentence should end with a period. | 59 |
| First sentence should end with a period. | 61 |
| First sentence should end with a period. | 63 |
| First sentence should end with a period. | 65 |
| First sentence should end with a period. | 67 |
| First sentence should end with a period. | 69 |
| First sentence should end with a period. | 71 |
| First sentence should end with a period. | 74 |
| Parameter context should be final. | 82 |
| Parameter context should be final. | 102 |
| First sentence should end with a period. | 115 |
| First sentence should end with a period. | 124 |
| First sentence should end with a period. | 133 |
| First sentence should end with a period. | 142 |
| First sentence should end with a period. | 151 |
| First sentence should end with a period. | 160 |
| First sentence should end with a period. | 169 |
| First sentence should end with a period. | 178 |
org/apache/giraph/counters/GiraphTimers.java
| Violation | Message | Line |
|---|---|---|
| Class GiraphTimers should be declared as final. | 33 |
| First sentence should end with a period. | 34 |
| First sentence should end with a period. | 36 |
| First sentence should end with a period. | 38 |
| First sentence should end with a period. | 40 |
| First sentence should end with a period. | 43 |
| Name 'INSTANCE' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 44 |
| First sentence should end with a period. | 46 |
| First sentence should end with a period. | 48 |
| First sentence should end with a period. | 50 |
| First sentence should end with a period. | 52 |
| First sentence should end with a period. | 55 |
| First sentence should end with a period. | 58 |
| Parameter context should be final. | 66 |
| Parameter context should be final. | 80 |
| First sentence should end with a period. | 93 |
| First sentence should end with a period. | 102 |
| Parameter superstep should be final. | 108 |
org/apache/giraph/counters/HadoopCountersBase.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 28 |
| First sentence should end with a period. | 30 |
| Parameter context should be final. | 39 |
| 'context' hides a field. | 39 |
| Parameter groupName should be final. | 39 |
| 'groupName' hides a field. | 39 |
| First sentence should end with a period. | 44 |
| Method 'getContext' is not designed for extension - needs to be abstract, final or empty. | 49 |
| Method 'getCounter' is not designed for extension - needs to be abstract, final or empty. | 59 |
| Parameter name should be final. | 59 |
org/apache/giraph/edge/ArrayListEdges.java
| Violation | Message | Line |
|---|---|---|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 45 |
| Parameter edges should be final. | 46 |
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 57 |
| Parameter capacity should be final. | 58 |
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 62 |
| Method 'add' is not designed for extension - needs to be abstract, final or empty. | 67 |
| Parameter edge should be final. | 68 |
| Method 'remove' is not designed for extension - needs to be abstract, final or empty. | 72 |
| Parameter targetVertexId should be final. | 73 |
| Method 'size' is not designed for extension - needs to be abstract, final or empty. | 82 |
| Method 'mutableIterator' is not designed for extension - needs to be abstract, final or empty. | 92 |
| Method 'write' is not designed for extension - needs to be abstract, final or empty. | 100 |
| Parameter out should be final. | 101 |
| Method 'readFields' is not designed for extension - needs to be abstract, final or empty. | 109 |
| Parameter in should be final. | 110 |
org/apache/giraph/edge/ByteArrayEdges.java
| Violation | Message | Line |
|---|---|---|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 54 |
| Parameter edges should be final. | 55 |
| '+' should be on a new line. | 62 |
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 71 |
| Parameter capacity should be final. | 72 |
| Method 'add' is not designed for extension - needs to be abstract, final or empty. | 84 |
| Parameter edge should be final. | 85 |
| '+' should be on a new line. | 92 |
| Method 'remove' is not designed for extension - needs to be abstract, final or empty. | 100 |
| Parameter targetVertexId should be final. | 101 |
| Method 'size' is not designed for extension - needs to be abstract, final or empty. | 130 |
| First sentence should end with a period. | 140 |
| '+' should be on a new line. | 158 |
| Method 'iterator' is not designed for extension - needs to be abstract, final or empty. | 165 |
| Method 'readFields' is not designed for extension - needs to be abstract, final or empty. | 170 |
| Parameter in should be final. | 171 |
| '||' should be on a new line. | 175 |
| Method 'write' is not designed for extension - needs to be abstract, final or empty. | 184 |
| Parameter out should be final. | 185 |
org/apache/giraph/edge/DefaultEdge.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 34 |
| First sentence should end with a period. | 36 |
| First sentence should end with a period. | 39 |
| Parameter targetVertexId should be final. | 50 |
| 'targetVertexId' hides a field. | 50 |
| Parameter value should be final. | 50 |
| 'value' hides a field. | 50 |
| Method 'getTargetVertexId' is not designed for extension - needs to be abstract, final or empty. | 55 |
| Method 'getValue' is not designed for extension - needs to be abstract, final or empty. | 60 |
| Method 'setTargetVertexId' is not designed for extension - needs to be abstract, final or empty. | 65 |
| Parameter targetVertexId should be final. | 66 |
| 'targetVertexId' hides a field. | 66 |
| Method 'setValue' is not designed for extension - needs to be abstract, final or empty. | 70 |
| Parameter value should be final. | 71 |
| 'value' hides a field. | 71 |
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 75 |
| '+' should be on a new line. | 77 |
org/apache/giraph/edge/Edge.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 32 |
| First sentence should end with a period. | 39 |
org/apache/giraph/edge/EdgeFactory.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 25 |
| Class EdgeFactory should be declared as final. | 28 |
| First sentence should end with a period. | 29 |
| First sentence should end with a period. | 32 |
| Parameter id should be final. | 43 |
| Parameter value should be final. | 43 |
| First sentence should end with a period. | 47 |
| Parameter id should be final. | 55 |
| First sentence should end with a period. | 59 |
| Parameter id should be final. | 70 |
| Parameter value should be final. | 70 |
| First sentence should end with a period. | 78 |
| Parameter id should be final. | 86 |
org/apache/giraph/edge/EdgeNoValue.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 31 |
| First sentence should end with a period. | 34 |
| Parameter targetVertexId should be final. | 42 |
| 'targetVertexId' hides a field. | 42 |
| Method 'setTargetVertexId' is not designed for extension - needs to be abstract, final or empty. | 46 |
| Parameter targetVertexId should be final. | 47 |
| 'targetVertexId' hides a field. | 47 |
| Parameter value should be final. | 52 |
| Method 'getTargetVertexId' is not designed for extension - needs to be abstract, final or empty. | 56 |
| Method 'getValue' is not designed for extension - needs to be abstract, final or empty. | 61 |
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 66 |
org/apache/giraph/edge/EdgeStore.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 47 |
| Parameter service should be final. | 77 |
| 'service' hides a field. | 77 |
| Parameter configuration should be final. | 78 |
| 'configuration' hides a field. | 78 |
| Parameter progressable should be final. | 79 |
| 'progressable' hides a field. | 79 |
| Method 'addPartitionEdges' is not designed for extension - needs to be abstract, final or empty. | 96 |
| Parameter partitionId should be final. | 97 |
| Parameter edges should be final. | 97 |
| '?' should be on a new line. | 115 |
| Avoid inline conditionals. | 115 |
| ':' should be on a new line. | 116 |
| Parameter inputEdges should be final. | 144 |
| Method 'moveEdgesToVertices' is not designed for extension - needs to be abstract, final or empty. | 156 |
| Parameter callableId should be final. | 175 |
| '+' should be on a new line. | 219 |
org/apache/giraph/edge/HashMapEdges.java
| Violation | Message | Line |
|---|---|---|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 50 |
| Parameter edges should be final. | 51 |
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 55 |
| Parameter capacity should be final. | 56 |
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 60 |
| Method 'add' is not designed for extension - needs to be abstract, final or empty. | 65 |
| Parameter edge should be final. | 66 |
| Method 'remove' is not designed for extension - needs to be abstract, final or empty. | 70 |
| Parameter targetVertexId should be final. | 71 |
| Method 'getEdgeValue' is not designed for extension - needs to be abstract, final or empty. | 75 |
| Parameter targetVertexId should be final. | 76 |
| Method 'setEdgeValue' is not designed for extension - needs to be abstract, final or empty. | 80 |
| Parameter targetVertexId should be final. | 81 |
| Parameter edgeValue should be final. | 81 |
| Method 'size' is not designed for extension - needs to be abstract, final or empty. | 87 |
| Method 'iterator' is not designed for extension - needs to be abstract, final or empty. | 92 |
| Method 'mutableIterator' is not designed for extension - needs to be abstract, final or empty. | 100 |
| Method 'write' is not designed for extension - needs to be abstract, final or empty. | 128 |
| Parameter out should be final. | 129 |
| Method 'readFields' is not designed for extension - needs to be abstract, final or empty. | 137 |
| Parameter in should be final. | 138 |
org/apache/giraph/edge/HashMultimapEdges.java
| Violation | Message | Line |
|---|---|---|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 49 |
| Parameter edges should be final. | 50 |
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 61 |
| Parameter expectedNeighbors should be final. | 61 |
| Parameter expectedEdgesPerNeighbor should be final. | 61 |
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 66 |
| Parameter capacity should be final. | 67 |
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 73 |
| Method 'add' is not designed for extension - needs to be abstract, final or empty. | 78 |
| Parameter edge should be final. | 79 |
| Method 'remove' is not designed for extension - needs to be abstract, final or empty. | 83 |
| Parameter targetVertexId should be final. | 84 |
| Method 'getAllEdgeValues' is not designed for extension - needs to be abstract, final or empty. | 88 |
| Parameter targetVertexId should be final. | 89 |
| Method 'size' is not designed for extension - needs to be abstract, final or empty. | 93 |
| Method 'iterator' is not designed for extension - needs to be abstract, final or empty. | 98 |
| Method 'write' is not designed for extension - needs to be abstract, final or empty. | 124 |
| Parameter out should be final. | 125 |
| Method 'readFields' is not designed for extension - needs to be abstract, final or empty. | 136 |
| Parameter in should be final. | 137 |
| Avoid inline conditionals. | 142 |
org/apache/giraph/edge/IntNullArrayEdges.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 44 |
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 47 |
| Parameter edges should be final. | 48 |
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 52 |
| Parameter capacity should be final. | 53 |
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 57 |
| Method 'size' is not designed for extension - needs to be abstract, final or empty. | 62 |
| Method 'add' is not designed for extension - needs to be abstract, final or empty. | 67 |
| Parameter edge should be final. | 68 |
| Parameter i should be final. | 77 |
| Method 'remove' is not designed for extension - needs to be abstract, final or empty. | 88 |
| Parameter targetVertexId should be final. | 89 |
| Method 'iterator' is not designed for extension - needs to be abstract, final or empty. | 99 |
| Method 'write' is not designed for extension - needs to be abstract, final or empty. | 122 |
| Parameter out should be final. | 123 |
| Method 'readFields' is not designed for extension - needs to be abstract, final or empty. | 131 |
| Parameter in should be final. | 132 |
org/apache/giraph/edge/LongDoubleArrayEdges.java
| Violation | Message | Line |
|---|---|---|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 51 |
| Parameter edges should be final. | 52 |
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 56 |
| Parameter capacity should be final. | 57 |
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 62 |
| Method 'add' is not designed for extension - needs to be abstract, final or empty. | 68 |
| Parameter edge should be final. | 69 |
| '4' is a magic number. | 79 |
| Parameter i should be final. | 90 |
| Method 'remove' is not designed for extension - needs to be abstract, final or empty. | 105 |
| Parameter targetVertexId should be final. | 106 |
| Method 'size' is not designed for extension - needs to be abstract, final or empty. | 116 |
| Method 'iterator' is not designed for extension - needs to be abstract, final or empty. | 121 |
| Parameter index should be final. | 163 |
| 'index' hides a field. | 163 |
| Parameter value should be final. | 172 |
| Method 'mutableIterator' is not designed for extension - needs to be abstract, final or empty. | 180 |
| Method 'write' is not designed for extension - needs to be abstract, final or empty. | 211 |
| Parameter out should be final. | 212 |
| Method 'readFields' is not designed for extension - needs to be abstract, final or empty. | 222 |
| Parameter in should be final. | 223 |
org/apache/giraph/edge/LongDoubleHashMapEdges.java
| Violation | Message | Line |
|---|---|---|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 52 |
| Parameter edges should be final. | 53 |
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 57 |
| Parameter capacity should be final. | 58 |
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 62 |
| Method 'add' is not designed for extension - needs to be abstract, final or empty. | 67 |
| Parameter edge should be final. | 68 |
| Method 'remove' is not designed for extension - needs to be abstract, final or empty. | 72 |
| Parameter targetVertexId should be final. | 73 |
| Method 'getEdgeValue' is not designed for extension - needs to be abstract, final or empty. | 77 |
| Parameter targetVertexId should be final. | 78 |
| Method 'setEdgeValue' is not designed for extension - needs to be abstract, final or empty. | 89 |
| Parameter targetVertexId should be final. | 90 |
| Parameter edgeValue should be final. | 91 |
| Method 'size' is not designed for extension - needs to be abstract, final or empty. | 97 |
| Method 'iterator' is not designed for extension - needs to be abstract, final or empty. | 102 |
| Parameter entry should be final. | 144 |
| 'entry' hides a field. | 144 |
| Parameter value should be final. | 153 |
| Method 'mutableIterator' is not designed for extension - needs to be abstract, final or empty. | 161 |
| Method 'write' is not designed for extension - needs to be abstract, final or empty. | 193 |
| Parameter out should be final. | 194 |
| Method 'readFields' is not designed for extension - needs to be abstract, final or empty. | 202 |
| Parameter in should be final. | 203 |
org/apache/giraph/edge/LongNullArrayEdges.java
| Violation | Message | Line |
|---|---|---|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 46 |
| Parameter edges should be final. | 47 |
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 51 |
| Parameter capacity should be final. | 52 |
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 56 |
| Method 'add' is not designed for extension - needs to be abstract, final or empty. | 61 |
| Parameter edge should be final. | 62 |
| '4' is a magic number. | 71 |
| Parameter i should be final. | 81 |
| Method 'remove' is not designed for extension - needs to be abstract, final or empty. | 94 |
| Parameter targetVertexId should be final. | 95 |
| Method 'size' is not designed for extension - needs to be abstract, final or empty. | 105 |
| Method 'iterator' is not designed for extension - needs to be abstract, final or empty. | 110 |
| Method 'mutableIterator' is not designed for extension - needs to be abstract, final or empty. | 118 |
| Method 'write' is not designed for extension - needs to be abstract, final or empty. | 147 |
| Parameter out should be final. | 148 |
| Method 'readFields' is not designed for extension - needs to be abstract, final or empty. | 156 |
| Parameter in should be final. | 157 |
org/apache/giraph/edge/LongNullHashSetEdges.java
| Violation | Message | Line |
|---|---|---|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 47 |
| Parameter edges should be final. | 48 |
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 52 |
| Parameter capacity should be final. | 53 |
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 57 |
| Method 'add' is not designed for extension - needs to be abstract, final or empty. | 62 |
| Parameter edge should be final. | 63 |
| Method 'remove' is not designed for extension - needs to be abstract, final or empty. | 67 |
| Parameter targetVertexId should be final. | 68 |
| Method 'size' is not designed for extension - needs to be abstract, final or empty. | 72 |
| Method 'iterator' is not designed for extension - needs to be abstract, final or empty. | 77 |
| Method 'mutableIterator' is not designed for extension - needs to be abstract, final or empty. | 85 |
| Method 'write' is not designed for extension - needs to be abstract, final or empty. | 111 |
| Parameter out should be final. | 112 |
| Method 'readFields' is not designed for extension - needs to be abstract, final or empty. | 120 |
| Parameter in should be final. | 121 |
org/apache/giraph/edge/MapMutableEdge.java
| Violation | Message | Line |
|---|---|---|
| Method 'setEntry' is not designed for extension - needs to be abstract, final or empty. | 42 |
| Parameter entry should be final. | 42 |
| 'entry' hides a field. | 42 |
| Method 'setValue' is not designed for extension - needs to be abstract, final or empty. | 46 |
| Parameter value should be final. | 47 |
| Method 'getTargetVertexId' is not designed for extension - needs to be abstract, final or empty. | 52 |
| Method 'getValue' is not designed for extension - needs to be abstract, final or empty. | 57 |
org/apache/giraph/edge/MutableEdgesIterable.java
| Violation | Message | Line |
|---|---|---|
| Parameter vertex should be final. | 44 |
| 'vertex' hides a field. | 44 |
| Method 'iterator' is not designed for extension - needs to be abstract, final or empty. | 48 |
org/apache/giraph/edge/MutableEdgesWrapper.java
| Violation | Message | Line |
|---|---|---|
| Class MutableEdgesWrapper should be declared as final. | 42 |
| Parameter oldEdges should be final. | 58 |
| Parameter newEdges should be final. | 59 |
| 'newEdges' hides a field. | 59 |
| Parameter edges should be final. | 75 |
| Parameter conf should be final. | 76 |
| Parameter edge should be final. | 130 |
| Parameter edges should be final. | 135 |
| '+' should be on a new line. | 136 |
| Parameter capacity should be final. | 141 |
| '+' should be on a new line. | 142 |
| '+' should be on a new line. | 148 |
| Parameter edge should be final. | 153 |
| Parameter targetVertexId should be final. | 158 |
| Parameter out should be final. | 173 |
| '+' should be on a new line. | 174 |
| Parameter in should be final. | 179 |
| '+' should be on a new line. | 180 |
org/apache/giraph/examples/AggregatorsTestComputation.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 36 |
| First sentence should end with a period. | 38 |
| First sentence should end with a period. | 40 |
| First sentence should end with a period. | 42 |
| First sentence should end with a period. | 44 |
| First sentence should end with a period. | 46 |
| Method 'compute' is not designed for extension - needs to be abstract, final or empty. | 49 |
| Parameter vertex should be final. | 51 |
| Parameter messages should be final. | 52 |
| '10' is a magic number. | 78 |
| Method 'compute' is not designed for extension - needs to be abstract, final or empty. | 86 |
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 111 |
| Parameter expected should be final. | 131 |
| Parameter actual should be final. | 131 |
| '+' should be on a new line. | 133 |
org/apache/giraph/examples/ConnectedComponentsComputation.java
| Violation | Message | Line |
|---|---|---|
| Method 'compute' is not designed for extension - needs to be abstract, final or empty. | 59 |
| Parameter vertex should be final. | 61 |
| Parameter messages should be final. | 62 |
| Expected @throws tag for 'IOException'. | 62 |
org/apache/giraph/examples/GeneratedVertexReader.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 29 |
| First sentence should end with a period. | 41 |
| First sentence should end with a period. | 44 |
| First sentence should end with a period. | 49 |
| First sentence should end with a period. | 51 |
| Variable 'recordsRead' must be private and have accessor methods. | 52 |
| First sentence should end with a period. | 53 |
| Variable 'totalRecords' must be private and have accessor methods. | 54 |
| Variable 'inputSplit' must be private and have accessor methods. | 56 |
| Variable 'reverseIdOrder' must be private and have accessor methods. | 58 |
| Parameter inputSplit should be final. | 67 |
| 'inputSplit' hides a field. | 67 |
| Parameter context should be final. | 68 |
| '100.0f' is a magic number. | 84 |
org/apache/giraph/examples/IdentityComputation.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 28 |
| Method 'compute' is not designed for extension - needs to be abstract, final or empty. | 42 |
| Parameter vertex should be final. | 43 |
| Parameter messages should be final. | 44 |
org/apache/giraph/examples/LongDoubleDoubleTextInputFormat.java
| Violation | Message | Line |
|---|---|---|
| Method 'createVertexReader' is not designed for extension - needs to be abstract, final or empty. | 51 |
| Parameter split should be final. | 52 |
| Parameter context should be final. | 53 |
| Method 'setConf' is not designed for extension - needs to be abstract, final or empty. | 58 |
| Parameter configuration should be final. | 59 |
| Method 'getConf' is not designed for extension - needs to be abstract, final or empty. | 64 |
| First sentence should end with a period. | 77 |
| Method 'getCurrentVertex' is not designed for extension - needs to be abstract, final or empty. | 80 |
| Method 'nextVertex' is not designed for extension - needs to be abstract, final or empty. | 103 |
org/apache/giraph/examples/LongDoubleNullTextInputFormat.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 38 |
| Method 'createVertexReader' is not designed for extension - needs to be abstract, final or empty. | 49 |
| Parameter split should be final. | 50 |
| Parameter context should be final. | 51 |
| Method 'setConf' is not designed for extension - needs to be abstract, final or empty. | 56 |
| Parameter configuration should be final. | 57 |
| Method 'getConf' is not designed for extension - needs to be abstract, final or empty. | 62 |
| First sentence should end with a period. | 75 |
| Method 'getCurrentVertex' is not designed for extension - needs to be abstract, final or empty. | 78 |
| Method 'nextVertex' is not designed for extension - needs to be abstract, final or empty. | 100 |
org/apache/giraph/examples/NormalizingLongDoubleDoubleTextInputFormat.java
| Violation | Message | Line |
|---|---|---|
| Method 'createVertexReader' is not designed for extension - needs to be abstract, final or empty. | 52 |
| Parameter split should be final. | 54 |
| Parameter context should be final. | 54 |
| Method 'setConf' is not designed for extension - needs to be abstract, final or empty. | 58 |
| Parameter configuration should be final. | 59 |
| Method 'getConf' is not designed for extension - needs to be abstract, final or empty. | 64 |
| First sentence should end with a period. | 76 |
| First sentence should end with a period. | 78 |
| Method 'getCurrentVertex' is not designed for extension - needs to be abstract, final or empty. | 81 |
| Method 'parse' is not designed for extension - needs to be abstract, final or empty. | 106 |
| Parameter tokens should be final. | 106 |
| Parameter edges should be final. | 107 |
| Method 'normalize' is not designed for extension - needs to be abstract, final or empty. | 119 |
| Parameter edges should be final. | 119 |
| Method 'nextVertex' is not designed for extension - needs to be abstract, final or empty. | 133 |
org/apache/giraph/examples/PageRankComputation.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 28 |
| Method 'transitionProbability' is not designed for extension - needs to be abstract, final or empty. | 33 |
| Parameter vertex should be final. | 35 |
| Parameter stateProbability should be final. | 36 |
| Parameter edge should be final. | 36 |
| Method 'recompute' is not designed for extension - needs to be abstract, final or empty. | 40 |
| Parameter vertex should be final. | 42 |
| Parameter partialRanks should be final. | 43 |
| Parameter teleportationProbability should be final. | 43 |
| '*' should be on a new line. | 51 |
| '+' should be on a new line. | 52 |
org/apache/giraph/examples/RandomWalkComputation.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 30 |
| First sentence should end with a period. | 37 |
| '+' should be on a new line. | 38 |
| First sentence should end with a period. | 40 |
| First sentence should end with a period. | 43 |
| First sentence should end with a period. | 46 |
| First sentence should end with a period. | 49 |
| First sentence should end with a period. | 52 |
| First sentence should end with a period. | 56 |
| First sentence should end with a period. | 58 |
| Method 'initialProbability' is not designed for extension - needs to be abstract, final or empty. | 66 |
| First sentence should end with a period. | 70 |
| Method 'getDanglingProbability' is not designed for extension - needs to be abstract, final or empty. | 99 |
| Method 'getPreviousCumulativeProbability' is not designed for extension - needs to be abstract, final or empty. | 108 |
| Method 'compute' is not designed for extension - needs to be abstract, final or empty. | 113 |
| Parameter vertex should be final. | 115 |
| Parameter messages should be final. | 116 |
| First sentence should end with a period. | 157 |
| First sentence should end with a period. | 165 |
| Method 'teleportationProbability' is not designed for extension - needs to be abstract, final or empty. | 169 |
org/apache/giraph/examples/RandomWalkVertexMasterCompute.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 34 |
| First sentence should end with a period. | 37 |
| Method 'compute' is not designed for extension - needs to be abstract, final or empty. | 41 |
| '+' should be on a new line. | 56 |
| '+' should be on a new line. | 57 |
| '+' should be on a new line. | 58 |
| '+' should be on a new line. | 59 |
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 69 |
org/apache/giraph/examples/RandomWalkWithRestartComputation.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 36 |
| First sentence should end with a period. | 40 |
| Parameter vertex should be final. | 45 |
| Method 'transitionProbability' is not designed for extension - needs to be abstract, final or empty. | 58 |
| Parameter vertex should be final. | 60 |
| Parameter stateProbability should be final. | 62 |
| Parameter edge should be final. | 62 |
| Method 'recompute' is not designed for extension - needs to be abstract, final or empty. | 66 |
| Parameter vertex should be final. | 68 |
| Parameter transitionProbabilities should be final. | 69 |
| Parameter teleportationProbability should be final. | 70 |
org/apache/giraph/examples/RandomWalkWorkerContext.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 39 |
| First sentence should end with a period. | 41 |
| First sentence should end with a period. | 43 |
| Name 'MAX_SUPERSTEPS' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 44 |
| First sentence should end with a period. | 45 |
| Name 'TELEPORTATION_PROBABILITY' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 46 |
| First sentence should end with a period. | 47 |
| Name 'SOURCES' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 48 |
| First sentence should end with a period. | 50 |
| First sentence should end with a period. | 54 |
| Method 'getMaxSupersteps' is not designed for extension - needs to be abstract, final or empty. | 61 |
| '+' should be on a new line. | 64 |
| '+' should be on a new line. | 65 |
| Method 'getTeleportationProbability' is not designed for extension - needs to be abstract, final or empty. | 74 |
| '+' should be on a new line. | 77 |
| '+' should be on a new line. | 78 |
| Method 'isSource' is not designed for extension - needs to be abstract, final or empty. | 89 |
| Parameter id should be final. | 89 |
| Method 'numSources' is not designed for extension - needs to be abstract, final or empty. | 96 |
| Parameter configuration should be final. | 109 |
| Method 'preApplication' is not designed for extension - needs to be abstract, final or empty. | 142 |
org/apache/giraph/examples/SimpleAggregatorWriter.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 40 |
| Name 'FILENAME' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 41 |
| First sentence should end with a period. | 42 |
| Missing a Javadoc comment. | 45 |
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 49 |
| Parameter context should be final. | 51 |
| Parameter applicationAttempt should be final. | 51 |
| Method 'writeAggregator' is not designed for extension - needs to be abstract, final or empty. | 59 |
| Parameter aggregatorMap should be final. | 61 |
| Parameter superstep should be final. | 62 |
| Method 'close' is not designed for extension - needs to be abstract, final or empty. | 69 |
org/apache/giraph/examples/SimpleCheckpoint.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 54 |
| First sentence should end with a period. | 56 |
| First sentence should end with a period. | 58 |
| First sentence should end with a period. | 64 |
| First sentence should end with a period. | 67 |
| Method 'compute' is not designed for extension - needs to be abstract, final or empty. | 76 |
| Parameter vertex should be final. | 78 |
| Parameter messages should be final. | 79 |
| '&&' should be on a new line. | 85 |
| '&&' should be on a new line. | 86 |
| '+' should be on a new line. | 88 |
| '+' should be on a new line. | 89 |
| '+' should be on a new line. | 90 |
| '+' should be on a new line. | 103 |
| '+' should be on a new line. | 109 |
| '+' should be on a new line. | 110 |
| '+' should be on a new line. | 115 |
| '+' should be on a new line. | 116 |
| '+' should be on a new line. | 119 |
| '+' should be on a new line. | 123 |
| '+' should be on a new line. | 124 |
| '+' should be on a new line. | 125 |
| '+' should be on a new line. | 126 |
| '+' should be on a new line. | 127 |
| First sentence should end with a period. | 140 |
| First sentence should end with a period. | 142 |
| Name 'FINAL_SUM' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 143 |
| First sentence should end with a period. | 144 |
| '6' is a magic number. | 145 |
| Missing a Javadoc comment. | 149 |
| Method 'preApplication' is not designed for extension - needs to be abstract, final or empty. | 153 |
| Method 'postApplication' is not designed for extension - needs to be abstract, final or empty. | 162 |
| Method 'getSupersteps' is not designed for extension - needs to be abstract, final or empty. | 176 |
| Missing a Javadoc comment. | 176 |
| Method 'getEnableFault' is not designed for extension - needs to be abstract, final or empty. | 180 |
| Missing a Javadoc comment. | 180 |
| Method 'run' is not designed for extension - needs to be abstract, final or empty. | 185 |
| Parameter args should be final. | 186 |
| '100.0f' is a magic number. | 240 |
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 265 |
| Parameter args should be final. | 279 |
| Expected @throws tag for 'Exception'. | 279 |
| Method 'getConf' is not designed for extension - needs to be abstract, final or empty. | 283 |
| Method 'setConf' is not designed for extension - needs to be abstract, final or empty. | 288 |
| Parameter conf should be final. | 289 |
| 'conf' hides a field. | 289 |
org/apache/giraph/examples/SimpleCombinerComputation.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 35 |
| Name 'LOG' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 36 |
| Method 'compute' is not designed for extension - needs to be abstract, final or empty. | 38 |
| Parameter vertex should be final. | 40 |
| Parameter messages should be final. | 41 |
| '101' is a magic number. | 43 |
| '102' is a magic number. | 44 |
| '103' is a magic number. | 45 |
| '+' should be on a new line. | 57 |
| '306' is a magic number. | 60 |
| '3' is a magic number. | 64 |
| '+' should be on a new line. | 66 |
org/apache/giraph/examples/SimpleFailComputation.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 30 |
| First sentence should end with a period. | 35 |
| Name 'LOG' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 36 |
| Comment matches to-do format 'TODO:'. | 37 |
| First sentence should end with a period. | 37 |
| Name 'SUPERSTEP' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 38 |
| Method 'compute' is not designed for extension - needs to be abstract, final or empty. | 40 |
| Parameter vertex should be final. | 42 |
| Parameter messages should be final. | 43 |
| '0.15f' is a magic number. | 50 |
| '0.85f' is a magic number. | 50 |
| '30' is a magic number. | 52 |
| '20' is a magic number. | 53 |
| '10L' is a magic number. | 54 |
| '2000' is a magic number. | 56 |
| '10' is a magic number. | 61 |
org/apache/giraph/examples/SimpleInDegreeCountComputation.java
| Violation | Message | Line |
|---|---|---|
| Method 'compute' is not designed for extension - needs to be abstract, final or empty. | 38 |
| Parameter vertex should be final. | 40 |
| Parameter messages should be final. | 41 |
org/apache/giraph/examples/SimpleLongDoubleDoubleDoubleIdentityComputation.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 24 |
org/apache/giraph/examples/SimpleMasterComputeComputation.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 39 |
| First sentence should end with a period. | 41 |
| Method 'compute' is not designed for extension - needs to be abstract, final or empty. | 45 |
| Parameter vertex should be final. | 47 |
| Parameter messages should be final. | 48 |
| Avoid inline conditionals. | 49 |
| First sentence should end with a period. | 63 |
| Name 'FINAL_SUM' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 64 |
| Method 'setFinalSum' is not designed for extension - needs to be abstract, final or empty. | 83 |
| Missing a Javadoc comment. | 83 |
| Parameter sum should be final. | 83 |
| Missing a Javadoc comment. | 87 |
| Method 'compute' is not designed for extension - needs to be abstract, final or empty. | 97 |
| '10' is a magic number. | 101 |
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 106 |
org/apache/giraph/examples/SimpleMsgComputation.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 35 |
| Name 'LOG' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 36 |
| Method 'compute' is not designed for extension - needs to be abstract, final or empty. | 37 |
| Parameter vertex should be final. | 39 |
| Parameter messages should be final. | 40 |
| '101' is a magic number. | 42 |
| '102' is a magic number. | 43 |
| '103' is a magic number. | 44 |
| '+' should be on a new line. | 54 |
| '306' is a magic number. | 57 |
| '3' is a magic number. | 61 |
| '+' should be on a new line. | 62 |
org/apache/giraph/examples/SimpleMutateGraphComputation.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 37 |
| Name 'LOG' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 38 |
| First sentence should end with a period. | 40 |
| '100' is a magic number. | 41 |
| Parameter range should be final. | 51 |
| Method 'compute' is not designed for extension - needs to be abstract, final or empty. | 55 |
| Parameter vertex should be final. | 57 |
| Parameter messages should be final. | 58 |
| '3' is a magic number. | 70 |
| '+' should be on a new line. | 74 |
| '+' should be on a new line. | 75 |
| '+' should be on a new line. | 81 |
| '+' should be on a new line. | 82 |
| '3' is a magic number. | 87 |
| '4' is a magic number. | 92 |
| '5' is a magic number. | 94 |
| '+' should be on a new line. | 98 |
| '+' should be on a new line. | 99 |
| '+' should be on a new line. | 105 |
| '+' should be on a new line. | 106 |
| '3' is a magic number. | 111 |
| '6' is a magic number. | 114 |
| '3' is a magic number. | 117 |
| '7' is a magic number. | 120 |
| '+' should be on a new line. | 124 |
| '+' should be on a new line. | 125 |
| '8' is a magic number. | 128 |
| '+' should be on a new line. | 132 |
| '+' should be on a new line. | 133 |
| First sentence should end with a period. | 146 |
| First sentence should end with a period. | 148 |
| First sentence should end with a period. | 150 |
| First sentence should end with a period. | 152 |
| Method 'postSuperstep' is not designed for extension - needs to be abstract, final or empty. | 165 |
| '+' should be on a new line. | 172 |
| '+' should be on a new line. | 173 |
| Method 'getVertexCount' is not designed for extension - needs to be abstract, final or empty. | 179 |
| Missing a Javadoc comment. | 179 |
| Method 'getEdgeCount' is not designed for extension - needs to be abstract, final or empty. | 183 |
| Missing a Javadoc comment. | 183 |
| Method 'getOrigEdgeCount' is not designed for extension - needs to be abstract, final or empty. | 187 |
| Missing a Javadoc comment. | 187 |
| Method 'increaseEdgesRemoved' is not designed for extension - needs to be abstract, final or empty. | 194 |
org/apache/giraph/examples/SimpleOutDegreeCountComputation.java
| Violation | Message | Line |
|---|---|---|
| Method 'compute' is not designed for extension - needs to be abstract, final or empty. | 37 |
| Parameter vertex should be final. | 39 |
| Parameter messages should be final. | 40 |
org/apache/giraph/examples/SimplePageRankComputation.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 52 |
| First sentence should end with a period. | 54 |
| First sentence should end with a period. | 57 |
| Name 'SUM_AGG' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 58 |
| First sentence should end with a period. | 59 |
| Name 'MIN_AGG' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 60 |
| First sentence should end with a period. | 61 |
| Name 'MAX_AGG' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 62 |
| Method 'compute' is not designed for extension - needs to be abstract, final or empty. | 64 |
| Parameter vertex should be final. | 66 |
| Parameter messages should be final. | 67 |
| '0.15f' is a magic number. | 74 |
| '0.85f' is a magic number. | 74 |
| '+' should be on a new line. | 79 |
| '+' should be on a new line. | 80 |
| First sentence should end with a period. | 98 |
| Name 'FINAL_MAX' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 99 |
| First sentence should end with a period. | 100 |
| Name 'FINAL_MIN' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 101 |
| First sentence should end with a period. | 102 |
| Name 'FINAL_SUM' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 103 |
| Missing a Javadoc comment. | 105 |
| Missing a Javadoc comment. | 109 |
| Missing a Javadoc comment. | 113 |
| Method 'postApplication' is not designed for extension - needs to be abstract, final or empty. | 122 |
| Method 'preSuperstep' is not designed for extension - needs to be abstract, final or empty. | 133 |
| '3' is a magic number. | 135 |
| '+' should be on a new line. | 136 |
| '+' should be on a new line. | 137 |
| '!=' should be on a new line. | 139 |
| '+' should be on a new line. | 141 |
| '+' should be on a new line. | 142 |
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 162 |
| First sentence should end with a period. | 171 |
| First sentence should end with a period. | 176 |
| Method 'nextVertex' is not designed for extension - needs to be abstract, final or empty. | 180 |
| Method 'getCurrentVertex' is not designed for extension - needs to be abstract, final or empty. | 185 |
| '10d' is a magic number. | 192 |
| '%' should be on a new line. | 194 |
| '100f' is a magic number. | 196 |
| '+' should be on a new line. | 203 |
| '+' should be on a new line. | 204 |
| First sentence should end with a period. | 211 |
| Method 'createVertexReader' is not designed for extension - needs to be abstract, final or empty. | 216 |
| Parameter split should be final. | 218 |
| Parameter context should be final. | 219 |
| First sentence should end with a period. | 225 |
| Method 'createVertexWriter' is not designed for extension - needs to be abstract, final or empty. | 230 |
| Parameter context should be final. | 231 |
| First sentence should end with a period. | 236 |
| Method 'writeVertex' is not designed for extension - needs to be abstract, final or empty. | 240 |
| Parameter vertex should be final. | 242 |
org/apache/giraph/examples/SimpleShortestPathsComputation.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 41 |
| First sentence should end with a period. | 44 |
| Parameter vertex should be final. | 54 |
| Method 'compute' is not designed for extension - needs to be abstract, final or empty. | 58 |
| Parameter vertex should be final. | 60 |
| Parameter messages should be final. | 61 |
| Avoid inline conditionals. | 65 |
| '+' should be on a new line. | 70 |
| '+' should be on a new line. | 78 |
org/apache/giraph/examples/SimpleSuperstepComputation.java
| Violation | Message | Line |
|---|---|---|
| Method 'compute' is not designed for extension - needs to be abstract, final or empty. | 46 |
| Parameter vertex should be final. | 48 |
| Parameter messages should be final. | 49 |
| '+' should be on a new line. | 52 |
| '+' should be on a new line. | 56 |
| '+' should be on a new line. | 60 |
| '3' is a magic number. | 64 |
| First sentence should end with a period. | 69 |
| First sentence should end with a period. | 74 |
| Method 'nextVertex' is not designed for extension - needs to be abstract, final or empty. | 78 |
| Method 'getCurrentVertex' is not designed for extension - needs to be abstract, final or empty. | 83 |
| '?' should be on a new line. | 88 |
| Avoid inline conditionals. | 88 |
| '-' should be on a new line. | 89 |
| ':' should be on a new line. | 90 |
| '10' is a magic number. | 94 |
| '%' should be on a new line. | 97 |
| '100f' is a magic number. | 99 |
| '+' should be on a new line. | 105 |
| '+' should be on a new line. | 106 |
| '+' should be on a new line. | 107 |
| First sentence should end with a period. | 114 |
| Method 'createVertexReader' is not designed for extension - needs to be abstract, final or empty. | 119 |
| Parameter split should be final. | 121 |
| Parameter context should be final. | 121 |
| First sentence should end with a period. | 128 |
| Method 'createVertexWriter' is not designed for extension - needs to be abstract, final or empty. | 133 |
| Parameter context should be final. | 134 |
| First sentence should end with a period. | 139 |
| Method 'writeVertex' is not designed for extension - needs to be abstract, final or empty. | 143 |
| Parameter vertex should be final. | 144 |
org/apache/giraph/examples/SimpleTextVertexOutputFormat.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 36 |
| Parameter vertex should be final. | 42 |
| Method 'createVertexWriter' is not designed for extension - needs to be abstract, final or empty. | 50 |
| Parameter context should be final. | 51 |
org/apache/giraph/examples/SimpleTriangleClosingComputation.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 69 |
| Method 'compute' is not designed for extension - needs to be abstract, final or empty. | 73 |
| Parameter vertex should be final. | 75 |
| Parameter messages should be final. | 76 |
| '?' should be on a new line. | 84 |
| Avoid inline conditionals. | 84 |
| First sentence should end with a period. | 108 |
| First sentence should end with a period. | 110 |
| First sentence should end with a period. | 113 |
| First sentence should end with a period. | 116 |
| Parameter k should be final. | 120 |
| Parameter v should be final. | 120 |
| First sentence should end with a period. | 124 |
| Method 'getKey' is not designed for extension - needs to be abstract, final or empty. | 126 |
| First sentence should end with a period. | 127 |
| Method 'getValue' is not designed for extension - needs to be abstract, final or empty. | 129 |
| First sentence should end with a period. | 130 |
| Method 'compareTo' is not designed for extension - needs to be abstract, final or empty. | 133 |
| Parameter other should be final. | 134 |
| First sentence should end with a period. | 139 |
| First sentence should end with a period. | 143 |
| First sentence should end with a period. | 147 |
| Method 'setClass' is not designed for extension - needs to be abstract, final or empty. | 148 |
org/apache/giraph/examples/SimpleVertexWithWorkerContext.java
| Violation | Message | Line |
|---|---|---|
| Line is longer than 80 characters. | 22 |
| First sentence should end with a period. | 48 |
| First sentence should end with a period. | 50 |
| Method 'setConf' is not designed for extension - needs to be abstract, final or empty. | 53 |
| Parameter conf should be final. | 54 |
| 'conf' hides a field. | 54 |
| Method 'getConf' is not designed for extension - needs to be abstract, final or empty. | 58 |
| First sentence should end with a period. | 63 |
| Method 'compute' is not designed for extension - needs to be abstract, final or empty. | 68 |
| Parameter vertex should be final. | 70 |
| Parameter messages should be final. | 71 |
| '+' should be on a new line. | 77 |
| First sentence should end with a period. | 90 |
| Method 'preApplication' is not designed for extension - needs to be abstract, final or empty. | 95 |
| '+' should be on a new line. | 107 |
| '+' should be on a new line. | 113 |
| '+' should be on a new line. | 117 |
| '+' should be on a new line. | 120 |
| Method 'postApplication' is not designed for extension - needs to be abstract, final or empty. | 131 |
| Method 'emit' is not designed for extension - needs to be abstract, final or empty. | 156 |
| Parameter s should be final. | 156 |
| Method 'run' is not designed for extension - needs to be abstract, final or empty. | 165 |
| Parameter args should be final. | 166 |
| '100.0f' is a magic number. | 180 |
| Parameter args should be final. | 194 |
| Expected @throws tag for 'Exception'. | 194 |
org/apache/giraph/examples/TestComputationStateComputation.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 31 |
| First sentence should end with a period. | 37 |
| First sentence should end with a period. | 39 |
| First sentence should end with a period. | 41 |
| First sentence should end with a period. | 44 |
| Method 'compute' is not designed for extension - needs to be abstract, final or empty. | 50 |
| Parameter vertex should be final. | 52 |
| Parameter messages should be final. | 53 |
| '5' is a magic number. | 55 |
| Method 'preSuperstep' is not designed for extension - needs to be abstract, final or empty. | 60 |
| Method 'postSuperstep' is not designed for extension - needs to be abstract, final or empty. | 66 |
| First sentence should end with a period. | 72 |
| First sentence should end with a period. | 77 |
| First sentence should end with a period. | 79 |
| Method 'preSuperstep' is not designed for extension - needs to be abstract, final or empty. | 84 |
| Method 'postSuperstep' is not designed for extension - needs to be abstract, final or empty. | 90 |
| Parameter expected should be final. | 103 |
| Parameter actual should be final. | 103 |
| '+' should be on a new line. | 105 |
org/apache/giraph/examples/VerifyMessage.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 48 |
| First sentence should end with a period. | 50 |
| First sentence should end with a period. | 52 |
| Parameter superstep should be final. | 67 |
| 'superstep' hides a field. | 67 |
| Parameter sourceVertexId should be final. | 67 |
| 'sourceVertexId' hides a field. | 67 |
| Parameter value should be final. | 67 |
| 'value' hides a field. | 67 |
| Method 'readFields' is not designed for extension - needs to be abstract, final or empty. | 73 |
| Parameter input should be final. | 74 |
| Method 'write' is not designed for extension - needs to be abstract, final or empty. | 80 |
| Parameter output should be final. | 81 |
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 87 |
| '+' should be on a new line. | 89 |
| First sentence should end with a period. | 100 |
| First sentence should end with a period. | 103 |
| Name 'FINAL_SUM' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 104 |
| First sentence should end with a period. | 105 |
| Name 'SUPERSTEPS' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 106 |
| '6' is a magic number. | 106 |
| First sentence should end with a period. | 107 |
| Name 'LOG' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 108 |
| Missing a Javadoc comment. | 111 |
| Method 'preApplication' is not designed for extension - needs to be abstract, final or empty. | 120 |
| Method 'postApplication' is not designed for extension - needs to be abstract, final or empty. | 127 |
| Method 'compute' is not designed for extension - needs to be abstract, final or empty. | 142 |
| Parameter vertex should be final. | 144 |
| Parameter messages should be final. | 145 |
| '+' should be on a new line. | 156 |
| '+' should be on a new line. | 157 |
| '+' should be on a new line. | 164 |
| '+' should be on a new line. | 165 |
| '+' should be on a new line. | 166 |
| '+' should be on a new line. | 171 |
| '+' should be on a new line. | 172 |
| '&&' should be on a new line. | 175 |
| '+' should be on a new line. | 178 |
| '+' should be on a new line. | 179 |
| '+' should be on a new line. | 186 |
| '+' should be on a new line. | 187 |
| '+' should be on a new line. | 196 |
| '+' should be on a new line. | 197 |
| '+' should be on a new line. | 198 |
| '+' should be on a new line. | 199 |
| '+' should be on a new line. | 200 |
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 217 |
org/apache/giraph/examples/VertexWithDoubleValueDoubleEdgeTextOutputFormat.java
| Violation | Message | Line |
|---|---|---|
| Method 'createVertexWriter' is not designed for extension - needs to be abstract, final or empty. | 35 |
| Parameter context should be final. | 36 |
| Method 'writeVertex' is not designed for extension - needs to be abstract, final or empty. | 45 |
| Parameter vertex should be final. | 47 |
org/apache/giraph/examples/VertexWithDoubleValueNullEdgeTextOutputFormat.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 31 |
| Method 'createVertexWriter' is not designed for extension - needs to be abstract, final or empty. | 37 |
| Parameter context should be final. | 38 |
| Method 'writeVertex' is not designed for extension - needs to be abstract, final or empty. | 48 |
| Parameter vertex should be final. | 50 |
org/apache/giraph/graph/AddressesAndPartitionsWritable.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 37 |
| First sentence should end with a period. | 41 |
| First sentence should end with a period. | 43 |
| First sentence should end with a period. | 45 |
| First sentence should end with a period. | 47 |
| First sentence should end with a period. | 50 |
| Parameter masterInfo should be final. | 57 |
| 'masterInfo' hides a field. | 57 |
| Parameter workerInfos should be final. | 58 |
| 'workerInfos' hides a field. | 58 |
| Parameter partitionOwners should be final. | 59 |
| 'partitionOwners' hides a field. | 59 |
| First sentence should end with a period. | 65 |
| Parameter partitionOwnerClass should be final. | 71 |
| 'partitionOwnerClass' hides a field. | 71 |
| First sentence should end with a period. | 75 |
| Method 'getMasterInfo' is not designed for extension - needs to be abstract, final or empty. | 80 |
| First sentence should end with a period. | 84 |
| Method 'getWorkerInfos' is not designed for extension - needs to be abstract, final or empty. | 89 |
| First sentence should end with a period. | 93 |
| Method 'getPartitionOwners' is not designed for extension - needs to be abstract, final or empty. | 98 |
| Method 'write' is not designed for extension - needs to be abstract, final or empty. | 102 |
| Parameter output should be final. | 103 |
| Method 'readFields' is not designed for extension - needs to be abstract, final or empty. | 134 |
| Parameter input should be final. | 135 |
| '+' should be on a new line. | 163 |
| '+' should be on a new line. | 164 |
| '+' should be on a new line. | 167 |
| '+' should be on a new line. | 168 |
| Parameter workerInfos should be final. | 181 |
org/apache/giraph/graph/Computation.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 57 |
| First sentence should end with a period. | 59 |
| First sentence should end with a period. | 61 |
| First sentence should end with a period. | 63 |
| First sentence should end with a period. | 65 |
| Expected @throws tag for 'IOException'. | 77 |
| Parameter graphState should be final. | 105 |
| 'graphState' hides a field. | 105 |
| Parameter workerClientRequestProcessor should be final. | 106 |
| 'workerClientRequestProcessor' hides a field. | 106 |
| Parameter graphTaskManager should be final. | 107 |
| 'graphTaskManager' hides a field. | 107 |
| Parameter workerAggregatorUsage should be final. | 108 |
| 'workerAggregatorUsage' hides a field. | 108 |
| Parameter workerContext should be final. | 109 |
| 'workerContext' hides a field. | 109 |
| Method 'getSuperstep' is not designed for extension - needs to be abstract, final or empty. | 122 |
| Method 'getTotalNumVertices' is not designed for extension - needs to be abstract, final or empty. | 132 |
| Method 'getTotalNumEdges' is not designed for extension - needs to be abstract, final or empty. | 142 |
| Method 'sendMessage' is not designed for extension - needs to be abstract, final or empty. | 152 |
| Parameter id should be final. | 152 |
| Parameter message should be final. | 152 |
| Method 'sendMessageToAllEdges' is not designed for extension - needs to be abstract, final or empty. | 164 |
| Parameter vertex should be final. | 164 |
| Parameter message should be final. | 164 |
| Method 'addVertexRequest' is not designed for extension - needs to be abstract, final or empty. | 178 |
| Parameter id should be final. | 178 |
| Parameter value should be final. | 178 |
| Parameter edges should be final. | 179 |
| Expected @throws tag for 'IOException'. | 179 |
| Method 'addVertexRequest' is not designed for extension - needs to be abstract, final or empty. | 192 |
| Parameter id should be final. | 192 |
| Parameter value should be final. | 192 |
| Expected @throws tag for 'IOException'. | 192 |
| Method 'removeVertexRequest' is not designed for extension - needs to be abstract, final or empty. | 202 |
| Parameter vertexId should be final. | 202 |
| Expected @throws tag for 'IOException'. | 202 |
| First sentence should end with a period. | 206 |
| Method 'addEdgeRequest' is not designed for extension - needs to be abstract, final or empty. | 213 |
| Parameter sourceVertexId should be final. | 213 |
| Parameter edge should be final. | 214 |
| Expected @throws tag for 'IOException'. | 214 |
| Method 'removeEdgesRequest' is not designed for extension - needs to be abstract, final or empty. | 225 |
| Parameter sourceVertexId should be final. | 225 |
| Parameter targetVertexId should be final. | 226 |
| Expected @throws tag for 'IOException'. | 226 |
| First sentence should end with a period. | 231 |
| Method 'getContext' is not designed for extension - needs to be abstract, final or empty. | 236 |
| First sentence should end with a period. | 240 |
| Method 'getWorkerContext' is not designed for extension - needs to be abstract, final or empty. | 246 |
| Method 'aggregate' is not designed for extension - needs to be abstract, final or empty. | 251 |
| Parameter name should be final. | 252 |
| Parameter value should be final. | 252 |
| Method 'getAggregatedValue' is not designed for extension - needs to be abstract, final or empty. | 256 |
| Parameter name should be final. | 257 |
org/apache/giraph/graph/ComputeCallable.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 73 |
| First sentence should end with a period. | 75 |
| First sentence should end with a period. | 77 |
| First sentence should end with a period. | 79 |
| First sentence should end with a period. | 81 |
| First sentence should end with a period. | 83 |
| First sentence should end with a period. | 85 |
| First sentence should end with a period. | 87 |
| First sentence should end with a period. | 89 |
| First sentence should end with a period. | 91 |
| First sentence should end with a period. | 93 |
| First sentence should end with a period. | 97 |
| First sentence should end with a period. | 99 |
| First sentence should end with a period. | 102 |
| Parameter context should be final. | 113 |
| 'context' hides a field. | 113 |
| Parameter graphState should be final. | 113 |
| 'graphState' hides a field. | 113 |
| Parameter messageStore should be final. | 114 |
| 'messageStore' hides a field. | 114 |
| Parameter partitionIdQueue should be final. | 115 |
| 'partitionIdQueue' hides a field. | 115 |
| Parameter configuration should be final. | 116 |
| 'configuration' hides a field. | 116 |
| Parameter serviceWorker should be final. | 117 |
| 'serviceWorker' hides a field. | 117 |
| Method 'call' is not designed for extension - needs to be abstract, final or empty. | 132 |
| '+' should be on a new line. | 167 |
| '+' should be on a new line. | 168 |
| '+' should be on a new line. | 169 |
| '+' should be on a new line. | 172 |
| '+' should be on a new line. | 175 |
| '/' should be on a new line. | 188 |
| '+' should be on a new line. | 190 |
| '+' should be on a new line. | 191 |
| First sentence should end with a period. | 203 |
| Parameter computation should be final. | 211 |
| Parameter partition should be final. | 212 |
| Expected @throws tag for 'IOException'. | 212 |
| Expected @throws tag for 'InterruptedException'. | 212 |
org/apache/giraph/graph/DefaultVertexResolver.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 41 |
| First sentence should end with a period. | 45 |
| Method 'resolve' is not designed for extension - needs to be abstract, final or empty. | 48 |
| Parameter vertexId should be final. | 50 |
| Parameter vertex should be final. | 51 |
| Parameter vertexChanges should be final. | 52 |
| Parameter hasMessages should be final. | 53 |
| Method 'removeEdges' is not designed for extension - needs to be abstract, final or empty. | 78 |
| Parameter vertex should be final. | 78 |
| Parameter vertexChanges should be final. | 79 |
| Method 'removeVertexIfDesired' is not designed for extension - needs to be abstract, final or empty. | 99 |
| Parameter vertex should be final. | 100 |
| Parameter vertexChanges should be final. | 101 |
| Method 'addVertexIfDesired' is not designed for extension - needs to be abstract, final or empty. | 118 |
| Parameter vertexId should be final. | 119 |
| Parameter vertex should be final. | 120 |
| Parameter vertexChanges should be final. | 121 |
| Parameter hasMessages should be final. | 122 |
| '||' should be on a new line. | 126 |
| '+' should be on a new line. | 132 |
| '+' should be on a new line. | 133 |
| Method 'addEdges' is not designed for extension - needs to be abstract, final or empty. | 145 |
| Parameter vertex should be final. | 145 |
| Parameter vertexChanges should be final. | 146 |
| First sentence should end with a period. | 157 |
| Method 'hasVertexRemovals' is not designed for extension - needs to be abstract, final or empty. | 163 |
| Parameter changes should be final. | 163 |
| First sentence should end with a period. | 167 |
| Method 'hasVertexAdditions' is not designed for extension - needs to be abstract, final or empty. | 173 |
| Parameter changes should be final. | 173 |
| First sentence should end with a period. | 177 |
| Method 'hasEdgeAdditions' is not designed for extension - needs to be abstract, final or empty. | 183 |
| Parameter changes should be final. | 183 |
| First sentence should end with a period. | 187 |
| Method 'hasEdgeRemovals' is not designed for extension - needs to be abstract, final or empty. | 193 |
| Parameter changes should be final. | 193 |
| Method 'setConf' is not designed for extension - needs to be abstract, final or empty. | 197 |
| Parameter conf should be final. | 198 |
org/apache/giraph/graph/DefaultVertexValueFactory.java
| Violation | Message | Line |
|---|---|---|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 36 |
| Parameter configuration should be final. | 38 |
| Method 'createVertexValue' is not designed for extension - needs to be abstract, final or empty. | 42 |
org/apache/giraph/graph/FinishedSuperstepStats.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 20 |
| First sentence should end with a period. | 24 |
| First sentence should end with a period. | 28 |
| Parameter numLocalVertices should be final. | 40 |
| Parameter allVerticesHalted should be final. | 41 |
| 'allVerticesHalted' hides a field. | 41 |
| Parameter numVertices should be final. | 42 |
| Parameter numEdges should be final. | 43 |
| Parameter mustLoadCheckpoint should be final. | 44 |
| 'mustLoadCheckpoint' hides a field. | 44 |
| Method 'getLocalVertexCount' is not designed for extension - needs to be abstract, final or empty. | 51 |
| Missing a Javadoc comment. | 51 |
| Method 'allVerticesHalted' is not designed for extension - needs to be abstract, final or empty. | 60 |
| Method 'mustLoadCheckpoint' is not designed for extension - needs to be abstract, final or empty. | 69 |
org/apache/giraph/graph/GiraphTransferRegulator.java
| Violation | Message | Line |
|---|---|---|
| Comment matches to-do format 'TODO:'. | 35 |
| First sentence should end with a period. | 58 |
| First sentence should end with a period. | 66 |
| First sentence should end with a period. | 74 |
| First sentence should end with a period. | 77 |
| First sentence should end with a period. | 80 |
| First sentence should end with a period. | 83 |
| First sentence should end with a period. | 86 |
| Parameter conf should be final. | 89 |
| Method 'transferThisPartition' is not designed for extension - needs to be abstract, final or empty. | 107 |
| Parameter owner should be final. | 107 |
| '>=' should be on a new line. | 109 |
| '||' should be on a new line. | 110 |
| '>=' should be on a new line. | 111 |
| '?' should be on a new line. | 126 |
| Avoid inline conditionals. | 126 |
| '?' should be on a new line. | 136 |
| Avoid inline conditionals. | 136 |
| First sentence should end with a period. | 140 |
| Method 'clearCounters' is not designed for extension - needs to be abstract, final or empty. | 141 |
| Method 'incrementCounters' is not designed for extension - needs to be abstract, final or empty. | 159 |
| Parameter partitionOwner should be final. | 161 |
| Parameter vertex should be final. | 162 |
| '+' should be on a new line. | 170 |
| First sentence should end with a period. | 174 |
| Method 'getMaxEdgesPerTransfer' is not designed for extension - needs to be abstract, final or empty. | 176 |
| First sentence should end with a period. | 180 |
| Method 'getMaxVerticesPerTransfer' is not designed for extension - needs to be abstract, final or empty. | 182 |
| First sentence should end with a period. | 186 |
| Method 'getTotalEdges' is not designed for extension - needs to be abstract, final or empty. | 188 |
| First sentence should end with a period. | 192 |
| Method 'getTotalVertices' is not designed for extension - needs to be abstract, final or empty. | 194 |
org/apache/giraph/graph/GlobalStats.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 32 |
| First sentence should end with a period. | 34 |
| First sentence should end with a period. | 36 |
| First sentence should end with a period. | 38 |
| First sentence should end with a period. | 40 |
| Method 'addPartitionStats' is not designed for extension - needs to be abstract, final or empty. | 48 |
| Parameter partitionStats should be final. | 48 |
| Method 'getVertexCount' is not designed for extension - needs to be abstract, final or empty. | 54 |
| Missing a Javadoc comment. | 54 |
| Method 'getFinishedVertexCount' is not designed for extension - needs to be abstract, final or empty. | 58 |
| Missing a Javadoc comment. | 58 |
| Method 'getEdgeCount' is not designed for extension - needs to be abstract, final or empty. | 62 |
| Missing a Javadoc comment. | 62 |
| Method 'getMessageCount' is not designed for extension - needs to be abstract, final or empty. | 66 |
| Missing a Javadoc comment. | 66 |
| Method 'getHaltComputation' is not designed for extension - needs to be abstract, final or empty. | 70 |
| Missing a Javadoc comment. | 70 |
| Method 'setHaltComputation' is not designed for extension - needs to be abstract, final or empty. | 74 |
| Missing a Javadoc comment. | 74 |
| Parameter value should be final. | 74 |
| Method 'addMessageCount' is not designed for extension - needs to be abstract, final or empty. | 83 |
| Parameter messageCount should be final. | 83 |
| 'messageCount' hides a field. | 83 |
| Method 'readFields' is not designed for extension - needs to be abstract, final or empty. | 87 |
| Parameter input should be final. | 88 |
| Method 'write' is not designed for extension - needs to be abstract, final or empty. | 96 |
| Parameter output should be final. | 97 |
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 105 |
| '+' should be on a new line. | 107 |
| '+' should be on a new line. | 108 |
org/apache/giraph/graph/GraphFunctions.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 27 |
| First sentence should end with a period. | 33 |
| First sentence should end with a period. | 39 |
| First sentence should end with a period. | 45 |
| First sentence should end with a period. | 51 |
| First sentence should end with a period. | 57 |
| Missing a Javadoc comment. | 85 |
| Missing a Javadoc comment. | 89 |
| Missing a Javadoc comment. | 93 |
org/apache/giraph/graph/GraphMapper.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 44 |
| First sentence should end with a period. | 46 |
| Method 'setup' is not designed for extension - needs to be abstract, final or empty. | 49 |
| Parameter context should be final. | 50 |
| Parameter key should be final. | 73 |
| Parameter value should be final. | 73 |
| Parameter context should be final. | 73 |
| Expected @throws tag for 'IOException'. | 74 |
| Expected @throws tag for 'InterruptedException'. | 74 |
| Method 'cleanup' is not designed for extension - needs to be abstract, final or empty. | 78 |
| Parameter context should be final. | 79 |
| Method 'run' is not designed for extension - needs to be abstract, final or empty. | 84 |
| Parameter context should be final. | 85 |
| '+' should be on a new line. | 113 |
org/apache/giraph/graph/GraphState.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 27 |
| First sentence should end with a period. | 29 |
| First sentence should end with a period. | 31 |
| First sentence should end with a period. | 33 |
| First sentence should end with a period. | 36 |
| Parameter superstep should be final. | 45 |
| 'superstep' hides a field. | 45 |
| Parameter numVertices should be final. | 45 |
| 'numVertices' hides a field. | 45 |
| Parameter numEdges should be final. | 45 |
| 'numEdges' hides a field. | 45 |
| Parameter context should be final. | 46 |
| 'context' hides a field. | 46 |
| Method 'getSuperstep' is not designed for extension - needs to be abstract, final or empty. | 53 |
| Missing a Javadoc comment. | 53 |
| Method 'getTotalNumVertices' is not designed for extension - needs to be abstract, final or empty. | 57 |
| Missing a Javadoc comment. | 57 |
| Method 'getTotalNumEdges' is not designed for extension - needs to be abstract, final or empty. | 61 |
| Missing a Javadoc comment. | 61 |
| Method 'getContext' is not designed for extension - needs to be abstract, final or empty. | 65 |
| Missing a Javadoc comment. | 65 |
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 69 |
| '+' should be on a new line. | 71 |
org/apache/giraph/graph/GraphTaskManager.java
| Violation | Message | Line |
|---|---|---|
| Line is longer than 80 characters. | 74 |
| Line is longer than 80 characters. | 77 |
| First sentence should end with a period. | 99 |
| First sentence should end with a period. | 101 |
| First sentence should end with a period. | 103 |
| First sentence should end with a period. | 106 |
| First sentence should end with a period. | 109 |
| First sentence should end with a period. | 111 |
| First sentence should end with a period. | 113 |
| First sentence should end with a period. | 115 |
| First sentence should end with a period. | 117 |
| First sentence should end with a period. | 121 |
| First sentence should end with a period. | 123 |
| First sentence should end with a period. | 129 |
| First sentence should end with a period. | 134 |
| First sentence should end with a period. | 136 |
| First sentence should end with a period. | 140 |
| First sentence should end with a period. | 142 |
| First sentence should end with a period. | 144 |
| First sentence should end with a period. | 146 |
| First sentence should end with a period. | 150 |
| First sentence should end with a period. | 152 |
| First sentence should end with a period. | 154 |
| First sentence should end with a period. | 156 |
| Parameter context should be final. | 166 |
| 'context' hides a field. | 166 |
| First sentence should end with a period. | 171 |
| Method 'setup' is not designed for extension - needs to be abstract, final or empty. | 175 |
| Parameter zkPathList should be final. | 175 |
| Expected @throws tag for 'IOException'. | 176 |
| Expected @throws tag for 'InterruptedException'. | 176 |
| '+' should be on a new line. | 197 |
| '*' should be on a new line. | 202 |
| Method 'execute' is not designed for extension - needs to be abstract, final or empty. | 227 |
| Expected @throws tag for 'IOException'. | 227 |
| Expected @throws tag for 'InterruptedException'. | 227 |
| '+' should be on a new line. | 264 |
| '+' should be on a new line. | 265 |
| Expected @throws tag for 'IOException'. | 289 |
| Expected @throws tag for 'InterruptedException'. | 289 |
| Method 'setIsMaster' is not designed for extension - needs to be abstract, final or empty. | 306 |
| Method 'isMaster' is not designed for extension - needs to be abstract, final or empty. | 315 |
| Parameter superstep should be final. | 325 |
| First sentence should end with a period. | 330 |
| Expected @throws tag for 'IOException'. | 348 |
| Expected @throws tag for 'InterruptedException'. | 348 |
| Parameter partitionStatsList should be final. | 379 |
| Parameter superstepTimerContext should be final. | 380 |
| Parameter graphState should be final. | 394 |
| Method 'getGraphFunctions' is not designed for extension - needs to be abstract, final or empty. | 423 |
| First sentence should end with a period. | 427 |
| Missing a Javadoc comment. | 436 |
| Method 'determineClassTypes' is not designed for extension - needs to be abstract, final or empty. | 445 |
| Parameter conf should be final. | 445 |
| 'conf' hides a field. | 445 |
| '3' is a magic number. | 455 |
| '4' is a magic number. | 456 |
| Parameter myClass should be final. | 475 |
| Parameter conf should be final. | 515 |
| Parameter zkManager should be final. | 516 |
| Parameter serverPortList should be final. | 553 |
| 'serverPortList' hides a field. | 553 |
| Parameter sessionMsecTimeout should be final. | 554 |
| Expected @throws tag for 'IOException'. | 554 |
| Expected @throws tag for 'InterruptedException'. | 554 |
| '+' should be on a new line. | 557 |
| Parameter fileClassPaths should be final. | 585 |
| Expected @throws tag for 'IOException'. | 586 |
| '?' should be on a new line. | 598 |
| Avoid inline conditionals. | 598 |
| '+' should be on a new line. | 612 |
| Method 'newSuperstep' is not designed for extension - needs to be abstract, final or empty. | 663 |
| Parameter superstepMetrics should be final. | 664 |
| Method 'notifySentMessages' is not designed for extension - needs to be abstract, final or empty. | 680 |
| Method 'notifyFinishedCommunication' is not designed for extension - needs to be abstract, final or empty. | 699 |
| 'context' hides a field. | 720 |
| Parameter partitionStatsList should be final. | 721 |
| Parameter numPartitions should be final. | 724 |
| Parameter numThreads should be final. | 725 |
| ':' should be on a new line. | 728 |
| Parameter callableId should be final. | 740 |
| Parameter superstep should be final. | 766 |
| Parameter graphState should be final. | 767 |
| Expected @throws tag for 'IOException'. | 767 |
| First sentence should end with a period. | 789 |
| Parameter inputSuperstepStats should be final. | 798 |
| '&&' should be on a new line. | 799 |
| '+' should be on a new line. | 823 |
| First sentence should end with a period. | 855 |
| Method 'cleanup' is not designed for extension - needs to be abstract, final or empty. | 858 |
| Expected @throws tag for 'IOException'. | 859 |
| Expected @throws tag for 'InterruptedException'. | 859 |
| Method 'zooKeeperCleanup' is not designed for extension - needs to be abstract, final or empty. | 889 |
| Method 'workerFailureCleanup' is not designed for extension - needs to be abstract, final or empty. | 902 |
| '+' should be on a new line. | 914 |
| Method 'getConf' is not designed for extension - needs to be abstract, final or empty. | 919 |
| Missing a Javadoc comment. | 919 |
org/apache/giraph/graph/InputSplitEvents.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 29 |
| First sentence should end with a period. | 31 |
| First sentence should end with a period. | 33 |
| First sentence should end with a period. | 35 |
| Parameter progressable should be final. | 43 |
| First sentence should end with a period. | 50 |
| Method 'getAllReadyChanged' is not designed for extension - needs to be abstract, final or empty. | 55 |
| First sentence should end with a period. | 59 |
| Method 'getStateChanged' is not designed for extension - needs to be abstract, final or empty. | 64 |
| First sentence should end with a period. | 68 |
| Method 'getAllDoneChanged' is not designed for extension - needs to be abstract, final or empty. | 73 |
| First sentence should end with a period. | 77 |
| Method 'getDoneStateChanged' is not designed for extension - needs to be abstract, final or empty. | 82 |
org/apache/giraph/graph/InputSplitPaths.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 25 |
| First sentence should end with a period. | 27 |
| First sentence should end with a period. | 29 |
| First sentence should end with a period. | 31 |
| Parameter basePath should be final. | 43 |
| Parameter dir should be final. | 44 |
| Parameter doneDir should be final. | 45 |
| Parameter allReadyNode should be final. | 46 |
| Parameter allDoneNode should be final. | 47 |
| Method 'getPath' is not designed for extension - needs to be abstract, final or empty. | 59 |
| Method 'getAllReadyPath' is not designed for extension - needs to be abstract, final or empty. | 68 |
| Method 'getDonePath' is not designed for extension - needs to be abstract, final or empty. | 76 |
| Method 'getAllDonePath' is not designed for extension - needs to be abstract, final or empty. | 85 |
org/apache/giraph/graph/TaskInfo.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 32 |
| First sentence should end with a period. | 34 |
| First sentence should end with a period. | 36 |
| First sentence should end with a period. | 39 |
| First sentence should end with a period. | 45 |
| Method 'getHostname' is not designed for extension - needs to be abstract, final or empty. | 50 |
| First sentence should end with a period. | 54 |
| Method 'getPort' is not designed for extension - needs to be abstract, final or empty. | 59 |
| First sentence should end with a period. | 63 |
| Method 'setInetSocketAddress' is not designed for extension - needs to be abstract, final or empty. | 68 |
| Parameter address should be final. | 68 |
| First sentence should end with a period. | 73 |
| Method 'getInetSocketAddress' is not designed for extension - needs to be abstract, final or empty. | 78 |
| First sentence should end with a period. | 82 |
| Method 'setTaskId' is not designed for extension - needs to be abstract, final or empty. | 87 |
| Parameter taskId should be final. | 87 |
| 'taskId' hides a field. | 87 |
| First sentence should end with a period. | 91 |
| Method 'getTaskId' is not designed for extension - needs to be abstract, final or empty. | 96 |
| First sentence should end with a period. | 100 |
| Method 'getHostnameId' is not designed for extension - needs to be abstract, final or empty. | 105 |
| Method 'equals' is not designed for extension - needs to be abstract, final or empty. | 109 |
| Parameter other should be final. | 110 |
| '&&' should be on a new line. | 113 |
| '&&' should be on a new line. | 114 |
| '&&' should be on a new line. | 115 |
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 123 |
| '+' should be on a new line. | 125 |
| '+' should be on a new line. | 126 |
| Method 'readFields' is not designed for extension - needs to be abstract, final or empty. | 130 |
| Parameter input should be final. | 131 |
| Method 'write' is not designed for extension - needs to be abstract, final or empty. | 137 |
| Parameter output should be final. | 138 |
| Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. | 144 |
| '17' is a magic number. | 146 |
| '37' is a magic number. | 147 |
| '37' is a magic number. | 148 |
| '37' is a magic number. | 149 |
org/apache/giraph/graph/Vertex.java
| Violation | Message | Line |
|---|---|---|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 64 |
| Parameter id should be final. | 64 |
| 'id' hides a field. | 64 |
| Parameter value should be final. | 64 |
| 'value' hides a field. | 64 |
| Parameter edges should be final. | 64 |
| 'edges' hides a field. | 64 |
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 78 |
| Parameter id should be final. | 78 |
| 'id' hides a field. | 78 |
| Parameter value should be final. | 78 |
| 'value' hides a field. | 78 |
| Method 'setEdges' is not designed for extension - needs to be abstract, final or empty. | 89 |
| Parameter edges should be final. | 89 |
| 'edges' hides a field. | 89 |
| Method 'getId' is not designed for extension - needs to be abstract, final or empty. | 105 |
| First sentence should end with a period. | 109 |
| Method 'getValue' is not designed for extension - needs to be abstract, final or empty. | 114 |
| First sentence should end with a period. | 118 |
| Method 'setValue' is not designed for extension - needs to be abstract, final or empty. | 123 |
| Parameter value should be final. | 123 |
| 'value' hides a field. | 123 |
| Method 'getEdges' is not designed for extension - needs to be abstract, final or empty. | 135 |
| Method 'getMutableEdges' is not designed for extension - needs to be abstract, final or empty. | 147 |
| Method 'unwrapMutableEdges' is not designed for extension - needs to be abstract, final or empty. | 170 |
| Method 'getNumEdges' is not designed for extension - needs to be abstract, final or empty. | 181 |
| Method 'getEdgeValue' is not designed for extension - needs to be abstract, final or empty. | 195 |
| Parameter targetVertexId should be final. | 195 |
| Method 'setEdgeValue' is not designed for extension - needs to be abstract, final or empty. | 218 |
| Parameter targetVertexId should be final. | 218 |
| Parameter edgeValue should be final. | 218 |
| Method 'getAllEdgeValues' is not designed for extension - needs to be abstract, final or empty. | 244 |
| Method 'voteToHalt' is not designed for extension - needs to be abstract, final or empty. | 287 |
| Method 'wakeUp' is not designed for extension - needs to be abstract, final or empty. | 294 |
| Method 'isHalted' is not designed for extension - needs to be abstract, final or empty. | 303 |
| First sentence should end with a period. | 307 |
| Method 'addEdge' is not designed for extension - needs to be abstract, final or empty. | 312 |
| Parameter edge should be final. | 312 |
| Method 'removeEdges' is not designed for extension - needs to be abstract, final or empty. | 321 |
| Parameter targetVertexId should be final. | 321 |
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 325 |
| '+' should be on a new line. | 327 |
org/apache/giraph/graph/VertexChanges.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 54 |
org/apache/giraph/graph/VertexEdgeCount.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 25 |
| First sentence should end with a period. | 27 |
| Parameter vertexCount should be final. | 44 |
| 'vertexCount' hides a field. | 44 |
| Parameter edgeCount should be final. | 44 |
| 'edgeCount' hides a field. | 44 |
| Method 'getVertexCount' is not designed for extension - needs to be abstract, final or empty. | 49 |
| Missing a Javadoc comment. | 49 |
| Method 'getEdgeCount' is not designed for extension - needs to be abstract, final or empty. | 53 |
| Missing a Javadoc comment. | 53 |
| Method 'incrVertexEdgeCount' is not designed for extension - needs to be abstract, final or empty. | 63 |
| Parameter vertexEdgeCount should be final. | 64 |
| Method 'incrVertexEdgeCount' is not designed for extension - needs to be abstract, final or empty. | 77 |
| Parameter vertexCount should be final. | 78 |
| 'vertexCount' hides a field. | 78 |
| Parameter edgeCount should be final. | 78 |
| 'edgeCount' hides a field. | 78 |
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 84 |
org/apache/giraph/graph/VertexMutations.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 49 |
| First sentence should end with a period. | 51 |
| First sentence should end with a period. | 53 |
| First sentence should end with a period. | 55 |
| First sentence should end with a period. | 57 |
| Method 'copy' is not designed for extension - needs to be abstract, final or empty. | 65 |
| Method 'getAddedVertexList' is not designed for extension - needs to be abstract, final or empty. | 75 |
| Method 'readFields' is not designed for extension - needs to be abstract, final or empty. | 80 |
| Parameter input should be final. | 81 |
| Method 'write' is not designed for extension - needs to be abstract, final or empty. | 107 |
| Parameter output should be final. | 108 |
| First sentence should end with a period. | 125 |
| Method 'addVertex' is not designed for extension - needs to be abstract, final or empty. | 130 |
| Parameter vertex should be final. | 130 |
| Method 'getRemovedVertexCount' is not designed for extension - needs to be abstract, final or empty. | 134 |
| First sentence should end with a period. | 139 |
| Method 'removeVertex' is not designed for extension - needs to be abstract, final or empty. | 142 |
| Method 'getAddedEdgeList' is not designed for extension - needs to be abstract, final or empty. | 146 |
| First sentence should end with a period. | 151 |
| Method 'addEdge' is not designed for extension - needs to be abstract, final or empty. | 156 |
| Parameter edge should be final. | 156 |
| Method 'getRemovedEdgeList' is not designed for extension - needs to be abstract, final or empty. | 160 |
| First sentence should end with a period. | 165 |
| Method 'removeEdge' is not designed for extension - needs to be abstract, final or empty. | 170 |
| Parameter destinationVertexId should be final. | 170 |
| First sentence should end with a period. | 174 |
| Method 'addVertexMutations' is not designed for extension - needs to be abstract, final or empty. | 179 |
| Parameter vertexMutations should be final. | 179 |
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 186 |
| Method 'getConf' is not designed for extension - needs to be abstract, final or empty. | 201 |
| Method 'setConf' is not designed for extension - needs to be abstract, final or empty. | 206 |
| Parameter conf should be final. | 207 |
| 'conf' hides a field. | 207 |
org/apache/giraph/integration/SuperstepHashPartitionerFactory.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 62 |
| Name 'LOG' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 63 |
| Parameter conf should be final. | 71 |
| Parameter allPartitionStatsList should be final. | 77 |
| Parameter availableWorkerInfos should be final. | 78 |
| Parameter maxWorkers should be final. | 79 |
| Parameter superstep should be final. | 80 |
| '+' should be on a new line. | 95 |
| '+' should be on a new line. | 96 |
| ':' should be on a new line. | 101 |
| '?' should be on a new line. | 104 |
| Avoid inline conditionals. | 104 |
| '+' should be on a new line. | 112 |
| Method 'createMasterGraphPartitioner' is not designed for extension - needs to be abstract, final or empty. | 120 |
org/apache/giraph/io/BasicVertexValueReader.java
| Violation | Message | Line |
|---|---|---|
| Expected @throws tag for 'IOException'. | 41 |
| Expected @throws tag for 'InterruptedException'. | 42 |
| Expected @throws tag for 'IOException'. | 51 |
| Expected @throws tag for 'InterruptedException'. | 52 |
org/apache/giraph/io/EdgeInputFormat.java
| Violation | Message | Line |
|---|---|---|
| Expected @throws tag for 'IOException'. | 57 |
org/apache/giraph/io/EdgeReader.java
| Violation | Message | Line |
|---|---|---|
| Expected @throws tag for 'IOException'. | 51 |
| Expected @throws tag for 'InterruptedException'. | 51 |
| Expected @throws tag for 'IOException'. | 60 |
| Expected @throws tag for 'InterruptedException'. | 60 |
| Expected @throws tag for 'IOException'. | 71 |
| Expected @throws tag for 'InterruptedException'. | 71 |
| Expected @throws tag for 'IOException'. | 82 |
| Expected @throws tag for 'InterruptedException'. | 82 |
| Expected @throws tag for 'IOException'. | 89 |
| Expected @throws tag for 'IOException'. | 99 |
| Expected @throws tag for 'InterruptedException'. | 99 |
org/apache/giraph/io/GiraphInputFormat.java
| Violation | Message | Line |
|---|---|---|
| Expected @throws tag for 'IOException'. | 54 |
| Expected @throws tag for 'InterruptedException'. | 54 |
| Method 'writeInputSplit' is not designed for extension - needs to be abstract, final or empty. | 62 |
| Parameter inputSplit should be final. | 62 |
| Parameter dataOutput should be final. | 63 |
| Expected @throws tag for 'IOException'. | 63 |
| Method 'readInputSplit' is not designed for extension - needs to be abstract, final or empty. | 74 |
| Parameter dataInput should be final. | 74 |
| Expected @throws tag for 'IOException'. | 74 |
| Expected @throws tag for 'ClassNotFoundException'. | 75 |
org/apache/giraph/io/ReverseEdgeDuplicator.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 39 |
| First sentence should end with a period. | 42 |
| First sentence should end with a period. | 44 |
| First sentence should end with a period. | 46 |
| First sentence should end with a period. | 49 |
| Parameter baseReader should be final. | 53 |
| 'baseReader' hides a field. | 53 |
| First sentence should end with a period. | 57 |
| Method 'getBaseReader' is not designed for extension - needs to be abstract, final or empty. | 61 |
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 65 |
| Parameter inputSplit should be final. | 66 |
| Parameter context should be final. | 66 |
| Method 'nextEdge' is not designed for extension - needs to be abstract, final or empty. | 72 |
| Method 'getCurrentSourceId' is not designed for extension - needs to be abstract, final or empty. | 88 |
| Method 'getCurrentEdge' is not designed for extension - needs to be abstract, final or empty. | 97 |
| Method 'close' is not designed for extension - needs to be abstract, final or empty. | 106 |
| Method 'getProgress' is not designed for extension - needs to be abstract, final or empty. | 111 |
org/apache/giraph/io/SimpleVertexWriter.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 27 |
| First sentence should end with a period. | 36 |
| Expected @throws tag for 'IOException'. | 43 |
| Expected @throws tag for 'InterruptedException'. | 44 |
org/apache/giraph/io/VertexInputFormat.java
| Violation | Message | Line |
|---|---|---|
| Expected @throws tag for 'IOException'. | 61 |
org/apache/giraph/io/VertexOutputFormat.java
| Violation | Message | Line |
|---|---|---|
| Expected @throws tag for 'IOException'. | 64 |
| Expected @throws tag for 'InterruptedException'. | 64 |
| Expected @throws tag for 'InterruptedException'. | 79 |
| Expected @throws tag for 'IOException'. | 92 |
| Expected @throws tag for 'InterruptedException'. | 92 |
org/apache/giraph/io/VertexReader.java
| Violation | Message | Line |
|---|---|---|
| Expected @throws tag for 'IOException'. | 52 |
| Expected @throws tag for 'InterruptedException'. | 52 |
| Expected @throws tag for 'IOException'. | 60 |
| Expected @throws tag for 'InterruptedException'. | 61 |
| Expected @throws tag for 'IOException'. | 72 |
| Expected @throws tag for 'InterruptedException'. | 72 |
| Expected @throws tag for 'IOException'. | 79 |
| Expected @throws tag for 'IOException'. | 89 |
| Expected @throws tag for 'InterruptedException'. | 89 |
org/apache/giraph/io/VertexValueInputFormat.java
| Violation | Message | Line |
|---|---|---|
| Expected @throws tag for 'IOException'. | 48 |
| Parameter split should be final. | 52 |
| Parameter context should be final. | 52 |
org/apache/giraph/io/VertexValueReader.java
| Violation | Message | Line |
|---|---|---|
| Parameter inputSplit should be final. | 37 |
| Parameter context should be final. | 37 |
org/apache/giraph/io/VertexWriter.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 27 |
| Expected @throws tag for 'IOException'. | 48 |
| Expected @throws tag for 'InterruptedException'. | 48 |
| Expected @throws tag for 'IOException'. | 58 |
| Expected @throws tag for 'InterruptedException'. | 58 |
org/apache/giraph/io/filters/DefaultEdgeInputFilter.java
| Violation | Message | Line |
|---|---|---|
| Method 'dropEdge' is not designed for extension - needs to be abstract, final or empty. | 35 |
| Parameter sourceId should be final. | 36 |
| Parameter edge should be final. | 36 |
org/apache/giraph/io/filters/DefaultVertexInputFilter.java
| Violation | Message | Line |
|---|---|---|
| Method 'dropVertex' is not designed for extension - needs to be abstract, final or empty. | 37 |
| Parameter vertex should be final. | 38 |
org/apache/giraph/io/filters/EdgeInputFilter.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 32 |
org/apache/giraph/io/formats/AdjacencyListTextVertexInputFormat.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 46 |
| First sentence should end with a period. | 48 |
| First sentence should end with a period. | 73 |
| Parameter sanitizer should be final. | 90 |
| 'sanitizer' hides a field. | 90 |
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 94 |
| Parameter inputSplit should be final. | 95 |
| Parameter context should be final. | 95 |
| Method 'preprocessLine' is not designed for extension - needs to be abstract, final or empty. | 102 |
| Parameter line should be final. | 103 |
| Method 'getId' is not designed for extension - needs to be abstract, final or empty. | 118 |
| Parameter values should be final. | 119 |
| Method 'getValue' is not designed for extension - needs to be abstract, final or empty. | 131 |
| Parameter values should be final. | 132 |
| Method 'getEdges' is not designed for extension - needs to be abstract, final or empty. | 145 |
| Parameter values should be final. | 146 |
| First sentence should end with a period. | 157 |
org/apache/giraph/io/formats/AdjacencyListTextVertexOutputFormat.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 43 |
| First sentence should end with a period. | 45 |
| Method 'createVertexWriter' is not designed for extension - needs to be abstract, final or empty. | 49 |
| Parameter context should be final. | 51 |
| First sentence should end with a period. | 60 |
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 63 |
| Parameter context should be final. | 64 |
| Method 'convertVertexToLine' is not designed for extension - needs to be abstract, final or empty. | 71 |
| Parameter vertex should be final. | 72 |
org/apache/giraph/io/formats/GeneratedVertexInputFormat.java
| Violation | Message | Line |
|---|---|---|
| Method 'getSplits' is not designed for extension - needs to be abstract, final or empty. | 44 |
| Parameter context should be final. | 45 |
| Parameter minSplitCountHint should be final. | 45 |
org/apache/giraph/io/formats/GiraphFileInputFormat.java
| Violation | Message | Line |
|---|---|---|
| Parameter p should be final. | 70 |
| Parameter conf should be final. | 87 |
| Parameter path should be final. | 88 |
| Expected @throws tag for 'IOException'. | 88 |
| Avoid inline conditionals. | 91 |
| Parameter conf should be final. | 100 |
| Parameter path should be final. | 101 |
| Parameter conf should be final. | 112 |
| Parameter path should be final. | 113 |
| Expected @throws tag for 'IOException'. | 113 |
| Avoid inline conditionals. | 116 |
| Parameter conf should be final. | 125 |
| Parameter path should be final. | 126 |
| Parameter conf should be final. | 139 |
| Parameter path should be final. | 139 |
| Parameter context should be final. | 151 |
| Parameter context should be final. | 167 |
| Parameter filters should be final. | 191 |
| 'filters' hides a field. | 191 |
| Parameter path should be final. | 201 |
| Parameter job should be final. | 219 |
| Parameter dirs should be final. | 219 |
| Expected @throws tag for 'IOException'. | 220 |
| Method 'listVertexStatus' is not designed for extension - needs to be abstract, final or empty. | 277 |
| Parameter job should be final. | 277 |
| Method 'listEdgeStatus' is not designed for extension - needs to be abstract, final or empty. | 289 |
| Parameter job should be final. | 289 |
| Parameter job should be final. | 302 |
| Parameter files should be final. | 302 |
| Expected @throws tag for 'IOException'. | 303 |
| Method 'getVertexSplits' is not designed for extension - needs to be abstract, final or empty. | 349 |
| Parameter job should be final. | 349 |
| Expected @throws tag for 'IOException'. | 349 |
| Method 'getEdgeSplits' is not designed for extension - needs to be abstract, final or empty. | 365 |
| Parameter job should be final. | 365 |
| Expected @throws tag for 'IOException'. | 365 |
org/apache/giraph/io/formats/GiraphTextInputFormat.java
| Violation | Message | Line |
|---|---|---|
| Method 'createRecordReader' is not designed for extension - needs to be abstract, final or empty. | 39 |
| Parameter split should be final. | 41 |
| Parameter context should be final. | 41 |
| Method 'isSplitable' is not designed for extension - needs to be abstract, final or empty. | 45 |
| Parameter context should be final. | 46 |
| Parameter file should be final. | 46 |
org/apache/giraph/io/formats/IdWithValueTextOutputFormat.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 44 |
| First sentence should end with a period. | 46 |
| Method 'createVertexWriter' is not designed for extension - needs to be abstract, final or empty. | 53 |
| Parameter context should be final. | 54 |
| First sentence should end with a period. | 62 |
| First sentence should end with a period. | 64 |
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 67 |
| Parameter context should be final. | 68 |
| Method 'convertVertexToLine' is not designed for extension - needs to be abstract, final or empty. | 77 |
| Parameter vertex should be final. | 78 |
org/apache/giraph/io/formats/IntIntNullTextInputFormat.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 42 |
| Method 'createVertexReader' is not designed for extension - needs to be abstract, final or empty. | 45 |
| Parameter split should be final. | 46 |
| Parameter context should be final. | 47 |
| First sentence should end with a period. | 57 |
| Method 'preprocessLine' is not designed for extension - needs to be abstract, final or empty. | 62 |
| Parameter line should be final. | 63 |
| Method 'getId' is not designed for extension - needs to be abstract, final or empty. | 69 |
| Parameter tokens should be final. | 70 |
| Method 'getValue' is not designed for extension - needs to be abstract, final or empty. | 74 |
| Parameter tokens should be final. | 75 |
| Method 'getEdges' is not designed for extension - needs to be abstract, final or empty. | 79 |
| Parameter tokens should be final. | 81 |
org/apache/giraph/io/formats/IntIntTextVertexValueInputFormat.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 41 |
| Method 'createVertexValueReader' is not designed for extension - needs to be abstract, final or empty. | 44 |
| Parameter split should be final. | 46 |
| Parameter context should be final. | 46 |
| Method 'preprocessLine' is not designed for extension - needs to be abstract, final or empty. | 57 |
| Parameter line should be final. | 58 |
| Method 'getId' is not designed for extension - needs to be abstract, final or empty. | 64 |
| Parameter data should be final. | 65 |
| Method 'getValue' is not designed for extension - needs to be abstract, final or empty. | 69 |
| Parameter data should be final. | 70 |
org/apache/giraph/io/formats/IntNullNullTextInputFormat.java
| Violation | Message | Line |
|---|---|---|
| Method 'createVertexReader' is not designed for extension - needs to be abstract, final or empty. | 38 |
| Parameter split should be final. | 40 |
| Parameter context should be final. | 40 |
| First sentence should end with a period. | 49 |
| Method 'preprocessLine' is not designed for extension - needs to be abstract, final or empty. | 52 |
| Parameter line should be final. | 53 |
| Method 'getId' is not designed for extension - needs to be abstract, final or empty. | 58 |
| Parameter line should be final. | 59 |
| Method 'getValue' is not designed for extension - needs to be abstract, final or empty. | 63 |
| Parameter line should be final. | 64 |
| Method 'getEdges' is not designed for extension - needs to be abstract, final or empty. | 68 |
| Parameter line should be final. | 69 |
org/apache/giraph/io/formats/IntNullReverseTextEdgeInputFormat.java
| Violation | Message | Line |
|---|---|---|
| Method 'createEdgeReader' is not designed for extension - needs to be abstract, final or empty. | 40 |
| Parameter split should be final. | 42 |
| Parameter context should be final. | 42 |
org/apache/giraph/io/formats/IntNullTextEdgeInputFormat.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 40 |
| Method 'createEdgeReader' is not designed for extension - needs to be abstract, final or empty. | 43 |
| Parameter split should be final. | 45 |
| Parameter context should be final. | 45 |
| Method 'preprocessLine' is not designed for extension - needs to be abstract, final or empty. | 55 |
| Parameter line should be final. | 56 |
| Method 'getSourceVertexId' is not designed for extension - needs to be abstract, final or empty. | 62 |
| Parameter endpoints should be final. | 63 |
| Method 'getTargetVertexId' is not designed for extension - needs to be abstract, final or empty. | 68 |
| Parameter endpoints should be final. | 69 |
| Method 'getValue' is not designed for extension - needs to be abstract, final or empty. | 74 |
| Parameter endpoints should be final. | 75 |
org/apache/giraph/io/formats/JsonBase64VertexFormat.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 21 |
| Class JsonBase64VertexFormat should be declared as final. | 24 |
| First sentence should end with a period. | 25 |
| First sentence should end with a period. | 27 |
| First sentence should end with a period. | 29 |
org/apache/giraph/io/formats/JsonBase64VertexInputFormat.java
| Violation | Message | Line |
|---|---|---|
| Method 'createVertexReader' is not designed for extension - needs to be abstract, final or empty. | 55 |
| Parameter split should be final. | 56 |
| Parameter context should be final. | 57 |
| First sentence should end with a period. | 61 |
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 68 |
| Parameter inputSplit should be final. | 69 |
| Parameter context should be final. | 69 |
| Method 'preprocessLine' is not designed for extension - needs to be abstract, final or empty. | 74 |
| Parameter line should be final. | 75 |
| Method 'getId' is not designed for extension - needs to be abstract, final or empty. | 84 |
| Parameter vertexObject should be final. | 85 |
| Method 'getValue' is not designed for extension - needs to be abstract, final or empty. | 100 |
| Parameter vertexObject should be final. | 101 |
| Method 'getEdges' is not designed for extension - needs to be abstract, final or empty. | 116 |
| Parameter vertexObject should be final. | 117 |
org/apache/giraph/io/formats/JsonBase64VertexOutputFormat.java
| Violation | Message | Line |
|---|---|---|
| Method 'createVertexWriter' is not designed for extension - needs to be abstract, final or empty. | 52 |
| Parameter context should be final. | 53 |
| First sentence should end with a period. | 57 |
| Method 'convertVertexToLine' is not designed for extension - needs to be abstract, final or empty. | 62 |
| Parameter vertex should be final. | 63 |
org/apache/giraph/io/formats/JsonLongDoubleFloatDoubleVertexInputFormat.java
| Violation | Message | Line |
|---|---|---|
| Method 'createVertexReader' is not designed for extension - needs to be abstract, final or empty. | 45 |
| Parameter split should be final. | 46 |
| Parameter context should be final. | 47 |
| Parameter line should be final. | 67 |
| Unable to get class information for JSONException. | 67 |
| Parameter jsonVertex should be final. | 72 |
| Unable to get class information for JSONException. | 72 |
| Parameter jsonVertex should be final. | 78 |
| Unable to get class information for JSONException. | 79 |
| Parameter jsonVertex should be final. | 85 |
| Unable to get class information for JSONException. | 85 |
| Parameter line should be final. | 99 |
| Parameter jsonVertex should be final. | 99 |
| Parameter e should be final. | 99 |
org/apache/giraph/io/formats/JsonLongDoubleFloatDoubleVertexOutputFormat.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 33 |
| Method 'createVertexWriter' is not designed for extension - needs to be abstract, final or empty. | 41 |
| Parameter context should be final. | 43 |
| Parameter vertex should be final. | 55 |
org/apache/giraph/io/formats/LongDoubleDoubleAdjacencyListVertexInputFormat.java
| Violation | Message | Line |
|---|---|---|
| Method 'createVertexReader' is not designed for extension - needs to be abstract, final or empty. | 39 |
| Parameter split should be final. | 40 |
| Parameter context should be final. | 41 |
| Parameter lineSanitizer should be final. | 57 |
| Method 'decodeId' is not designed for extension - needs to be abstract, final or empty. | 62 |
| Parameter s should be final. | 63 |
| Method 'decodeValue' is not designed for extension - needs to be abstract, final or empty. | 67 |
| Parameter s should be final. | 68 |
| Method 'decodeEdge' is not designed for extension - needs to be abstract, final or empty. | 72 |
| Parameter s1 should be final. | 73 |
| Parameter s2 should be final. | 73 |
org/apache/giraph/io/formats/PseudoRandomEdgeInputFormat.java
| Violation | Message | Line |
|---|---|---|
| Method 'createEdgeReader' is not designed for extension - needs to be abstract, final or empty. | 52 |
| Parameter split should be final. | 54 |
| Parameter context should be final. | 54 |
| Parameter inputSplit should be final. | 91 |
| Parameter context should be final. | 91 |
| '*' should be on a new line. | 108 |
| '+' should be on a new line. | 109 |
| '+' should be on a new line. | 114 |
| '||' should be on a new line. | 132 |
| '&&' should be on a new line. | 133 |
| '+' should be on a new line. | 168 |
| '*' should be on a new line. | 181 |
| '100.0f' is a magic number. | 182 |
org/apache/giraph/io/formats/PseudoRandomInputFormatConstants.java
| Violation | Message | Line |
|---|---|---|
| Class PseudoRandomInputFormatConstants should be declared as final. | 24 |
org/apache/giraph/io/formats/PseudoRandomIntNullLocalEdgesHelper.java
| Violation | Message | Line |
|---|---|---|
| Parameter numVertices should be final. | 50 |
| 'numVertices' hides a field. | 50 |
| Parameter conf should be final. | 51 |
| Method 'generateDestVertex' is not designed for extension - needs to be abstract, final or empty. | 73 |
| Parameter sourceVertexId should be final. | 73 |
| Parameter rand should be final. | 73 |
org/apache/giraph/io/formats/PseudoRandomIntNullVertexInputFormat.java
| Violation | Message | Line |
|---|---|---|
| Method 'createVertexReader' is not designed for extension - needs to be abstract, final or empty. | 55 |
| Parameter split should be final. | 57 |
| Parameter context should be final. | 58 |
| First sentence should end with a period. | 76 |
| First sentence should end with a period. | 78 |
| First sentence should end with a period. | 82 |
| Parameter inputSplit should be final. | 90 |
| Parameter context should be final. | 91 |
| '*' should be on a new line. | 100 |
| '+' should be on a new line. | 101 |
| Avoid inline conditionals. | 134 |
| '100.0f' is a magic number. | 150 |
org/apache/giraph/io/formats/PseudoRandomLocalEdgesHelper.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 36 |
| Parameter numVertices should be final. | 52 |
| 'numVertices' hides a field. | 52 |
| Parameter minLocalEdgesRatio should be final. | 53 |
| 'minLocalEdgesRatio' hides a field. | 53 |
| Parameter conf should be final. | 54 |
| Method 'generateDestVertex' is not designed for extension - needs to be abstract, final or empty. | 78 |
| Parameter sourceVertexId should be final. | 78 |
| Parameter rand should be final. | 78 |
| '+' should be on a new line. | 84 |
| '+' should be on a new line. | 88 |
org/apache/giraph/io/formats/PseudoRandomUtils.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 28 |
| Class PseudoRandomUtils should be declared as final. | 31 |
| First sentence should end with a period. | 32 |
| First sentence should end with a period. | 35 |
| Parameter numSplits should be final. | 41 |
| Expected @throws tag for 'IOException'. | 41 |
| Expected @throws tag for 'InterruptedException'. | 42 |
org/apache/giraph/io/formats/PseudoRandomVertexInputFormat.java
| Violation | Message | Line |
|---|---|---|
| Method 'createVertexReader' is not designed for extension - needs to be abstract, final or empty. | 53 |
| Parameter split should be final. | 55 |
| Parameter context should be final. | 55 |
| Parameter inputSplit should be final. | 91 |
| Parameter context should be final. | 92 |
| '*' should be on a new line. | 108 |
| '+' should be on a new line. | 109 |
| '+' should be on a new line. | 114 |
| '+' should be on a new line. | 164 |
| '+' should be on a new line. | 165 |
| '+' should be on a new line. | 166 |
| '100.0f' is a magic number. | 177 |
org/apache/giraph/io/formats/SequenceFileVertexInputFormat.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 45 |
| Variable 'sequenceFileInputFormat' must be private and have accessor methods. | 46 |
| Method 'getSplits' is not designed for extension - needs to be abstract, final or empty. | 49 |
| Parameter context should be final. | 50 |
| Parameter minSplitCountHint should be final. | 50 |
| Method 'createVertexReader' is not designed for extension - needs to be abstract, final or empty. | 55 |
| Parameter split should be final. | 56 |
| Parameter context should be final. | 57 |
| First sentence should end with a period. | 73 |
| Parameter recordReader should be final. | 81 |
| 'recordReader' hides a field. | 81 |
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 85 |
| Parameter inputSplit should be final. | 85 |
| Parameter context should be final. | 86 |
| Method 'nextVertex' is not designed for extension - needs to be abstract, final or empty. | 90 |
| Method 'getCurrentVertex' is not designed for extension - needs to be abstract, final or empty. | 95 |
| Method 'close' is not designed for extension - needs to be abstract, final or empty. | 101 |
| Method 'getProgress' is not designed for extension - needs to be abstract, final or empty. | 105 |
org/apache/giraph/io/formats/SequenceFileVertexOutputFormat.java
| Violation | Message | Line |
|---|---|---|
| Method 'checkOutputSpecs' is not designed for extension - needs to be abstract, final or empty. | 58 |
| Parameter context should be final. | 59 |
| Method 'getOutputCommitter' is not designed for extension - needs to be abstract, final or empty. | 64 |
| Parameter context should be final. | 65 |
| Method 'createVertexWriter' is not designed for extension - needs to be abstract, final or empty. | 70 |
| Parameter context should be final. | 71 |
| Parameter context should be final. | 102 |
| Parameter vertex should be final. | 108 |
| Parameter context should be final. | 118 |
org/apache/giraph/io/formats/TextDoubleDoubleAdjacencyListVertexInputFormat.java
| Violation | Message | Line |
|---|---|---|
| Method 'createVertexReader' is not designed for extension - needs to be abstract, final or empty. | 36 |
| Parameter split should be final. | 37 |
| Parameter context should be final. | 38 |
| First sentence should end with a period. | 42 |
| Parameter lineSanitizer should be final. | 54 |
| Method 'decodeId' is not designed for extension - needs to be abstract, final or empty. | 59 |
| Parameter s should be final. | 60 |
| Method 'decodeValue' is not designed for extension - needs to be abstract, final or empty. | 64 |
| Parameter s should be final. | 65 |
| Method 'decodeEdge' is not designed for extension - needs to be abstract, final or empty. | 69 |
| Parameter s1 should be final. | 70 |
| Parameter s2 should be final. | 70 |
org/apache/giraph/io/formats/TextEdgeInputFormat.java
| Violation | Message | Line |
|---|---|---|
| Variable 'textInputFormat' must be private and have accessor methods. | 47 |
| Method 'getSplits' is not designed for extension - needs to be abstract, final or empty. | 49 |
| Parameter context should be final. | 51 |
| Parameter minSplitCountHint should be final. | 51 |
| First sentence should end with a period. | 62 |
| First sentence should end with a period. | 64 |
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 67 |
| Parameter inputSplit should be final. | 68 |
| Parameter context should be final. | 68 |
| 'context' hides a field. | 68 |
| Method 'createLineRecordReader' is not designed for extension - needs to be abstract, final or empty. | 90 |
| Parameter inputSplit should be final. | 91 |
| Parameter context should be final. | 91 |
| 'context' hides a field. | 91 |
| Method 'close' is not designed for extension - needs to be abstract, final or empty. | 96 |
| Method 'getProgress' is not designed for extension - needs to be abstract, final or empty. | 101 |
| Method 'getRecordReader' is not designed for extension - needs to be abstract, final or empty. | 111 |
| Method 'getContext' is not designed for extension - needs to be abstract, final or empty. | 120 |
| First sentence should end with a period. | 198 |
| Method 'getCurrentSourceId' is not designed for extension - needs to be abstract, final or empty. | 201 |
| First sentence should end with a period. | 237 |
org/apache/giraph/io/formats/TextVertexInputFormat.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 48 |
| Variable 'textInputFormat' must be private and have accessor methods. | 49 |
| Method 'getSplits' is not designed for extension - needs to be abstract, final or empty. | 51 |
| Parameter context should be final. | 52 |
| Parameter minSplitCountHint should be final. | 52 |
| Expected @throws tag for 'IOException'. | 72 |
| First sentence should end with a period. | 86 |
| First sentence should end with a period. | 88 |
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 91 |
| Parameter inputSplit should be final. | 92 |
| Parameter context should be final. | 92 |
| 'context' hides a field. | 92 |
| Method 'createLineRecordReader' is not designed for extension - needs to be abstract, final or empty. | 114 |
| Parameter inputSplit should be final. | 115 |
| Parameter context should be final. | 115 |
| 'context' hides a field. | 115 |
| Method 'close' is not designed for extension - needs to be abstract, final or empty. | 120 |
| Method 'getProgress' is not designed for extension - needs to be abstract, final or empty. | 125 |
| Method 'getRecordReader' is not designed for extension - needs to be abstract, final or empty. | 135 |
| Method 'getContext' is not designed for extension - needs to be abstract, final or empty. | 144 |
| Redundant throws: 'IOException' is subclass of 'X'. | 343 |
| Redundant throws: 'IOException' is subclass of 'X'. | 358 |
| Redundant throws: 'IOException' is subclass of 'X'. | 373 |
| Redundant throws: 'IOException' is subclass of 'X'. | 390 |
| Method 'handleException' is not designed for extension - needs to be abstract, final or empty. | 404 |
| Parameter line should be final. | 404 |
| Parameter processed should be final. | 404 |
| Parameter e should be final. | 404 |
org/apache/giraph/io/formats/TextVertexOutputFormat.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 47 |
| Variable 'textOutputFormat' must be private and have accessor methods. | 48 |
| Method 'checkOutputSpecs' is not designed for extension - needs to be abstract, final or empty. | 51 |
| Parameter context should be final. | 52 |
| Method 'getOutputCommitter' is not designed for extension - needs to be abstract, final or empty. | 57 |
| Parameter context should be final. | 58 |
| Expected @throws tag for 'IOException'. | 74 |
| Expected @throws tag for 'InterruptedException'. | 74 |
| First sentence should end with a period. | 83 |
| First sentence should end with a period. | 85 |
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 88 |
| Parameter context should be final. | 89 |
| 'context' hides a field. | 89 |
| Method 'createLineRecordWriter' is not designed for extension - needs to be abstract, final or empty. | 108 |
| Parameter context should be final. | 109 |
| 'context' hides a field. | 109 |
| Method 'close' is not designed for extension - needs to be abstract, final or empty. | 113 |
| Parameter context should be final. | 114 |
| 'context' hides a field. | 114 |
| Method 'getRecordWriter' is not designed for extension - needs to be abstract, final or empty. | 124 |
| Method 'getContext' is not designed for extension - needs to be abstract, final or empty. | 133 |
| Parameter vertex should be final. | 146 |
org/apache/giraph/io/formats/TextVertexValueInputFormat.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 47 |
| Variable 'textInputFormat' must be private and have accessor methods. | 48 |
| Method 'getSplits' is not designed for extension - needs to be abstract, final or empty. | 50 |
| Parameter context should be final. | 51 |
| Parameter minSplitCountHint should be final. | 51 |
| First sentence should end with a period. | 67 |
| First sentence should end with a period. | 69 |
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 72 |
| Parameter inputSplit should be final. | 73 |
| Parameter context should be final. | 73 |
| 'context' hides a field. | 73 |
| Method 'createLineRecordReader' is not designed for extension - needs to be abstract, final or empty. | 96 |
| Parameter inputSplit should be final. | 97 |
| Parameter context should be final. | 97 |
| 'context' hides a field. | 97 |
| Method 'close' is not designed for extension - needs to be abstract, final or empty. | 102 |
| Method 'getProgress' is not designed for extension - needs to be abstract, final or empty. | 107 |
| Method 'getRecordReader' is not designed for extension - needs to be abstract, final or empty. | 117 |
| Method 'getContext' is not designed for extension - needs to be abstract, final or empty. | 126 |
| Expected @throws tag for 'IOException'. | 197 |
| Expected @throws tag for 'InterruptedException'. | 197 |
| Method 'getCurrentVertexId' is not designed for extension - needs to be abstract, final or empty. | 204 |
| Method 'getCurrentVertexValue' is not designed for extension - needs to be abstract, final or empty. | 210 |
org/apache/giraph/io/formats/multi/EdgeInputFormatDescription.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 55 |
| Parameter edgeInputFormatClass should be final. | 61 |
| First sentence should end with a period. | 65 |
| Parameter description should be final. | 70 |
| First sentence should end with a period. | 74 |
| Parameter conf should be final. | 83 |
| Parameter conf should be final. | 101 |
| '+' should be on a new line. | 117 |
| '+' should be on a new line. | 118 |
| First sentence should end with a period. | 123 |
| Parameter conf should be final. | 133 |
org/apache/giraph/io/formats/multi/InputFormatDescription.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 42 |
| First sentence should end with a period. | 44 |
| First sentence should end with a period. | 47 |
| Parameter inputFormatClass should be final. | 52 |
| 'inputFormatClass' hides a field. | 52 |
| First sentence should end with a period. | 56 |
| Parameter description should be final. | 62 |
| '+' should be on a new line. | 74 |
| First sentence should end with a period. | 79 |
| Method 'addParameter' is not designed for extension - needs to be abstract, final or empty. | 85 |
| Parameter name should be final. | 85 |
| Parameter value should be final. | 85 |
| First sentence should end with a period. | 89 |
| Method 'addParameters' is not designed for extension - needs to be abstract, final or empty. | 94 |
| Parameter parametersJson should be final. | 94 |
| '+' should be on a new line. | 101 |
| First sentence should end with a period. | 107 |
| Method 'toJsonArray' is not designed for extension - needs to be abstract, final or empty. | 112 |
| '+' should be on a new line. | 120 |
| '+' should be on a new line. | 121 |
| Method 'getInputFormatClass' is not designed for extension - needs to be abstract, final or empty. | 129 |
| Missing a Javadoc comment. | 129 |
| Method 'setInputFormatClass' is not designed for extension - needs to be abstract, final or empty. | 133 |
| Missing a Javadoc comment. | 133 |
| Parameter inputFormatClass should be final. | 133 |
| 'inputFormatClass' hides a field. | 133 |
| First sentence should end with a period. | 137 |
| Method 'putParametersToConfiguration' is not designed for extension - needs to be abstract, final or empty. | 142 |
| Parameter conf should be final. | 142 |
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 148 |
| First sentence should end with a period. | 153 |
| Parameter descriptions should be final. | 160 |
org/apache/giraph/io/formats/multi/InputSplitWithInputFormatIndex.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 34 |
| First sentence should end with a period. | 36 |
| First sentence should end with a period. | 39 |
| Parameter split should be final. | 45 |
| 'split' hides a field. | 45 |
| Parameter inputFormatIndex should be final. | 45 |
| 'inputFormatIndex' hides a field. | 45 |
| Missing a Javadoc comment. | 60 |
| Missing a Javadoc comment. | 64 |
org/apache/giraph/io/formats/multi/MultiEdgeInputFormat.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 46 |
| Method 'setConf' is not designed for extension - needs to be abstract, final or empty. | 49 |
| Parameter conf should be final. | 51 |
| '+' should be on a new line. | 56 |
| Method 'createEdgeReader' is not designed for extension - needs to be abstract, final or empty. | 61 |
| Parameter inputSplit should be final. | 62 |
| Parameter context should be final. | 63 |
| Parameter inputSplit should be final. | 77 |
| Parameter context should be final. | 78 |
| '+' should be on a new line. | 89 |
| Method 'getSplits' is not designed for extension - needs to be abstract, final or empty. | 94 |
| Parameter context should be final. | 95 |
| Parameter minSplitCountHint should be final. | 96 |
| Method 'writeInputSplit' is not designed for extension - needs to be abstract, final or empty. | 105 |
| Parameter inputSplit should be final. | 106 |
| Parameter dataOutput should be final. | 107 |
| Method 'readInputSplit' is not designed for extension - needs to be abstract, final or empty. | 111 |
| Parameter dataInput should be final. | 113 |
org/apache/giraph/io/formats/multi/MultiInputUtils.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 32 |
| Class MultiInputUtils should be declared as final. | 36 |
| First sentence should end with a period. | 37 |
| Parameter context should be final. | 49 |
| Parameter minSplitCountHint should be final. | 50 |
| Parameter inputFormats should be final. | 51 |
| Expected @throws tag for 'IOException'. | 51 |
| Expected @throws tag for 'InterruptedException'. | 52 |
| Parameter inputSplit should be final. | 72 |
| Parameter dataOutput should be final. | 73 |
| Parameter inputFormats should be final. | 74 |
| Expected @throws tag for 'IOException'. | 74 |
| '+' should be on a new line. | 82 |
| Parameter dataInput should be final. | 96 |
| Parameter inputFormats should be final. | 97 |
| Expected @throws tag for 'IOException'. | 97 |
| Expected @throws tag for 'ClassNotFoundException'. | 98 |
org/apache/giraph/io/formats/multi/MultiVertexInputFormat.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 47 |
| Method 'setConf' is not designed for extension - needs to be abstract, final or empty. | 50 |
| Parameter conf should be final. | 52 |
| '+' should be on a new line. | 57 |
| Method 'createVertexReader' is not designed for extension - needs to be abstract, final or empty. | 62 |
| Parameter inputSplit should be final. | 63 |
| Parameter context should be final. | 64 |
| Parameter inputSplit should be final. | 78 |
| Parameter context should be final. | 79 |
| '+' should be on a new line. | 90 |
| '+' should be on a new line. | 91 |
| Method 'getSplits' is not designed for extension - needs to be abstract, final or empty. | 96 |
| Parameter context should be final. | 97 |
| Parameter minSplitCountHint should be final. | 98 |
| Method 'writeInputSplit' is not designed for extension - needs to be abstract, final or empty. | 107 |
| Parameter inputSplit should be final. | 108 |
| Parameter dataOutput should be final. | 109 |
| Method 'readInputSplit' is not designed for extension - needs to be abstract, final or empty. | 113 |
| Parameter dataInput should be final. | 115 |
org/apache/giraph/io/formats/multi/VertexInputFormatDescription.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 57 |
| Parameter vertexInputFormatClass should be final. | 63 |
| First sentence should end with a period. | 67 |
| Parameter description should be final. | 72 |
| First sentence should end with a period. | 76 |
| Parameter conf should be final. | 85 |
| Parameter conf should be final. | 105 |
| '+' should be on a new line. | 121 |
| '+' should be on a new line. | 122 |
| First sentence should end with a period. | 127 |
| Parameter conf should be final. | 139 |
org/apache/giraph/io/internal/WrappedEdgeInputFormat.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 47 |
| First sentence should end with a period. | 50 |
| Parameter edgeInputFormat should be final. | 56 |
| Method 'getSplits' is not designed for extension - needs to be abstract, final or empty. | 60 |
| Parameter context should be final. | 61 |
| Parameter minSplitCountHint should be final. | 62 |
| Method 'createEdgeReader' is not designed for extension - needs to be abstract, final or empty. | 67 |
| Parameter split should be final. | 68 |
| Parameter context should be final. | 69 |
| Method 'writeInputSplit' is not designed for extension - needs to be abstract, final or empty. | 76 |
| Parameter inputSplit should be final. | 77 |
| Parameter dataOutput should be final. | 78 |
| Method 'readInputSplit' is not designed for extension - needs to be abstract, final or empty. | 82 |
| Parameter dataInput should be final. | 84 |
org/apache/giraph/io/internal/WrappedEdgeReader.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 43 |
| First sentence should end with a period. | 46 |
| Parameter baseEdgeReader should be final. | 52 |
| 'baseEdgeReader' hides a field. | 52 |
| Parameter conf should be final. | 53 |
| Parameter conf should be final. | 61 |
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 65 |
| Parameter inputSplit should be final. | 66 |
| Parameter context should be final. | 67 |
| Method 'nextEdge' is not designed for extension - needs to be abstract, final or empty. | 72 |
| Method 'getCurrentSourceId' is not designed for extension - needs to be abstract, final or empty. | 77 |
| Method 'getCurrentEdge' is not designed for extension - needs to be abstract, final or empty. | 82 |
| Method 'close' is not designed for extension - needs to be abstract, final or empty. | 87 |
| Method 'getProgress' is not designed for extension - needs to be abstract, final or empty. | 92 |
org/apache/giraph/io/internal/WrappedVertexInputFormat.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 49 |
| First sentence should end with a period. | 52 |
| Parameter vertexInputFormat should be final. | 58 |
| Method 'getSplits' is not designed for extension - needs to be abstract, final or empty. | 62 |
| Parameter context should be final. | 63 |
| Parameter minSplitCountHint should be final. | 64 |
| Method 'createVertexReader' is not designed for extension - needs to be abstract, final or empty. | 69 |
| Parameter split should be final. | 70 |
| Parameter context should be final. | 71 |
| Method 'writeInputSplit' is not designed for extension - needs to be abstract, final or empty. | 78 |
| Parameter inputSplit should be final. | 79 |
| Parameter dataOutput should be final. | 80 |
| Method 'readInputSplit' is not designed for extension - needs to be abstract, final or empty. | 84 |
| Parameter dataInput should be final. | 86 |
org/apache/giraph/io/internal/WrappedVertexOutputFormat.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 51 |
| First sentence should end with a period. | 54 |
| Parameter vertexOutputFormat should be final. | 60 |
| Method 'createVertexWriter' is not designed for extension - needs to be abstract, final or empty. | 64 |
| Parameter context should be final. | 66 |
| Parameter conf should be final. | 73 |
| Parameter context should be final. | 80 |
| Parameter context should be final. | 87 |
| Parameter vertex should be final. | 94 |
| Method 'checkOutputSpecs' is not designed for extension - needs to be abstract, final or empty. | 100 |
| Parameter context should be final. | 102 |
| Method 'getOutputCommitter' is not designed for extension - needs to be abstract, final or empty. | 107 |
| Parameter context should be final. | 109 |
| Parameter context should be final. | 115 |
| Parameter context should be final. | 121 |
| Parameter context should be final. | 128 |
| Parameter context should be final. | 134 |
| Parameter context should be final. | 140 |
| Parameter context should be final. | 146 |
| Parameter context should be final. | 153 |
| Parameter context should be final. | 159 |
| Parameter state should be final. | 160 |
org/apache/giraph/io/internal/WrappedVertexReader.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 44 |
| First sentence should end with a period. | 47 |
| Parameter baseVertexReader should be final. | 53 |
| 'baseVertexReader' hides a field. | 53 |
| Parameter conf should be final. | 54 |
| Parameter conf should be final. | 62 |
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 66 |
| Parameter inputSplit should be final. | 67 |
| Parameter context should be final. | 68 |
| Method 'nextVertex' is not designed for extension - needs to be abstract, final or empty. | 73 |
| Method 'getCurrentVertex' is not designed for extension - needs to be abstract, final or empty. | 78 |
| Method 'close' is not designed for extension - needs to be abstract, final or empty. | 84 |
| Method 'getProgress' is not designed for extension - needs to be abstract, final or empty. | 89 |
org/apache/giraph/io/iterables/EdgeReaderWrapper.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 31 |
| First sentence should end with a period. | 39 |
| First sentence should end with a period. | 41 |
| First sentence should end with a period. | 44 |
| Parameter edgeReader should be final. | 49 |
| 'edgeReader' hides a field. | 49 |
| Method 'setConf' is not designed for extension - needs to be abstract, final or empty. | 54 |
| Parameter conf should be final. | 56 |
| Method 'nextEdge' is not designed for extension - needs to be abstract, final or empty. | 61 |
| Method 'getCurrentSourceId' is not designed for extension - needs to be abstract, final or empty. | 66 |
| Method 'getCurrentEdge' is not designed for extension - needs to be abstract, final or empty. | 71 |
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 76 |
| Parameter inputSplit should be final. | 77 |
| Parameter context should be final. | 78 |
| Method 'close' is not designed for extension - needs to be abstract, final or empty. | 82 |
| Method 'getProgress' is not designed for extension - needs to be abstract, final or empty. | 87 |
org/apache/giraph/io/iterables/EdgeWithSource.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 25 |
| First sentence should end with a period. | 33 |
| First sentence should end with a period. | 35 |
| First sentence should end with a period. | 38 |
| First sentence should end with a period. | 44 |
| Parameter sourceVertexId should be final. | 50 |
| 'sourceVertexId' hides a field. | 50 |
| Parameter edge should be final. | 50 |
| 'edge' hides a field. | 50 |
| Method 'getSourceVertexId' is not designed for extension - needs to be abstract, final or empty. | 55 |
| Missing a Javadoc comment. | 55 |
| Method 'setSourceVertexId' is not designed for extension - needs to be abstract, final or empty. | 59 |
| Missing a Javadoc comment. | 59 |
| Parameter sourceVertexId should be final. | 59 |
| 'sourceVertexId' hides a field. | 59 |
| Method 'getEdge' is not designed for extension - needs to be abstract, final or empty. | 63 |
| Missing a Javadoc comment. | 63 |
| Method 'setEdge' is not designed for extension - needs to be abstract, final or empty. | 67 |
| Missing a Javadoc comment. | 67 |
| Parameter edge should be final. | 67 |
| 'edge' hides a field. | 67 |
| Method 'getTargetVertexId' is not designed for extension - needs to be abstract, final or empty. | 71 |
| Missing a Javadoc comment. | 71 |
| First sentence should end with a period. | 75 |
| Method 'setTargetVertexId' is not designed for extension - needs to be abstract, final or empty. | 80 |
| Parameter targetVertexId should be final. | 80 |
| Method 'getEdgeValue' is not designed for extension - needs to be abstract, final or empty. | 84 |
| Missing a Javadoc comment. | 84 |
| First sentence should end with a period. | 88 |
| Method 'setEdgeValue' is not designed for extension - needs to be abstract, final or empty. | 93 |
| Parameter value should be final. | 93 |
org/apache/giraph/io/iterables/GiraphReader.java
| Violation | Message | Line |
|---|---|---|
| Expected @throws tag for 'IOException'. | 41 |
| Expected @throws tag for 'InterruptedException'. | 41 |
| Expected @throws tag for 'IOException'. | 48 |
| Expected @throws tag for 'IOException'. | 58 |
| Expected @throws tag for 'InterruptedException'. | 58 |
org/apache/giraph/io/iterables/IteratorToReaderWrapper.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 23 |
| First sentence should end with a period. | 31 |
| First sentence should end with a period. | 33 |
| First sentence should end with a period. | 36 |
| Parameter iterator should be final. | 41 |
| 'iterator' hides a field. | 41 |
| First sentence should end with a period. | 45 |
| Method 'nextObject' is not designed for extension - needs to be abstract, final or empty. | 50 |
| First sentence should end with a period. | 60 |
| Method 'getCurrentObject' is not designed for extension - needs to be abstract, final or empty. | 65 |
org/apache/giraph/io/iterables/VertexReaderWrapper.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 31 |
| First sentence should end with a period. | 40 |
| First sentence should end with a period. | 42 |
| First sentence should end with a period. | 45 |
| Parameter vertexReader should be final. | 50 |
| 'vertexReader' hides a field. | 50 |
| Method 'setConf' is not designed for extension - needs to be abstract, final or empty. | 55 |
| Parameter conf should be final. | 57 |
| Method 'nextVertex' is not designed for extension - needs to be abstract, final or empty. | 62 |
| Method 'getCurrentVertex' is not designed for extension - needs to be abstract, final or empty. | 67 |
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. | 73 |
| Parameter inputSplit should be final. | 74 |
| Parameter context should be final. | 75 |
| Method 'close' is not designed for extension - needs to be abstract, final or empty. | 79 |
| Method 'getProgress' is not designed for extension - needs to be abstract, final or empty. | 84 |
org/apache/giraph/io/iterables/package-info.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 18 |
org/apache/giraph/io/superstep_output/MultiThreadedSuperstepOutput.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 47 |
| First sentence should end with a period. | 49 |
| First sentence should end with a period. | 51 |
| First sentence should end with a period. | 53 |
| First sentence should end with a period. | 58 |
| First sentence should end with a period. | 61 |
| Parameter conf should be final. | 68 |
| Parameter context should be final. | 69 |
| 'context' hides a field. | 69 |
| Method 'getVertexWriter' is not designed for extension - needs to be abstract, final or empty. | 77 |
| '+' should be on a new line. | 86 |
| '+' should be on a new line. | 89 |
| Method 'returnVertexWriter' is not designed for extension - needs to be abstract, final or empty. | 100 |
| Parameter vertexWriter should be final. | 102 |
| '+' should be on a new line. | 105 |
| Method 'postApplication' is not designed for extension - needs to be abstract, final or empty. | 111 |
| '+' should be on a new line. | 115 |
| '+' should be on a new line. | 116 |
org/apache/giraph/io/superstep_output/NoOpSuperstepOutput.java
| Violation | Message | Line |
|---|---|---|
| Method 'getVertexWriter' is not designed for extension - needs to be abstract, final or empty. | 39 |
| Parameter vertex should be final. | 43 |
| Parameter vertexWriter should be final. | 51 |
org/apache/giraph/io/superstep_output/SuperstepOutput.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 45 |
| First sentence should end with a period. | 53 |
| Expected @throws tag for 'IOException'. | 56 |
| Expected @throws tag for 'InterruptedException'. | 56 |
org/apache/giraph/io/superstep_output/SynchronizedSuperstepOutput.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 42 |
| First sentence should end with a period. | 44 |
| First sentence should end with a period. | 52 |
| Parameter conf should be final. | 60 |
| Parameter context should be final. | 61 |
| 'context' hides a field. | 61 |
| '+' should be on a new line. | 69 |
| '+' should be on a new line. | 72 |
| Parameter vertex should be final. | 78 |
| Method 'getVertexWriter' is not designed for extension - needs to be abstract, final or empty. | 84 |
| Parameter vertexWriter should be final. | 90 |
| 'vertexWriter' hides a field. | 90 |
| Method 'postApplication' is not designed for extension - needs to be abstract, final or empty. | 93 |
org/apache/giraph/io/superstep_output/package-info.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 18 |
org/apache/giraph/job/DefaultJobObserver.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 30 |
| Method 'setConf' is not designed for extension - needs to be abstract, final or empty. | 33 |
| Parameter configuration should be final. | 34 |
| Method 'getConf' is not designed for extension - needs to be abstract, final or empty. | 38 |
| Parameter jobToSubmit should be final. | 44 |
| Parameter jobToSubmit should be final. | 49 |
| Parameter passed should be final. | 49 |
org/apache/giraph/job/GiraphConfigurationValidator.java
| Violation | Message | Line |
|---|---|---|
| Name 'LOG' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 63 |
| First sentence should end with a period. | 66 |
| First sentence should end with a period. | 68 |
| First sentence should end with a period. | 70 |
| First sentence should end with a period. | 72 |
| First sentence should end with a period. | 74 |
| First sentence should end with a period. | 76 |
| First sentence should end with a period. | 78 |
| First sentence should end with a period. | 80 |
| First sentence should end with a period. | 83 |
| First sentence should end with a period. | 85 |
| First sentence should end with a period. | 87 |
| First sentence should end with a period. | 89 |
| Parameter conf should be final. | 103 |
| 'conf' hides a field. | 103 |
| Method 'validateConfiguration' is not designed for extension - needs to be abstract, final or empty. | 113 |
| '+' should be on a new line. | 138 |
| '||' should be on a new line. | 141 |
| '100.0f' is a magic number. | 142 |
| '+' should be on a new line. | 144 |
| '+' should be on a new line. | 148 |
| '+' should be on a new line. | 152 |
| '&&' should be on a new line. | 155 |
| '+' should be on a new line. | 157 |
| '+' should be on a new line. | 158 |
| '+' should be on a new line. | 159 |
| '+' should be on a new line. | 164 |
| '+' should be on a new line. | 165 |
| '+' should be on a new line. | 166 |
| '+' should be on a new line. | 172 |
| '+' should be on a new line. | 173 |
| Parameter outEdgesClass should be final. | 185 |
| '&&' should be on a new line. | 193 |
| '+' should be on a new line. | 196 |
| '+' should be on a new line. | 197 |
| '&&' should be on a new line. | 200 |
| '+' should be on a new line. | 203 |
| '+' should be on a new line. | 204 |
| '+' should be on a new line. | 205 |
| '+' should be on a new line. | 232 |
| '+' should be on a new line. | 233 |
| '+' should be on a new line. | 240 |
| '+' should be on a new line. | 241 |
| '+' should be on a new line. | 248 |
| '+' should be on a new line. | 249 |
| '+' should be on a new line. | 267 |
| '+' should be on a new line. | 268 |
| '+' should be on a new line. | 276 |
| '+' should be on a new line. | 277 |
| '+' should be on a new line. | 278 |
| '+' should be on a new line. | 294 |
| '+' should be on a new line. | 295 |
| '+' should be on a new line. | 301 |
| '+' should be on a new line. | 302 |
| '+' should be on a new line. | 320 |
| '+' should be on a new line. | 321 |
| '+' should be on a new line. | 328 |
| '+' should be on a new line. | 329 |
| '+' should be on a new line. | 336 |
| '+' should be on a new line. | 337 |
| First sentence should end with a period. | 343 |
| '&&' should be on a new line. | 352 |
| '+' should be on a new line. | 356 |
| '+' should be on a new line. | 357 |
| '+' should be on a new line. | 358 |
| '&&' should be on a new line. | 377 |
| '+' should be on a new line. | 380 |
| '+' should be on a new line. | 381 |
| '&&' should be on a new line. | 384 |
| '+' should be on a new line. | 387 |
| '+' should be on a new line. | 388 |
| '&&' should be on a new line. | 391 |
| '+' should be on a new line. | 394 |
| '+' should be on a new line. | 395 |
org/apache/giraph/job/GiraphJob.java
| Violation | Message | Line |
|---|---|---|
| First sentence should end with a period. | 44 |
| First sentence should end with a period. | 46 |
| First sentence should end with a period. | 48 |
| First sentence should end with a period. | 50 |
| First sentence should end with a period. | 57 |
| First sentence should end with a period. | 60 |
| Expected @throws tag for 'IOException'. | 65 |
| First sentence should end with a period. | 77 |
| Parameter jobName should be final. | 83 |
| 'jobName' hides a field. | 83 |
| Expected @throws tag for 'IOException'. | 83 |
| Parameter configuration should be final. | 94 |
| Parameter jobName should be final. | 95 |
| 'jobName' hides a field. | 95 |
| Expected @throws tag for 'IOException'. | 95 |
| Parameter giraphConfiguration should be final. | 106 |
| 'giraphConfiguration' hides a field. | 106 |
| Parameter jobName should be final. | 107 |
| 'jobName' hides a field. | 107 |
| Expected @throws tag for 'IOException'. | 107 |
| Method 'getConfiguration' is not designed for extension - needs to be abstract, final or empty. | 118 |
| Method 'getInternalJob' is not designed for extension - needs to be abstract, final or empty. | 129 |
| Parameter conf should be final. | 142 |
| '+' should be on a new line. | 152 |
| '+' should be on a new line. | 153 |
| '+' should be on a new line. | 158 |
| '+' should be on a new line. | 159 |
| Parameter param should be final. | 170 |
| Parameter defaultValue should be final. | 170 |
| '==' should be on a new line. | 171 |
| Parameter verbose should be final. | 186 |
| Expected @throws tag for 'IOException'. | 187 |
| Expected @throws tag for 'InterruptedException'. | 187 |
| Expected @throws tag for 'ClassNotFoundException'. | 187 |
| '512' is a magic number. | 189 |
| '1024' is a magic number. | 193 |
| '60000' is a magic number. | 202 |
| '5' is a magic number. | 202 |
| '+' should be on a new line. | 215 |
| '+' should be on a new line. | 216 |
| '+' should be on a new line. | 217 |
org/apache/giraph/job/HadoopUtils.java
| Violation | Message | Line |
|---|---|---|
| Class HadoopUtils should be declared as final. | 34 |
| First sentence should end with a period. | 35 |
| Parameter conf should be final. | 44 |
| Parameter conf should be final. | 69 |
org/apache/giraph/master/BspServiceMaster.java
| Violation | Message | Line |
|---|---|---|
| Line is longer than 80 characters. | 110 |
| First sentence should end with a period. | 126 |
| First sentence should end with a period. | 128 |
| First sentence should end with a period. | 131 |
| First sentence should end with a period. | 133 |
| First sentence should end with a period. | 135 |
| First sentence should end with a period. | 139 |
| First sentence should end with a period. | 141 |
| First sentence should end with a period. | 143 |
| First sentence should end with a period. | 145 |
| First sentence should end with a period. | 147 |
| First sentence should end with a period. | 149 |
| First sentence should end with a period. | 151 |
| First sentence should end with a period. | 153 |
| First sentence should end with a period. | 155 |
| First sentence should end with a period. | 157 |
| First sentence should end with a period. | 159 |
| First sentence should end with a period. | 161 |
| First sentence should end with a period. | 164 |
| First sentence should end with a period. | 166 |
| First sentence should end with a period. | 168 |
| First sentence should end with a period. | 170 |
| First sentence should end with a period. | 172 |
| First sentence should end with a period. | 174 |
| First sentence should end with a period. | 176 |
| First sentence should end with a period. | 182 |
| Parameter serverPortList should be final. | 194 |
| Parameter sessionMsecTimeout should be final. | 195 |
| Parameter context should be final. | 196 |
| Parameter graphTaskManager should be final. | 197 |
| Method 'newSuperstep' is not designed for extension - needs to be abstract, final or empty. | 225 |
| Parameter superstepMetrics should be final. | 226 |
| Method 'setJobState' is not designed for extension - needs to be abstract, final or empty. | 231 |
| Parameter state should be final. | 232 |
| Parameter applicationAttempt should be final. | 233 |
| Parameter desiredSuperstep should be final. | 234 |
| Parameter state should be final. | 247 |
| Parameter applicationAttempt should be final. | 248 |
| Parameter desiredSuperstep should be final. | 249 |
| Parameter killJobOnFailure should be final. | 250 |
| '+' should be on a new line. | 257 |
| '+' should be on a new line. | 261 |
| '+' should be on a new line. | 272 |
| '+' should be on a new line. | 276 |
| '+' should be on a new line. | 280 |
| Parameter reason should be final. | 295 |
| Parameter inputFormat should be final. | 308 |
| Parameter minSplitCountHint should be final. | 309 |
| Parameter inputSplitType should be final. | 310 |
| '100f' is a magic number. | 324 |
| '+' should be on a new line. | 326 |
| '+' should be on a new line. | 327 |
| '+' should be on a new line. | 332 |
| Parameter e should be final. | 344 |
| '+' should be on a new line. | 350 |
| Parameter workerInfosPath should be final. | 378 |
| Parameter watch should be final. | 379 |
| First sentence should end with a period. | 401 |
| Parameter superstep should be final. | 410 |
| Parameter healthyWorkerInfoList should be final. | 411 |
| Parameter unhealthyWorkerInfoList should be final. | 412 |
| ':' should be on a new line. | 449 |
| ':' should be on a new line. | 457 |
| '+' should be on a new line. | 482 |
| '100.0f' is a magic number. | 484 |
| '>=' should be on a new line. | 484 |
| '+' should be on a new line. | 489 |
| '+' should be on a new line. | 490 |
| '+' should be on a new line. | 491 |
| '+' should be on a new line. | 492 |
| '+' should be on a new line. | 493 |
| '+' should be on a new line. | 498 |
| '+' should be on a new line. | 505 |
| '+' should be on a new line. | 506 |
| '+' should be on a new line. | 507 |
| '+' should be on a new line. | 508 |
| '+' should be on a new line. | 509 |
| '+' should be on a new line. | 510 |
| '<=' should be on a new line. | 513 |
| '+' should be on a new line. | 521 |
| '+' should be on a new line. | 522 |
| '+' should be on a new line. | 523 |
| '+' should be on a new line. | 524 |
| '+' should be on a new line. | 525 |
| '+' should be on a new line. | 531 |
| '+' should be on a new line. | 538 |
| '+' should be on a new line. | 539 |
| '+' should be on a new line. | 540 |
| First sentence should end with a period. | 546 |
| Parameter healthyWorkerInfoList should be final. | 553 |
| Parameter unhealthyWorkerInfoList should be final. | 554 |
| '+' should be on a new line. | 569 |
| Parameter inputFormat should be final. | 585 |
| Parameter inputSplitPaths should be final. | 586 |
| Parameter inputSplitType should be final. | 587 |
| '+' should be on a new line. | 603 |
| '*' should be on a new line. | 621 |
| '+' should be on a new line. | 630 |
| '+' should be on a new line. | 632 |
| '+' should be on a new line. | 637 |
| '+' should be on a new line. | 638 |
| '+' should be on a new line. | 639 |
| '+' should be on a new line. | 640 |
| '+' should be on a new line. | 648 |
| '+' should be on a new line. | 674 |
| Method 'createVertexInputSplits' is not designed for extension - needs to be abstract, final or empty. | 685 |
| Method 'createEdgeInputSplits' is not designed for extension - needs to be abstract, final or empty. | 697 |
| Method 'getWorkerInfoList' is not designed for extension - needs to be abstract, final or empty. | 709 |
| Method 'getAggregatorHandler' is not designed for extension - needs to be abstract, final or empty. | 714 |
| Parameter superstep should be final. | 734 |
| Parameter partitionOwners should be final. | 735 |
| Expected @throws tag for 'IOException'. | 736 |
| Expected @throws tag for 'KeeperException'. | 736 |
| Expected @throws tag for 'InterruptedException'. | 736 |
| '+' should be on a new line. | 766 |
| '-' should be on a new line. | 777 |
| '+' should be on a new line. | 786 |
| '+' should be on a new line. | 787 |
| '+' should be on a new line. | 788 |
| Method 'setup' is not designed for extension - needs to be abstract, final or empty. | 797 |
| Method 'becomeMaster' is not designed for extension - needs to be abstract, final or empty. | 814 |
| '+' should be on a new line. | 821 |
| '&&' should be on a new line. | 837 |
| '==' should be on a new line. | 839 |
| '+' should be on a new line. | 841 |
| '+' should be on a new line. | 855 |
| '+' should be on a new line. | 856 |
| Method 'getMasterInfo' is not designed for extension - needs to be abstract, final or empty. | 895 |
| Parameter superstep should be final. | 906 |
| '&&' should be on a new line. | 951 |